Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1391761 > unrolled thread

[tip:perf/core] bpf tools: Remove expression with no effect

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [tip:perf/core] bpf tools: Remove expression with no effect tip-bot for Florian Fainelli <tipbot@zytor.com> - 2016-05-01 09:40 +0200

#1391761 — [tip:perf/core] bpf tools: Remove expression with no effect

Commit-ID:  a431d67934dfe9ffbe65972b0dbe576331595186
Gitweb:     http://git.kernel.org/tip/a431d67934dfe9ffbe65972b0dbe576331595186
Author:     Florian Fainelli <f.fainelli@gmail.com>
AuthorDate: Sun, 24 Apr 2016 19:34:53 -0700
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Thu, 28 Apr 2016 09:58:57 -0300

bpf tools: Remove expression with no effect

Assigning "attr" to "attr" does not have any effect, but was caught by
Coverity, so let's remove this.

Reported-by: coverity (CID 1354720)
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Tested-by: Wang Nan <wangnan0@huawei.com>
Acked-by: Alexei Starovoitov <ast@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Fixes: 1b76c13e4b36 ("bpf tools: Introduce 'bpf' library and add bpf feature check")
Link: http://lkml.kernel.org/r/1461551694-5512-2-git-send-email-f.fainelli@gmail.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/build/feature/test-bpf.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tools/build/feature/test-bpf.c b/tools/build/feature/test-bpf.c
index b389026..8236df9 100644
--- a/tools/build/feature/test-bpf.c
+++ b/tools/build/feature/test-bpf.c
@@ -27,7 +27,6 @@ int main(void)
 	attr.log_level = 0;
 	attr.kern_version = 0;
 
-	attr = attr;
 	/*
 	 * Test existence of __NR_bpf and BPF_PROG_LOAD.
 	 * This call should fail if we run the testcase.

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web