Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1391668 > unrolled thread

Re: [PATCH 1/3] phy: rockchip-usb: should be a child device of the GRF

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 1/3] phy: rockchip-usb: should be a child device of the GRF Heiko Stübner <heiko@sntech.de> - 2016-04-30 22:10 +0200
    Re: [PATCH 1/3] phy: rockchip-usb: should be a child device of the  GRF Kishon Vijay Abraham I <kishon@ti.com> - 2016-05-03 13:00 +0200
      Re: [PATCH 1/3] phy: rockchip-usb: should be a child device of the GRF Heiko Stübner <heiko@sntech.de> - 2016-05-03 13:10 +0200

#1391668 — Re: [PATCH 1/3] phy: rockchip-usb: should be a child device of the GRF

Hi Kishon,

Am Dienstag, 19. April 2016, 08:13:47 schrieb Heiko Stübner:
> Hi Kishon.
> 
> Am Donnerstag, 31. März 2016, 15:43:30 schrieb Heiko Stuebner:
> > The usb-phy is fully enclosed in the general register files (GRF).
> > Therefore as seen from the device-tree it shouldn't be a separate
> > platform-
> > device but instead a sub-device of the GRF - using the simply-mfd
> > mechanism.
> > 
> > As the usb-phy is part of the kernel for some releases now, we keep
> > the old (and now deprecated) binding for compatibility purposes.
> > 
> > Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> 
> could you look into picking this patch up for 4.7?
> 
> Same principle as for the other phy drivers, but it's already in the kernel
> for a while, so it gets a fallback for the old binding and can go through
> the normal way.
> 
> The other two (devicetree-)patches I would then simply queue for 4.8 myself
> after you're fine with the driver-side.

just saw that you already have a tag for 4.7-related phy changes since this 
afternoon, but no phy pull to Greg on lkml yet.

So maybe there is still a way for this phy conversion (to be under the 
Rockchip GRF node) to make it in for 4.7 :-) ?


Thanks
Heiko

[toc] | [next] | [standalone]

#1393331 — Re: [PATCH 1/3] phy: rockchip-usb: should be a child device of the GRF

On Sunday 01 May 2016 01:37 AM, Heiko Stübner wrote:
> Hi Kishon,
> 
> Am Dienstag, 19. April 2016, 08:13:47 schrieb Heiko Stübner:
>> Hi Kishon.
>>
>> Am Donnerstag, 31. März 2016, 15:43:30 schrieb Heiko Stuebner:
>>> The usb-phy is fully enclosed in the general register files (GRF).
>>> Therefore as seen from the device-tree it shouldn't be a separate
>>> platform-
>>> device but instead a sub-device of the GRF - using the simply-mfd
>>> mechanism.
>>>
>>> As the usb-phy is part of the kernel for some releases now, we keep
>>> the old (and now deprecated) binding for compatibility purposes.
>>>
>>> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
>>
>> could you look into picking this patch up for 4.7?
>>
>> Same principle as for the other phy drivers, but it's already in the kernel
>> for a while, so it gets a fallback for the old binding and can go through
>> the normal way.
>>
>> The other two (devicetree-)patches I would then simply queue for 4.8 myself
>> after you're fine with the driver-side.
> 
> just saw that you already have a tag for 4.7-related phy changes since this 
> afternoon, but no phy pull to Greg on lkml yet.
> 
> So maybe there is still a way for this phy conversion (to be under the 
> Rockchip GRF node) to make it in for 4.7 :-) ?

Looks like I've missed this before sending the pull request. Sorry about that.
Is it okay if the PHY changes also go in 4.8?

-Kishon

[toc] | [prev] | [next] | [standalone]

#1393334

Hi Kishon,

Am Dienstag, 3. Mai 2016, 16:28:35 schrieb Kishon Vijay Abraham I:
> On Sunday 01 May 2016 01:37 AM, Heiko Stübner wrote:
> > Am Dienstag, 19. April 2016, 08:13:47 schrieb Heiko Stübner:
> >> Am Donnerstag, 31. März 2016, 15:43:30 schrieb Heiko Stuebner:
> >>> The usb-phy is fully enclosed in the general register files (GRF).
> >>> Therefore as seen from the device-tree it shouldn't be a separate
> >>> platform-
> >>> device but instead a sub-device of the GRF - using the simply-mfd
> >>> mechanism.
> >>> 
> >>> As the usb-phy is part of the kernel for some releases now, we keep
> >>> the old (and now deprecated) binding for compatibility purposes.
> >>> 
> >>> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> >> 
> >> could you look into picking this patch up for 4.7?
> >> 
> >> Same principle as for the other phy drivers, but it's already in the
> >> kernel
> >> for a while, so it gets a fallback for the old binding and can go through
> >> the normal way.
> >> 
> >> The other two (devicetree-)patches I would then simply queue for 4.8
> >> myself
> >> after you're fine with the driver-side.
> > 
> > just saw that you already have a tag for 4.7-related phy changes since
> > this
> > afternoon, but no phy pull to Greg on lkml yet.
> > 
> > So maybe there is still a way for this phy conversion (to be under the
> > Rockchip GRF node) to make it in for 4.7 :-) ?
> 
> Looks like I've missed this before sending the pull request. Sorry about
> that. Is it okay if the PHY changes also go in 4.8?

yep, 4.8 is no problem as well. We have the current binding in the kernel for 
so long, that waiting one more kernel release won't be a problem.


Heiko

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web