Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1391667 > unrolled thread

[PATCH] vfs: use RCU_INIT_POINTER when NULLing

Back to article view | Back to linux.kernel

Contents

  [PATCH] vfs: use RCU_INIT_POINTER when NULLing Muhammad Falak R Wani <falakreyaz@gmail.com> - 2016-04-30 22:10 +0200
    Re: [PATCH] vfs: use RCU_INIT_POINTER when NULLing Christoph Hellwig <hch@infradead.org> - 2016-05-01 19:40 +0200

#1391667 — [PATCH] vfs: use RCU_INIT_POINTER when NULLing

It is always safe to use RCU_INIT_POINTER to NULL a pointer. This
results in slightly smaller/faster code.

The following semantic patch used:
<smpl>
@@
@@
- rcu_assign_pointer
+ RCU_INIT_POINTER
  (..., NULL)

</smpl>

Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
---
 fs/file.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/fs/file.c b/fs/file.c
index 1fbc5c0..e027b33 100644
--- a/fs/file.c
+++ b/fs/file.c
@@ -543,7 +543,7 @@ repeat:
 	/* Sanity check */
 	if (rcu_access_pointer(fdt->fd[fd]) != NULL) {
 		printk(KERN_WARNING "alloc_fd: slot %d not NULL!\n", fd);
-		rcu_assign_pointer(fdt->fd[fd], NULL);
+		RCU_INIT_POINTER(fdt->fd[fd], NULL);
 	}
 #endif
 
@@ -644,7 +644,7 @@ int __close_fd(struct files_struct *files, unsigned fd)
 	file = fdt->fd[fd];
 	if (!file)
 		goto out_unlock;
-	rcu_assign_pointer(fdt->fd[fd], NULL);
+	RCU_INIT_POINTER(fdt->fd[fd], NULL);
 	__clear_close_on_exec(fd, fdt);
 	__put_unused_fd(files, fd);
 	spin_unlock(&files->file_lock);
@@ -679,7 +679,7 @@ void do_close_on_exec(struct files_struct *files)
 			file = fdt->fd[fd];
 			if (!file)
 				continue;
-			rcu_assign_pointer(fdt->fd[fd], NULL);
+			RCU_INIT_POINTER(fdt->fd[fd], NULL);
 			__put_unused_fd(files, fd);
 			spin_unlock(&files->file_lock);
 			filp_close(file, files);
-- 
1.9.1

[toc] | [next] | [standalone]

#1391854

On Sun, May 01, 2016 at 01:39:12AM +0530, Muhammad Falak R Wani wrote:
> It is always safe to use RCU_INIT_POINTER to NULL a pointer. This
> results in slightly smaller/faster code.

Just fix rcu_assign_pointer to do the right thing for a NULL
argument instead. 

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web