Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1391596 > unrolled thread

Re: [PATCH V11 6/6] gpio: max77620: add gpio driver for MAX77620/MAX20024

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH V11 6/6] gpio: max77620: add gpio driver for MAX77620/MAX20024 Linus Walleij <linus.walleij@linaro.org> - 2016-04-30 13:40 +0200
    Re: [PATCH V11 6/6] gpio: max77620: add gpio driver for MAX77620/MAX20024 Laxman Dewangan <ldewangan@nvidia.com> - 2016-05-02 08:40 +0200

#1391596 — Re: [PATCH V11 6/6] gpio: max77620: add gpio driver for MAX77620/MAX20024

On Thu, Apr 28, 2016 at 11:59 AM, Laxman Dewangan <ldewangan@nvidia.com> wrote:

> MAXIM Semiconductor's PMIC, MAX77620/MAX20024 has 8 GPIO
> pins. It also supports interrupts from these pins.
>
> Add GPIO driver for these pins to control via GPIO APIs.
>
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Gnah there is still a problem with this, I just saw it:

> +config GPIO_MAX77620
> +       bool "GPIO support for PMIC MAX77620 and MAX20024"

bool == not a module

> +MODULE_DEVICE_TABLE(platform, max77620_gpio_devtype);
(...)
> +module_platform_driver(max77620_gpio_driver);
(...)
> +MODULE_DESCRIPTION("GPIO interface for MAX77620 and MAX20024 PMIC");
> +MODULE_AUTHOR("Laxman Dewangan <ldewangan@nvidia.com>");
> +MODULE_AUTHOR("Chaitanya Bandi <bandik@nvidia.com>");
> +MODULE_ALIAS("platform:max77620-gpio");
> +MODULE_LICENSE("GPL v2");

git log --author=Gortmaker and you will see what you need to do.

Yours,
Linus Walleij

[toc] | [next] | [standalone]

#1392010

On Saturday 30 April 2016 05:08 PM, Linus Walleij wrote:
> On Thu, Apr 28, 2016 at 11:59 AM, Laxman Dewangan <ldewangan@nvidia.com> wrote:
>
>> MAXIM Semiconductor's PMIC, MAX77620/MAX20024 has 8 GPIO
>> pins. It also supports interrupts from these pins.
>>
>> Add GPIO driver for these pins to control via GPIO APIs.
>>
>> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
>> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> Gnah there is still a problem with this, I just saw it:
>
>> +config GPIO_MAX77620
>> +       bool "GPIO support for PMIC MAX77620 and MAX20024"
> bool == not a module

Yaah, looked the changes from Gortmaker.
The things are evolving faster.

I think we can change "bool" to "tristate" here.
Then there is no need to have code change. MFD driver is already said as 
tristate.


I will wait for Lee's comment on this series patch before recycling the 
patch. (Already on V11 :-(  ).

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web