Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1390770 > unrolled thread

[PATCH] staging: rts5208: Avoid multiple assignment in one line

Back to article view | Back to linux.kernel

Contents

  [PATCH] staging: rts5208: Avoid multiple assignment in one line Manav Batra <batmanav10@gmail.com> - 2016-04-29 07:50 +0200
    Re: [PATCH] staging: rts5208: Avoid multiple assignment in one line Greg KH <gregkh@linuxfoundation.org> - 2016-04-30 02:50 +0200

#1390770 — [PATCH] staging: rts5208: Avoid multiple assignment in one line

Signed-off-by: Manav Batra <batmanav10@gmail.com>

Separates out assignment in one line to two lines.
---
 drivers/staging/rts5208/rtsx.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c
index 25d095a..77c2580 100644
--- a/drivers/staging/rts5208/rtsx.c
+++ b/drivers/staging/rts5208/rtsx.c
@@ -105,13 +105,13 @@ static int slave_configure(struct scsi_device *sdev)
 	 * the actual value or the modified one, depending on where the
 	 * data comes from.
 	 */
-	if (sdev->scsi_level < SCSI_2)
-		sdev->scsi_level = sdev->sdev_target->scsi_level = SCSI_2;
-
+	if (sdev->scsi_level < SCSI_2) {
+		sdev->scsi_level  = SCSI_2;
+		sdev->sdev_target->scsi_level = SCSI_2;
+	}
 	return 0;
 }
 
-
 /***********************************************************************
  * /proc/scsi/ functions
  ***********************************************************************/
-- 
1.9.1

[toc] | [next] | [standalone]

#1391549

On Thu, Apr 28, 2016 at 10:42:07PM -0700, Manav Batra wrote:
> Signed-off-by: Manav Batra <batmanav10@gmail.com>
> 
> Separates out assignment in one line to two lines.

signed-off-by goes at the end of the text, not at the top.

Please fix all of these and resend.

thanks,

greg k-h

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web