Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1390683 > unrolled thread

[RFC v5 1/4] gpio: generic: fix GPIO_GENERIC_PLATFORM is set to module case

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [RFC v5 1/4] gpio: generic: fix GPIO_GENERIC_PLATFORM is set to module case Christian Lamparter <chunkeey@googlemail.com> - 2016-04-29 03:00 +0200
    Re: [RFC v5 1/4] gpio: generic: fix GPIO_GENERIC_PLATFORM is set to  module case Linus Walleij <linus.walleij@linaro.org> - 2016-04-29 16:20 +0200

#1390683 — [RFC v5 1/4] gpio: generic: fix GPIO_GENERIC_PLATFORM is set to module case

GPIO_GENERIC_PLATFORM is a tristate. If the module option is
selected the resulting gpio-generic.ko will lack most of the
module initialzation and probe code.

Signed-off-by: Christian Lamparter <chunkeey@googlemail.com>
---
 drivers/gpio/gpio-generic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-generic.c b/drivers/gpio/gpio-generic.c
index 54cddfa..6c1cb3b 100644
--- a/drivers/gpio/gpio-generic.c
+++ b/drivers/gpio/gpio-generic.c
@@ -549,7 +549,7 @@ int bgpio_init(struct gpio_chip *gc, struct device *dev,
 }
 EXPORT_SYMBOL_GPL(bgpio_init);
 
-#ifdef CONFIG_GPIO_GENERIC_PLATFORM
+#if IS_ENABLED(CONFIG_GPIO_GENERIC_PLATFORM)
 
 static void __iomem *bgpio_map(struct platform_device *pdev,
 			       const char *name,
-- 
2.8.1

[toc] | [next] | [standalone]

#1391191 — Re: [RFC v5 1/4] gpio: generic: fix GPIO_GENERIC_PLATFORM is set to module case

On Fri, Apr 29, 2016 at 2:53 AM, Christian Lamparter
<chunkeey@googlemail.com> wrote:

> GPIO_GENERIC_PLATFORM is a tristate. If the module option is
> selected the resulting gpio-generic.ko will lack most of the
> module initialzation and probe code.
>
> Signed-off-by: Christian Lamparter <chunkeey@googlemail.com>

Obviously correct, patch applied.

Yours,
Linus Walleij

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web