Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1390299 > unrolled thread

[PATCH 1/4] f2fs: fix to clear private data in page

Back to article view | Back to linux.kernel

Contents

  [PATCH 1/4] f2fs: fix to clear private data in page Chao Yu <chao@kernel.org> - 2016-04-28 17:20 +0200
    Re: [PATCH 1/4] f2fs: fix to clear private data in page Jaegeuk Kim <jaegeuk@kernel.org> - 2016-04-29 01:30 +0200
      Re: [PATCH 1/4] f2fs: fix to clear private data in page Chao Yu <chao@kernel.org> - 2016-04-29 13:20 +0200

#1390299 — [PATCH 1/4] f2fs: fix to clear private data in page

From: Chao Yu <yuchao0@huawei.com>

Private data in page should be removed during ->releasepage or
->invalidatepage, otherwise garbage data would be remained in that page.

Signed-off-by: Chao Yu <yuchao0@huawei.com>
---
 fs/f2fs/data.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index 38ce5d6..888f178 100644
--- a/fs/f2fs/data.c
+++ b/fs/f2fs/data.c
@@ -1723,6 +1723,7 @@ void f2fs_invalidate_page(struct page *page, unsigned int
offset,
 	if (IS_ATOMIC_WRITTEN_PAGE(page))
 		return;

+	set_page_private(page, 0);
 	ClearPagePrivate(page);
 }

@@ -1736,6 +1737,7 @@ int f2fs_release_page(struct page *page, gfp_t wait)
 	if (IS_ATOMIC_WRITTEN_PAGE(page))
 		return 0;

+	set_page_private(page, 0);
 	ClearPagePrivate(page);
 	return 1;
 }
-- 
2.7.2

[toc] | [next] | [standalone]

#1390644

Hi Chao,

Could you check your email setting?
All the patches are corrupted, as git am says.

Thanks,

On Thu, Apr 28, 2016 at 11:13:48PM +0800, Chao Yu wrote:
> From: Chao Yu <yuchao0@huawei.com>
> 
> Private data in page should be removed during ->releasepage or
> ->invalidatepage, otherwise garbage data would be remained in that page.
> 
> Signed-off-by: Chao Yu <yuchao0@huawei.com>
> ---
>  fs/f2fs/data.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
> index 38ce5d6..888f178 100644
> --- a/fs/f2fs/data.c
> +++ b/fs/f2fs/data.c
> @@ -1723,6 +1723,7 @@ void f2fs_invalidate_page(struct page *page, unsigned int
> offset,
>  	if (IS_ATOMIC_WRITTEN_PAGE(page))
>  		return;
> 
> +	set_page_private(page, 0);
>  	ClearPagePrivate(page);
>  }
> 
> @@ -1736,6 +1737,7 @@ int f2fs_release_page(struct page *page, gfp_t wait)
>  	if (IS_ATOMIC_WRITTEN_PAGE(page))
>  		return 0;
> 
> +	set_page_private(page, 0);
>  	ClearPagePrivate(page);
>  	return 1;
>  }
> -- 
> 2.7.2

[toc] | [prev] | [next] | [standalone]

#1391016

Hi Jaegeuk,

On 2016/4/29 7:29, Jaegeuk Kim wrote:
> Hi Chao,
> 
> Could you check your email setting?
> All the patches are corrupted, as git am says.

My bad, I use thunderbird for sending patches, but yesterday I upgrade it to
version 45.0, it forces wrapping long line for email content, so the patches
become corrupted to git-am.

Later, I will resend them.

Thanks,

> 
> Thanks,
> 
> On Thu, Apr 28, 2016 at 11:13:48PM +0800, Chao Yu wrote:
>> From: Chao Yu <yuchao0@huawei.com>
>>
>> Private data in page should be removed during ->releasepage or
>> ->invalidatepage, otherwise garbage data would be remained in that page.
>>
>> Signed-off-by: Chao Yu <yuchao0@huawei.com>
>> ---
>>  fs/f2fs/data.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
>> index 38ce5d6..888f178 100644
>> --- a/fs/f2fs/data.c
>> +++ b/fs/f2fs/data.c
>> @@ -1723,6 +1723,7 @@ void f2fs_invalidate_page(struct page *page, unsigned int
>> offset,
>>  	if (IS_ATOMIC_WRITTEN_PAGE(page))
>>  		return;
>>
>> +	set_page_private(page, 0);
>>  	ClearPagePrivate(page);
>>  }
>>
>> @@ -1736,6 +1737,7 @@ int f2fs_release_page(struct page *page, gfp_t wait)
>>  	if (IS_ATOMIC_WRITTEN_PAGE(page))
>>  		return 0;
>>
>> +	set_page_private(page, 0);
>>  	ClearPagePrivate(page);
>>  	return 1;
>>  }
>> -- 
>> 2.7.2

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web