Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1387177 > unrolled thread

[PATCH] mmc: dw_mmc-rockchip: add MMC_CAP_CMD23 capabilities

Started byShawn Lin <shawn.lin@rock-chips.com>
First post2016-04-26 09:00 +0200
Last post2016-04-27 10:40 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] mmc: dw_mmc-rockchip: add MMC_CAP_CMD23 capabilities Shawn Lin <shawn.lin@rock-chips.com> - 2016-04-26 09:00 +0200
    Re: [PATCH] mmc: dw_mmc-rockchip: add MMC_CAP_CMD23 capabilities Jaehoon Chung <jh80.chung@samsung.com> - 2016-04-27 10:40 +0200

#1387177 — [PATCH] mmc: dw_mmc-rockchip: add MMC_CAP_CMD23 capabilities

FromShawn Lin <shawn.lin@rock-chips.com>
Date2016-04-26 09:00 +0200
Subject[PATCH] mmc: dw_mmc-rockchip: add MMC_CAP_CMD23 capabilities
Message-ID<rs58u-2ZZ-17@gated-at.bofh.it>
Add MMC_CAP_CMD23 for dw_mmc-rockchip, otherwise
failing to create rpmb partition. With it, we can
get rpmb successfully:

mmc1: new HS200 MMC card at address 0001
mmcblk0: mmc1:0001 DS2016 14.7 GiB
mmcblk0boot0: mmc1:0001 DS2016 partition 1 4.00 MiB
mmcblk0boot1: mmc1:0001 DS2016 partition 2 4.00 MiB
mmcblk0rpmb: mmc1:0001 DS2016 partition 3 4.00 MiB

Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
---

 drivers/mmc/host/dw_mmc-rockchip.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/mmc/host/dw_mmc-rockchip.c b/drivers/mmc/host/dw_mmc-rockchip.c
index 8c20b81..2b4bcd2 100644
--- a/drivers/mmc/host/dw_mmc-rockchip.c
+++ b/drivers/mmc/host/dw_mmc-rockchip.c
@@ -233,10 +233,10 @@ static int dw_mci_rockchip_init(struct dw_mci *host)
 
 /* Common capabilities of RK3288 SoC */
 static unsigned long dw_mci_rk3288_dwmmc_caps[4] = {
-	MMC_CAP_ERASE,
-	MMC_CAP_ERASE,
-	MMC_CAP_ERASE,
-	MMC_CAP_ERASE,
+	MMC_CAP_ERASE | MMC_CAP_CMD23,
+	MMC_CAP_ERASE | MMC_CAP_CMD23,
+	MMC_CAP_ERASE | MMC_CAP_CMD23,
+	MMC_CAP_ERASE | MMC_CAP_CMD23,
 };
 
 static const struct dw_mci_drv_data rk2928_drv_data = {
-- 
2.3.7

[toc] | [next] | [standalone]


#1388791

FromJaehoon Chung <jh80.chung@samsung.com>
Date2016-04-27 10:40 +0200
Message-ID<rstaP-6zk-41@gated-at.bofh.it>
In reply to#1387177
Hi Shawn,

I will apply this. Thanks!

Best Regards,
Jaehoon Chung

On 04/26/2016 03:53 PM, Shawn Lin wrote:
> Add MMC_CAP_CMD23 for dw_mmc-rockchip, otherwise
> failing to create rpmb partition. With it, we can
> get rpmb successfully:
> 
> mmc1: new HS200 MMC card at address 0001
> mmcblk0: mmc1:0001 DS2016 14.7 GiB
> mmcblk0boot0: mmc1:0001 DS2016 partition 1 4.00 MiB
> mmcblk0boot1: mmc1:0001 DS2016 partition 2 4.00 MiB
> mmcblk0rpmb: mmc1:0001 DS2016 partition 3 4.00 MiB
> 
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
> ---
> 
>  drivers/mmc/host/dw_mmc-rockchip.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/mmc/host/dw_mmc-rockchip.c b/drivers/mmc/host/dw_mmc-rockchip.c
> index 8c20b81..2b4bcd2 100644
> --- a/drivers/mmc/host/dw_mmc-rockchip.c
> +++ b/drivers/mmc/host/dw_mmc-rockchip.c
> @@ -233,10 +233,10 @@ static int dw_mci_rockchip_init(struct dw_mci *host)
>  
>  /* Common capabilities of RK3288 SoC */
>  static unsigned long dw_mci_rk3288_dwmmc_caps[4] = {
> -	MMC_CAP_ERASE,
> -	MMC_CAP_ERASE,
> -	MMC_CAP_ERASE,
> -	MMC_CAP_ERASE,
> +	MMC_CAP_ERASE | MMC_CAP_CMD23,
> +	MMC_CAP_ERASE | MMC_CAP_CMD23,
> +	MMC_CAP_ERASE | MMC_CAP_CMD23,
> +	MMC_CAP_ERASE | MMC_CAP_CMD23,
>  };
>  
>  static const struct dw_mci_drv_data rk2928_drv_data = {
> 

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web