Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1387467 > unrolled thread
| Started by | Sergey Senozhatsky <sergey.senozhatsky@gmail.com> |
|---|---|
| First post | 2016-04-26 15:20 +0200 |
| Last post | 2016-04-27 10:10 +0200 |
| Articles | 4 — 4 participants |
Back to article view | Back to linux.kernel
[-mmots 2016-04-25] hugetlb: error: ‘cpu_has_pse’ undeclared Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2016-04-26 15:20 +0200
Re: [-mmots 2016-04-25] hugetlb: error: ‘cpu_has_pse’ undeclared Andrew Morton <akpm@linux-foundation.org> - 2016-04-27 00:10 +0200
Re: [-mmots 2016-04-25] hugetlb: error: ‘cpu_has_pse’ undeclared Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2016-04-27 02:40 +0200
Re: [-mmots 2016-04-25] hugetlb: error: ‘cpu_has_pse’ undeclared Ingo Molnar <mingo@kernel.org> - 2016-04-27 10:10 +0200
| From | Sergey Senozhatsky <sergey.senozhatsky@gmail.com> |
|---|---|
| Date | 2016-04-26 15:20 +0200 |
| Subject | [-mmots 2016-04-25] hugetlb: error: ‘cpu_has_pse’ undeclared |
| Message-ID | <rsb4e-8r9-17@gated-at.bofh.it> |
Hello,
v4.6-rc5-mmots-2016-04-25-17-33
In file included from include/linux/hugetlb.h:418:0,
from fs/hugetlbfs/inode.c:28:
fs/hugetlbfs/inode.c: In function ‘init_hugetlbfs_fs’:
./arch/x86/include/asm/hugetlb.h:7:31: error: ‘cpu_has_pse’ undeclared (first use in this function)
#define hugepages_supported() cpu_has_pse
^
fs/hugetlbfs/inode.c:1325:7: note: in expansion of macro ‘hugepages_supported’
if (!hugepages_supported()) {
^~~~~~~~~~~~~~~~~~~
./arch/x86/include/asm/hugetlb.h:7:31: note: each undeclared identifier is reported only once for each function it appears in
#define hugepages_supported() cpu_has_pse
^
fs/hugetlbfs/inode.c:1325:7: note: in expansion of macro ‘hugepages_supported’
if (!hugepages_supported()) {
^~~~~~~~~~~~~~~~~~~
scripts/Makefile.build:289: recipe for target 'fs/hugetlbfs/inode.o' failed
make[2]: *** [fs/hugetlbfs/inode.o] Error 1
scripts/Makefile.build:440: recipe for target 'fs/hugetlbfs' failed
make[1]: *** [fs/hugetlbfs] Error 2
make[1]: *** Waiting for unfinished jobs....
git grep cpu_has_pse
arch/x86/include/asm/hugetlb.h:#define hugepages_supported() cpu_has_pse
-ss
[toc] | [next] | [standalone]
| From | Andrew Morton <akpm@linux-foundation.org> |
|---|---|
| Date | 2016-04-27 00:10 +0200 |
| Message-ID | <rsjl7-70h-5@gated-at.bofh.it> |
| In reply to | #1387467 |
On Tue, 26 Apr 2016 23:14:35 +0900 Sergey Senozhatsky <sergey.senozhatsky@gmail.com> wrote: > Hello, > > v4.6-rc5-mmots-2016-04-25-17-33 > > > In file included from include/linux/hugetlb.h:418:0, > from fs/hugetlbfs/inode.c:28: > fs/hugetlbfs/inode.c: In function 'init_hugetlbfs_fs': > ./arch/x86/include/asm/hugetlb.h:7:31: error: 'cpu_has_pse' undeclared (first use in this function) > #define hugepages_supported() cpu_has_pse > ^ hm, how did that happen. I had some issues with cpu_has_pse a number of days ago but they later went away. In my current tree I have, in arch/x86/include/asm/hugetlb.h: #define hugepages_supported() boot_cpu_has(X86_FEATURE_PSE) and that came in from linux-next.patch. I wonder why your tree is different. <looks> OK, http://ozlabs.org/~akpm/mmots/broken-out/linux-next.patch has no changes to arch/x86/include/asm/hugetlb.h at all. Maybe I fat-fingered something. Odd. I have just uploaded a new snapshot - it should be good now. Sorry about that.
[toc] | [prev] | [next] | [standalone]
| From | Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> |
|---|---|
| Date | 2016-04-27 02:40 +0200 |
| Message-ID | <rslGi-kK-25@gated-at.bofh.it> |
| In reply to | #1388145 |
On (04/26/16 15:00), Andrew Morton wrote: > > v4.6-rc5-mmots-2016-04-25-17-33 > > > > > > In file included from include/linux/hugetlb.h:418:0, > > from fs/hugetlbfs/inode.c:28: > > fs/hugetlbfs/inode.c: In function 'init_hugetlbfs_fs': > > ./arch/x86/include/asm/hugetlb.h:7:31: error: 'cpu_has_pse' undeclared (first use in this function) > > #define hugepages_supported() cpu_has_pse > > ^ > > hm, how did that happen. I had some issues with cpu_has_pse a number > of days ago but they later went away. > > In my current tree I have, in arch/x86/include/asm/hugetlb.h: > > #define hugepages_supported() boot_cpu_has(X86_FEATURE_PSE) > > and that came in from linux-next.patch. I wonder why your tree is > different. > > <looks> > > OK, http://ozlabs.org/~akpm/mmots/broken-out/linux-next.patch has no > changes to arch/x86/include/asm/hugetlb.h at all. Maybe I fat-fingered > something. Odd. > > I have just uploaded a new snapshot - it should be good now. Sorry about > that. no worries. thanks! -ss
[toc] | [prev] | [next] | [standalone]
| From | Ingo Molnar <mingo@kernel.org> |
|---|---|
| Date | 2016-04-27 10:10 +0200 |
| Message-ID | <rssHM-6hy-7@gated-at.bofh.it> |
| In reply to | #1388145 |
* Andrew Morton <akpm@linux-foundation.org> wrote: > On Tue, 26 Apr 2016 23:14:35 +0900 Sergey Senozhatsky <sergey.senozhatsky@gmail.com> wrote: > > > Hello, > > > > v4.6-rc5-mmots-2016-04-25-17-33 > > > > > > In file included from include/linux/hugetlb.h:418:0, > > from fs/hugetlbfs/inode.c:28: > > fs/hugetlbfs/inode.c: In function 'init_hugetlbfs_fs': > > ./arch/x86/include/asm/hugetlb.h:7:31: error: 'cpu_has_pse' undeclared (first use in this function) > > #define hugepages_supported() cpu_has_pse > > ^ > > hm, how did that happen. I had some issues with cpu_has_pse a number > of days ago but they later went away. > > In my current tree I have, in arch/x86/include/asm/hugetlb.h: > > #define hugepages_supported() boot_cpu_has(X86_FEATURE_PSE) > > and that came in from linux-next.patch. I wonder why your tree is > different. > > <looks> > > OK, http://ozlabs.org/~akpm/mmots/broken-out/linux-next.patch has no > changes to arch/x86/include/asm/hugetlb.h at all. Maybe I fat-fingered > something. Odd. So I think the reason is that cpu_has_pse is gone from the x86 devel tree, please use this instead: boot_cpu_has(X86_FEATURE_PSE) Thanks, Ingo
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web