Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1388348 > unrolled thread
| Started by | Kees Cook <keescook@chromium.org> |
|---|---|
| First post | 2016-04-27 01:50 +0200 |
| Last post | 2016-04-27 18:20 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] scripts/spelling.txt: add "fimware" misspelling Kees Cook <keescook@chromium.org> - 2016-04-27 01:50 +0200
RE: [PATCH] scripts/spelling.txt: add "fimware" misspelling Zhao Lei <zhaolei@cn.fujitsu.com> - 2016-04-27 06:10 +0200
Re: [PATCH] scripts/spelling.txt: add "fimware" misspelling Kees Cook <keescook@chromium.org> - 2016-04-27 18:20 +0200
| From | Kees Cook <keescook@chromium.org> |
|---|---|
| Date | 2016-04-27 01:50 +0200 |
| Subject | [PATCH] scripts/spelling.txt: add "fimware" misspelling |
| Message-ID | <rskTU-85V-19@gated-at.bofh.it> |
A few instances of "fimware" instead of "firmware" were found. Fix these
and add it to the spelling.txt file.
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Kees Cook <keescook@chromium.org>
---
Looks like spelling.txt changes have been going in through -mm?
---
drivers/media/usb/dvb-usb/dib0700_core.c | 2 +-
drivers/scsi/bfa/bfi.h | 2 +-
drivers/staging/comedi/drivers/daqboard2000.c | 2 +-
scripts/spelling.txt | 1 +
4 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/media/usb/dvb-usb/dib0700_core.c b/drivers/media/usb/dvb-usb/dib0700_core.c
index c16f999b9d7c..bf890c3d9cda 100644
--- a/drivers/media/usb/dvb-usb/dib0700_core.c
+++ b/drivers/media/usb/dvb-usb/dib0700_core.c
@@ -517,7 +517,7 @@ int dib0700_download_firmware(struct usb_device *udev, const struct firmware *fw
if (nb_packet_buffer_size < 1)
nb_packet_buffer_size = 1;
- /* get the fimware version */
+ /* get the firmware version */
usb_control_msg(udev, usb_rcvctrlpipe(udev, 0),
REQUEST_GET_VERSION,
USB_TYPE_VENDOR | USB_DIR_IN, 0, 0,
diff --git a/drivers/scsi/bfa/bfi.h b/drivers/scsi/bfa/bfi.h
index 97600dcec649..5f698d038b21 100644
--- a/drivers/scsi/bfa/bfi.h
+++ b/drivers/scsi/bfa/bfi.h
@@ -356,7 +356,7 @@ struct bfi_ioc_image_hdr_s {
u8 port0_mode; /* device mode for port 0 */
u8 port1_mode; /* device mode for port 1 */
u32 exec; /* exec vector */
- u32 bootenv; /* fimware boot env */
+ u32 bootenv; /* firmware boot env */
u32 rsvd_b[2];
struct bfi_ioc_fwver_s fwver;
u32 md5sum[BFI_IOC_MD5SUM_SZ];
diff --git a/drivers/staging/comedi/drivers/daqboard2000.c b/drivers/staging/comedi/drivers/daqboard2000.c
index 57ab6680e3ae..a536a15c1d30 100644
--- a/drivers/staging/comedi/drivers/daqboard2000.c
+++ b/drivers/staging/comedi/drivers/daqboard2000.c
@@ -26,7 +26,7 @@
* Much of the functionality of this driver was determined from reading
* the source code for the Windows driver.
*
- * The FPGA on the board requires fimware, which is available from
+ * The FPGA on the board requires firmware, which is available from
* http://www.comedi.org in the comedi_nonfree_firmware tarball.
*
* Configuration options: not applicable, uses PCI auto config
diff --git a/scripts/spelling.txt b/scripts/spelling.txt
index 946caf3bd694..fa79c6d2a5b8 100644
--- a/scripts/spelling.txt
+++ b/scripts/spelling.txt
@@ -428,6 +428,7 @@ feautures||features
fetaure||feature
fetaures||features
fileystem||filesystem
+fimware||firmware
finanize||finalize
findn||find
finilizes||finalizes
--
2.6.3
--
Kees Cook
Chrome OS & Brillo Security
[toc] | [next] | [standalone]
| From | Zhao Lei <zhaolei@cn.fujitsu.com> |
|---|---|
| Date | 2016-04-27 06:10 +0200 |
| Message-ID | <rsoXx-355-15@gated-at.bofh.it> |
| In reply to | #1388348 |
Hi, Kees Cook
* From: Kees Cook [mailto:keescook@chromium.org]
> Sent: Wednesday, April 27, 2016 7:48 AM
> To: Andrew Morton <akpm@linux-foundation.org>
> Cc: Randy Dunlap <rdunlap@infradead.org>; Andy Whitcroft
> <apw@canonical.com>; Joe Perches <joe@perches.com>; Zhao Lei
> <zhaolei@cn.fujitsu.com>; linux-doc@vger.kernel.org;
> linux-kernel@vger.kernel.org
> Subject: [PATCH] scripts/spelling.txt: add "fimware" misspelling
>
> A few instances of "fimware" instead of "firmware" were found. Fix these
> and add it to the spelling.txt file.
>
Better to add this change:
# grep fimware * -R
Documentation/firmware_class/README: - kernel searchs the fimware image with name $FIRMWARE directly
Thanks
Zhaolei
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
> Looks like spelling.txt changes have been going in through -mm?
> ---
> drivers/media/usb/dvb-usb/dib0700_core.c | 2 +-
> drivers/scsi/bfa/bfi.h | 2 +-
> drivers/staging/comedi/drivers/daqboard2000.c | 2 +-
> scripts/spelling.txt | 1 +
> 4 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/usb/dvb-usb/dib0700_core.c
> b/drivers/media/usb/dvb-usb/dib0700_core.c
> index c16f999b9d7c..bf890c3d9cda 100644
> --- a/drivers/media/usb/dvb-usb/dib0700_core.c
> +++ b/drivers/media/usb/dvb-usb/dib0700_core.c
> @@ -517,7 +517,7 @@ int dib0700_download_firmware(struct usb_device
> *udev, const struct firmware *fw
> if (nb_packet_buffer_size < 1)
> nb_packet_buffer_size = 1;
>
> - /* get the fimware version */
> + /* get the firmware version */
> usb_control_msg(udev, usb_rcvctrlpipe(udev, 0),
> REQUEST_GET_VERSION,
> USB_TYPE_VENDOR | USB_DIR_IN, 0, 0,
> diff --git a/drivers/scsi/bfa/bfi.h b/drivers/scsi/bfa/bfi.h
> index 97600dcec649..5f698d038b21 100644
> --- a/drivers/scsi/bfa/bfi.h
> +++ b/drivers/scsi/bfa/bfi.h
> @@ -356,7 +356,7 @@ struct bfi_ioc_image_hdr_s {
> u8 port0_mode; /* device mode for port 0 */
> u8 port1_mode; /* device mode for port 1 */
> u32 exec; /* exec vector */
> - u32 bootenv; /* fimware boot env */
> + u32 bootenv; /* firmware boot env */
> u32 rsvd_b[2];
> struct bfi_ioc_fwver_s fwver;
> u32 md5sum[BFI_IOC_MD5SUM_SZ];
> diff --git a/drivers/staging/comedi/drivers/daqboard2000.c
> b/drivers/staging/comedi/drivers/daqboard2000.c
> index 57ab6680e3ae..a536a15c1d30 100644
> --- a/drivers/staging/comedi/drivers/daqboard2000.c
> +++ b/drivers/staging/comedi/drivers/daqboard2000.c
> @@ -26,7 +26,7 @@
> * Much of the functionality of this driver was determined from reading
> * the source code for the Windows driver.
> *
> - * The FPGA on the board requires fimware, which is available from
> + * The FPGA on the board requires firmware, which is available from
> * http://www.comedi.org in the comedi_nonfree_firmware tarball.
> *
> * Configuration options: not applicable, uses PCI auto config
> diff --git a/scripts/spelling.txt b/scripts/spelling.txt
> index 946caf3bd694..fa79c6d2a5b8 100644
> --- a/scripts/spelling.txt
> +++ b/scripts/spelling.txt
> @@ -428,6 +428,7 @@ feautures||features
> fetaure||feature
> fetaures||features
> fileystem||filesystem
> +fimware||firmware
> finanize||finalize
> findn||find
> finilizes||finalizes
> --
> 2.6.3
>
>
> --
> Kees Cook
> Chrome OS & Brillo Security
[toc] | [prev] | [next] | [standalone]
| From | Kees Cook <keescook@chromium.org> |
|---|---|
| Date | 2016-04-27 18:20 +0200 |
| Message-ID | <rsAlY-41b-19@gated-at.bofh.it> |
| In reply to | #1388657 |
On Tue, Apr 26, 2016 at 9:06 PM, Zhao Lei <zhaolei@cn.fujitsu.com> wrote:
> Hi, Kees Cook
>
> * From: Kees Cook [mailto:keescook@chromium.org]
>> Sent: Wednesday, April 27, 2016 7:48 AM
>> To: Andrew Morton <akpm@linux-foundation.org>
>> Cc: Randy Dunlap <rdunlap@infradead.org>; Andy Whitcroft
>> <apw@canonical.com>; Joe Perches <joe@perches.com>; Zhao Lei
>> <zhaolei@cn.fujitsu.com>; linux-doc@vger.kernel.org;
>> linux-kernel@vger.kernel.org
>> Subject: [PATCH] scripts/spelling.txt: add "fimware" misspelling
>>
>> A few instances of "fimware" instead of "firmware" were found. Fix these
>> and add it to the spelling.txt file.
>>
> Better to add this change:
> # grep fimware * -R
> Documentation/firmware_class/README: - kernel searchs the fimware image with name
$FIRMWARE directly
Yup! That's actually going in via another batch of spelling fixes
(Randy noticing this one is what made me check for more).
Thanks!
-Kees
>
> Thanks
> Zhaolei
>
>> Reported-by: Randy Dunlap <rdunlap@infradead.org>
>> Signed-off-by: Kees Cook <keescook@chromium.org>
>> ---
>> Looks like spelling.txt changes have been going in through -mm?
>> ---
>> drivers/media/usb/dvb-usb/dib0700_core.c | 2 +-
>> drivers/scsi/bfa/bfi.h | 2 +-
>> drivers/staging/comedi/drivers/daqboard2000.c | 2 +-
>> scripts/spelling.txt | 1 +
>> 4 files changed, 4 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/media/usb/dvb-usb/dib0700_core.c
>> b/drivers/media/usb/dvb-usb/dib0700_core.c
>> index c16f999b9d7c..bf890c3d9cda 100644
>> --- a/drivers/media/usb/dvb-usb/dib0700_core.c
>> +++ b/drivers/media/usb/dvb-usb/dib0700_core.c
>> @@ -517,7 +517,7 @@ int dib0700_download_firmware(struct usb_device
>> *udev, const struct firmware *fw
>> if (nb_packet_buffer_size < 1)
>> nb_packet_buffer_size = 1;
>>
>> - /* get the fimware version */
>> + /* get the firmware version */
>> usb_control_msg(udev, usb_rcvctrlpipe(udev, 0),
>> REQUEST_GET_VERSION,
>> USB_TYPE_VENDOR | USB_DIR_IN, 0, 0,
>> diff --git a/drivers/scsi/bfa/bfi.h b/drivers/scsi/bfa/bfi.h
>> index 97600dcec649..5f698d038b21 100644
>> --- a/drivers/scsi/bfa/bfi.h
>> +++ b/drivers/scsi/bfa/bfi.h
>> @@ -356,7 +356,7 @@ struct bfi_ioc_image_hdr_s {
>> u8 port0_mode; /* device mode for port 0 */
>> u8 port1_mode; /* device mode for port 1 */
>> u32 exec; /* exec vector */
>> - u32 bootenv; /* fimware boot env */
>> + u32 bootenv; /* firmware boot env */
>> u32 rsvd_b[2];
>> struct bfi_ioc_fwver_s fwver;
>> u32 md5sum[BFI_IOC_MD5SUM_SZ];
>> diff --git a/drivers/staging/comedi/drivers/daqboard2000.c
>> b/drivers/staging/comedi/drivers/daqboard2000.c
>> index 57ab6680e3ae..a536a15c1d30 100644
>> --- a/drivers/staging/comedi/drivers/daqboard2000.c
>> +++ b/drivers/staging/comedi/drivers/daqboard2000.c
>> @@ -26,7 +26,7 @@
>> * Much of the functionality of this driver was determined from reading
>> * the source code for the Windows driver.
>> *
>> - * The FPGA on the board requires fimware, which is available from
>> + * The FPGA on the board requires firmware, which is available from
>> * http://www.comedi.org in the comedi_nonfree_firmware tarball.
>> *
>> * Configuration options: not applicable, uses PCI auto config
>> diff --git a/scripts/spelling.txt b/scripts/spelling.txt
>> index 946caf3bd694..fa79c6d2a5b8 100644
>> --- a/scripts/spelling.txt
>> +++ b/scripts/spelling.txt
>> @@ -428,6 +428,7 @@ feautures||features
>> fetaure||feature
>> fetaures||features
>> fileystem||filesystem
>> +fimware||firmware
>> finanize||finalize
>> findn||find
>> finilizes||finalizes
>> --
>> 2.6.3
>>
>>
>> --
>> Kees Cook
>> Chrome OS & Brillo Security
>
>
>
>
--
Kees Cook
Chrome OS & Brillo Security
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web