Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1388030 > unrolled thread
| Started by | "Rafael J. Wysocki" <rjw@rjwysocki.net> |
|---|---|
| First post | 2016-04-26 22:40 +0200 |
| Last post | 2016-04-27 23:20 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH] ACPI/device_sysfs: Add sysfs support for _HRV hardware revision "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-04-26 22:40 +0200
Re: [PATCH] ACPI/device_sysfs: Add sysfs support for _HRV hardware revision "Dall, Betty" <betty.dall@hpe.com> - 2016-04-27 18:30 +0200
Re: [PATCH] ACPI/device_sysfs: Add sysfs support for _HRV hardware revision "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-04-27 23:20 +0200
| From | "Rafael J. Wysocki" <rjw@rjwysocki.net> |
|---|---|
| Date | 2016-04-26 22:40 +0200 |
| Subject | Re: [PATCH] ACPI/device_sysfs: Add sysfs support for _HRV hardware revision |
| Message-ID | <rshW2-5I2-3@gated-at.bofh.it> |
On Wednesday, April 13, 2016 08:48:14 AM Betty Dall wrote: > The ACPI _HRV object on the device is used to supply Linux with > the device's hardware revision. This is an optional object. Add > sysfs support for the _HRV object if it exists on the device. > > Signed-off-by: Betty Dall <betty.dall@hpe.com> The patch itself looks OK to me, but why exactly do we need that thing in sysfs? Thanks, Rafael
[toc] | [next] | [standalone]
| From | "Dall, Betty" <betty.dall@hpe.com> |
|---|---|
| Date | 2016-04-27 18:30 +0200 |
| Subject | Re: [PATCH] ACPI/device_sysfs: Add sysfs support for _HRV hardware revision |
| Message-ID | <rsAvE-47z-21@gated-at.bofh.it> |
| In reply to | #1388030 |
On 04/26/2016 02:33 PM, Rafael J. Wysocki wrote: > On Wednesday, April 13, 2016 08:48:14 AM Betty Dall wrote: >> The ACPI _HRV object on the device is used to supply Linux with >> the device's hardware revision. This is an optional object. Add >> sysfs support for the _HRV object if it exists on the device. >> >> Signed-off-by: Betty Dall <betty.dall@hpe.com> > > The patch itself looks OK to me, but why exactly do we need that thing in sysfs? > > Thanks, > Rafael > Hi Rafael, I am working on a platform where non-PCI hardware is changing quickly and users want to check what hardware version they are running on. For example, someone checks out a lab system and wants to see if the device is the latest version or if it needs to be updated - they could cat the sysfs hrv file to find the version. It is most useful for non-PCI devices because lspci can list the hardware version for PCI devices; PCI devices in my testing don't supply _HRV. But, there is not an easy solution for non-PCI devices to get the hardware revision from user space with out this hrv sysfs patch. Originally, I added the sysfs hrv to my specific device driver. On review, I thought it would a good improvement for all devices that have an _HRV. Thanks, Betty
[toc] | [prev] | [next] | [standalone]
| From | "Rafael J. Wysocki" <rjw@rjwysocki.net> |
|---|---|
| Date | 2016-04-27 23:20 +0200 |
| Message-ID | <rsF2i-8fU-19@gated-at.bofh.it> |
| In reply to | #1389326 |
On Wednesday, April 27, 2016 04:15:30 PM Dall, Betty wrote: > On 04/26/2016 02:33 PM, Rafael J. Wysocki wrote: > > On Wednesday, April 13, 2016 08:48:14 AM Betty Dall wrote: > >> The ACPI _HRV object on the device is used to supply Linux with > >> the device's hardware revision. This is an optional object. Add > >> sysfs support for the _HRV object if it exists on the device. > >> > >> Signed-off-by: Betty Dall <betty.dall@hpe.com> > > > > The patch itself looks OK to me, but why exactly do we need that thing in sysfs? > > > > Thanks, > > Rafael > > > Hi Rafael, > > I am working on a platform where non-PCI hardware is changing quickly > and users want to check what hardware version they are running on. For > example, someone checks out a lab system and wants to see if the device > is the latest version or if it needs to be updated - they could cat the > sysfs hrv file to find the version. It is most useful for non-PCI > devices because lspci can list the hardware version for PCI devices; PCI > devices in my testing don't supply _HRV. But, there is not an easy > solution for non-PCI devices to get the hardware revision from user > space with out this hrv sysfs patch. > > Originally, I added the sysfs hrv to my specific device driver. On > review, I thought it would a good improvement for all devices that have > an _HRV. OK Can you please add a motivation paragraph to the patch changelog then? Thanks, Rafael
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web