Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1387639 > unrolled thread

Re: [PATCH 0/3] Net driver bugs fix and code style

Started byDavid Miller <davem@davemloft.net>
First post2016-04-26 18:00 +0200
Last post2016-04-26 20:00 +0200
Articles 4 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH 0/3] Net driver bugs fix and code style David Miller <davem@davemloft.net> - 2016-04-26 18:00 +0200
    Re: [PATCH 0/3] Net driver bugs fix and code style Noam Camus <noamca@mellanox.com> - 2016-04-26 19:30 +0200
      Re: [PATCH 0/3] Net driver bugs fix and code style David Miller <davem@davemloft.net> - 2016-04-26 20:00 +0200
      Re: [PATCH 0/3] Net driver bugs fix and code style David Miller <davem@davemloft.net> - 2016-04-26 20:00 +0200

#1387639 — Re: [PATCH 0/3] Net driver bugs fix and code style

FromDavid Miller <davem@davemloft.net>
Date2016-04-26 18:00 +0200
SubjectRe: [PATCH 0/3] Net driver bugs fix and code style
Message-ID<rsdz4-1JO-5@gated-at.bofh.it>
It is not appropriate to mix coding style fixes with bug fixes.

Bug fixes must be targetted at the 'net' tree, and anything else
must be targetted at the 'net-next' tree.

[toc] | [next] | [standalone]


#1387752

FromNoam Camus <noamca@mellanox.com>
Date2016-04-26 19:30 +0200
Message-ID<rseYb-34w-45@gated-at.bofh.it>
In reply to#1387639
>From: David Miller <davem@davemloft.net>
>Sent: Tuesday, April 26, 2016 6:57 PM

>It is not appropriate to mix coding style fixes with bug fixes.
The code style in patch number 1 is actually prevents code duplication that stem from bug fix at patch number 3. 

>Bug fixes must be targetted at the 'net' tree, and anything else
>must be targetted at the 'net-next' tree.
Should we handle bugs fix first (more urgent then code style) and once it will be accepted and applied to net-next proceed with the code style patch?

Noam

[toc] | [prev] | [next] | [standalone]


#1387771

FromDavid Miller <davem@davemloft.net>
Date2016-04-26 20:00 +0200
Message-ID<rsfrc-3gJ-3@gated-at.bofh.it>
In reply to#1387752
From: Noam Camus <noamca@mellanox.com>
Date: Tue, 26 Apr 2016 17:23:26 +0000

>>From: David Miller <davem@davemloft.net>
>>Sent: Tuesday, April 26, 2016 6:57 PM
>>
>>Bug fixes must be targetted at the 'net' tree, and anything else
>>must be targetted at the 'net-next' tree.
> Should we handle bugs fix first (more urgent then code style) and once it will be accepted and applied to net-next proceed with the code style patch?

That's exactly what I am telling you, yes.

[toc] | [prev] | [next] | [standalone]


#1387774

FromDavid Miller <davem@davemloft.net>
Date2016-04-26 20:00 +0200
Message-ID<rsfrc-3gJ-15@gated-at.bofh.it>
In reply to#1387752
BTW, you should also CC: the correct mailing lists for networking patch
submissions.

You failed to CC: netdev@vger.kernel.org

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web