Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1386853 > unrolled thread

[PATCH v3 1/2] ASoC: codecs: add TA5720 digital amplifier DT bindings

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH v3 1/2] ASoC: codecs: add TA5720 digital amplifier DT bindings Andreas Dannenberg <dannenberg@ti.com> - 2016-04-25 22:20 +0200
    Re: [PATCH v3 1/2] ASoC: codecs: add TA5720 digital amplifier DT  bindings Mark Brown <broonie@kernel.org> - 2016-04-26 17:40 +0200
      Re: [PATCH v3 1/2] ASoC: codecs: add TA5720 digital amplifier DT  bindings Andreas Dannenberg <dannenberg@ti.com> - 2016-04-26 18:20 +0200
        Re: [PATCH v3 1/2] ASoC: codecs: add TA5720 digital amplifier DT  bindings Mark Brown <broonie@kernel.org> - 2016-04-26 19:00 +0200
          Re: [PATCH v3 1/2] ASoC: codecs: add TA5720 digital amplifier DT  bindings Andreas Dannenberg <dannenberg@ti.com> - 2016-04-26 19:10 +0200

#1386853 — [PATCH v3 1/2] ASoC: codecs: add TA5720 digital amplifier DT bindings

The Texas Instruments TAS5720L/M device is a high-efficiency mono
Class-D audio power amplifier optimized for high transient power
capability to use the dynamic power headroom of small loudspeakers.
Its digital time division multiplexed (TDM) interface enables up to
16 devices to share the same bus.

Signed-off-by: Andreas Dannenberg <dannenberg@ti.com>
---
 .../devicetree/bindings/sound/tas5720.txt          | 26 ++++++++++++++++++++++
 1 file changed, 26 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/sound/tas5720.txt

diff --git a/Documentation/devicetree/bindings/sound/tas5720.txt b/Documentation/devicetree/bindings/sound/tas5720.txt
new file mode 100644
index 0000000..439451e
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/tas5720.txt
@@ -0,0 +1,26 @@
+Texas Instruments TAS5720 Mono Audio amplifier
+
+The TAS5720 serial control bus communicates through the I2C protocol only. The
+serial bus is also used for periodic codec fault checking/reporting during
+audio playback. For more product information please see the links below:
+
+http://www.ti.com/product/TAS5720L
+http://www.ti.com/product/TAS5720M
+
+Required properties:
+
+- compatible : "ti,tas5720"
+- reg : I2C slave address
+
+Optional properties:
+
+- dvdd-supply : phandle to a 3.3-V supply for the digital circuitry
+- pvdd-supply : phandle to a supply used for the Class-D amp and the analog
+
+Example:
+
+tas5720: tas5720@6c {
+	status = "okay";
+	compatible = "ti,tas5720";
+	reg = <0x6c>;
+};
-- 
2.6.4

[toc] | [next] | [standalone]

#1387625 — Re: [PATCH v3 1/2] ASoC: codecs: add TA5720 digital amplifier DT bindings

[Multipart message — attachments visible in raw view] — view raw

On Mon, Apr 25, 2016 at 03:17:35PM -0500, Andreas Dannenberg wrote:

> +Optional properties:
> +
> +- dvdd-supply : phandle to a 3.3-V supply for the digital circuitry
> +- pvdd-supply : phandle to a supply used for the Class-D amp and the analog

This suggests that the device doesn't need power...  

[toc] | [prev] | [next] | [standalone]

#1387668 — Re: [PATCH v3 1/2] ASoC: codecs: add TA5720 digital amplifier DT bindings

On Tue, Apr 26, 2016 at 04:37:07PM +0100, Mark Brown wrote:
> On Mon, Apr 25, 2016 at 03:17:35PM -0500, Andreas Dannenberg wrote:
> 
> > +Optional properties:
> > +
> > +- dvdd-supply : phandle to a 3.3-V supply for the digital circuitry
> > +- pvdd-supply : phandle to a supply used for the Class-D amp and the analog
> 
> This suggests that the device doesn't need power...  

Hi Mark,
no power, now that would be nice! :)  What this was supposed to mean is
that the properties are optional, the power of course is not. The DT has
really no control over how I wire up my HW and I'd argue most folks just
permanently power the TAS5720 since the shutdown current is just a few
uAs IIRC in order to save some BOM cost. But I suppose the DT description
is such that the Kernel can more intelligently handle things based on
what the driver is doing if somebody choses and implements additional
regulator/power switch HW. Or did I misunderstand your point?

Thanks,
Andreas

[toc] | [prev] | [next] | [standalone]

#1387719 — Re: [PATCH v3 1/2] ASoC: codecs: add TA5720 digital amplifier DT bindings

[Multipart message — attachments visible in raw view] — view raw

On Tue, Apr 26, 2016 at 11:14:25AM -0500, Andreas Dannenberg wrote:
> On Tue, Apr 26, 2016 at 04:37:07PM +0100, Mark Brown wrote:
> > On Mon, Apr 25, 2016 at 03:17:35PM -0500, Andreas Dannenberg wrote:

> > > +Optional properties:

> > > +- dvdd-supply : phandle to a 3.3-V supply for the digital circuitry
> > > +- pvdd-supply : phandle to a supply used for the Class-D amp and the analog

> > This suggests that the device doesn't need power...  

> no power, now that would be nice! :)  What this was supposed to mean is
> that the properties are optional, the power of course is not. The DT has

They should only be optional if they may really be missing.  We may
attempt to be liberal in the DTs we accept but we should not encourage
sloppily written DTs.

> really no control over how I wire up my HW and I'd argue most folks just
> permanently power the TAS5720 since the shutdown current is just a few
> uAs IIRC in order to save some BOM cost. But I suppose the DT description
> is such that the Kernel can more intelligently handle things based on
> what the driver is doing if somebody choses and implements additional
> regulator/power switch HW. Or did I misunderstand your point?

It doesn't really matter if a given system ends up controlling things
actively, we still want to be consistent in describing them since it is
less error prone when it does become relevant.

[toc] | [prev] | [next] | [standalone]

#1387724 — Re: [PATCH v3 1/2] ASoC: codecs: add TA5720 digital amplifier DT bindings

On Tue, Apr 26, 2016 at 05:50:06PM +0100, Mark Brown wrote:
> On Tue, Apr 26, 2016 at 11:14:25AM -0500, Andreas Dannenberg wrote:
> > On Tue, Apr 26, 2016 at 04:37:07PM +0100, Mark Brown wrote:
> > > On Mon, Apr 25, 2016 at 03:17:35PM -0500, Andreas Dannenberg wrote:
> 
> > > > +Optional properties:
> 
> > > > +- dvdd-supply : phandle to a 3.3-V supply for the digital circuitry
> > > > +- pvdd-supply : phandle to a supply used for the Class-D amp and the analog
> 
> > > This suggests that the device doesn't need power...  
> 
> > no power, now that would be nice! :)  What this was supposed to mean is
> > that the properties are optional, the power of course is not. The DT has
> 
> They should only be optional if they may really be missing.  We may
> attempt to be liberal in the DTs we accept but we should not encourage
> sloppily written DTs.

Thanks for the guidance and the background. Will move them to "required"
but I'll wait a few more days before re-submitting in case there is
additional feedback on the patch series.

Regards,
Andreas

> 
> > really no control over how I wire up my HW and I'd argue most folks just
> > permanently power the TAS5720 since the shutdown current is just a few
> > uAs IIRC in order to save some BOM cost. But I suppose the DT description
> > is such that the Kernel can more intelligently handle things based on
> > what the driver is doing if somebody choses and implements additional
> > regulator/power switch HW. Or did I misunderstand your point?
> 
> It doesn't really matter if a given system ends up controlling things
> actively, we still want to be consistent in describing them since it is
> less error prone when it does become relevant.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web