Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1390476 > unrolled thread

[PATCH] ARM: dts: exynos: Add MFC memory banks for Peach boards

Started byJavier Martinez Canillas <javier@osg.samsung.com>
First post2016-04-28 21:30 +0200
Last post2016-05-06 16:20 +0200
Articles 5 — 2 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] ARM: dts: exynos: Add MFC memory banks for Peach boards Javier Martinez Canillas <javier@osg.samsung.com> - 2016-04-28 21:30 +0200
    Re: [PATCH] ARM: dts: exynos: Add MFC memory banks for Peach boards Javier Martinez Canillas <javier@osg.samsung.com> - 2016-05-06 15:50 +0200
      Re: [PATCH] ARM: dts: exynos: Add MFC memory banks for Peach boards Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-05-06 16:00 +0200
        Re: [PATCH] ARM: dts: exynos: Add MFC memory banks for Peach boards Javier Martinez Canillas <javier@osg.samsung.com> - 2016-05-06 16:20 +0200
          Re: [PATCH] ARM: dts: exynos: Add MFC memory banks for Peach boards Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-05-06 16:20 +0200

#1390476 — [PATCH] ARM: dts: exynos: Add MFC memory banks for Peach boards

FromJavier Martinez Canillas <javier@osg.samsung.com>
Date2016-04-28 21:30 +0200
Subject[PATCH] ARM: dts: exynos: Add MFC memory banks for Peach boards
Message-ID<rsZNo-Z5-13@gated-at.bofh.it>
The MFC nodes with the memory regions reserved for memory allocations
are missing in the Exynos5420 Peach Pit and Exynos5800 Peach Pi DTS.

This causes the s5p-mfc driver probe to fail with the following error:

[    4.140647] s5p_mfc_alloc_memdevs:1072: Failed to declare coherent memory for MFC device
[    4.216163] s5p-mfc: probe of 11000000.codec failed with error -12

Add the missing nodes so the driver probes and the {en,de}coder video
nodes are registered correctly:

[    4.096277] s5p-mfc 11000000.codec: decoder registered as /dev/video4
[    4.102282] s5p-mfc 11000000.codec: encoder registered as /dev/video5

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>

---

 arch/arm/boot/dts/exynos5420-peach-pit.dts | 5 +++++
 arch/arm/boot/dts/exynos5800-peach-pi.dts  | 5 +++++
 2 files changed, 10 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts
index b644858231b6..f9d2e4f1a0e0 100644
--- a/arch/arm/boot/dts/exynos5420-peach-pit.dts
+++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
@@ -694,6 +694,11 @@
 	status = "okay";
 };
 
+&mfc {
+	samsung,mfc-r = <0x43000000 0x800000>;
+	samsung,mfc-l = <0x51000000 0x800000>;
+};
+
 &mmc_0 {
 	status = "okay";
 	num-slots = <1>;
diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts
index 6ba9aec15485..62ceb89e073f 100644
--- a/arch/arm/boot/dts/exynos5800-peach-pi.dts
+++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts
@@ -669,6 +669,11 @@
 	status = "okay";
 };
 
+&mfc {
+	samsung,mfc-r = <0x43000000 0x800000>;
+	samsung,mfc-l = <0x51000000 0x800000>;
+};
+
 &mmc_0 {
 	status = "okay";
 	num-slots = <1>;
-- 
2.5.5

[toc] | [next] | [standalone]

#1395872

FromJavier Martinez Canillas <javier@osg.samsung.com>
Date2016-05-06 15:50 +0200
Message-ID<rvOiK-6dU-19@gated-at.bofh.it>
In reply to#1390476
Hello Krzysztof,

On 04/28/2016 03:21 PM, Javier Martinez Canillas wrote:
> The MFC nodes with the memory regions reserved for memory allocations
> are missing in the Exynos5420 Peach Pit and Exynos5800 Peach Pi DTS.
> 
> This causes the s5p-mfc driver probe to fail with the following error:
> 
> [    4.140647] s5p_mfc_alloc_memdevs:1072: Failed to declare coherent memory for MFC device
> [    4.216163] s5p-mfc: probe of 11000000.codec failed with error -12
> 
> Add the missing nodes so the driver probes and the {en,de}coder video
> nodes are registered correctly:
> 
> [    4.096277] s5p-mfc 11000000.codec: decoder registered as /dev/video4
> [    4.102282] s5p-mfc 11000000.codec: encoder registered as /dev/video5
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> ---
> 
>  arch/arm/boot/dts/exynos5420-peach-pit.dts | 5 +++++
>  arch/arm/boot/dts/exynos5800-peach-pi.dts  | 5 +++++
>  2 files changed, 10 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts
> index b644858231b6..f9d2e4f1a0e0 100644
> --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts
> +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
> @@ -694,6 +694,11 @@
>  	status = "okay";
>  };
>  
> +&mfc {
> +	samsung,mfc-r = <0x43000000 0x800000>;
> +	samsung,mfc-l = <0x51000000 0x800000>;
> +};
> +
>  &mmc_0 {
>  	status = "okay";
>  	num-slots = <1>;
> diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts
> index 6ba9aec15485..62ceb89e073f 100644
> --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts
> +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts
> @@ -669,6 +669,11 @@
>  	status = "okay";
>  };
>  
> +&mfc {
> +	samsung,mfc-r = <0x43000000 0x800000>;
> +	samsung,mfc-l = <0x51000000 0x800000>;
> +};
> +
>  &mmc_0 {
>  	status = "okay";
>  	num-slots = <1>;
> 

Any comments about this patch?

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

[toc] | [prev] | [next] | [standalone]

#1395877

FromKrzysztof Kozlowski <k.kozlowski@samsung.com>
Date2016-05-06 16:00 +0200
Message-ID<rvOsq-6i2-19@gated-at.bofh.it>
In reply to#1395872
On 05/06/2016 03:44 PM, Javier Martinez Canillas wrote:
> Hello Krzysztof,
> 
> On 04/28/2016 03:21 PM, Javier Martinez Canillas wrote:
>> The MFC nodes with the memory regions reserved for memory allocations
>> are missing in the Exynos5420 Peach Pit and Exynos5800 Peach Pi DTS.
>>
>> This causes the s5p-mfc driver probe to fail with the following error:
>>
>> [    4.140647] s5p_mfc_alloc_memdevs:1072: Failed to declare coherent memory for MFC device
>> [    4.216163] s5p-mfc: probe of 11000000.codec failed with error -12
>>
>> Add the missing nodes so the driver probes and the {en,de}coder video
>> nodes are registered correctly:
>>
>> [    4.096277] s5p-mfc 11000000.codec: decoder registered as /dev/video4
>> [    4.102282] s5p-mfc 11000000.codec: encoder registered as /dev/video5
>>
>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>>
>> ---
>>
>>  arch/arm/boot/dts/exynos5420-peach-pit.dts | 5 +++++
>>  arch/arm/boot/dts/exynos5800-peach-pi.dts  | 5 +++++
>>  2 files changed, 10 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts
>> index b644858231b6..f9d2e4f1a0e0 100644
>> --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts
>> +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
>> @@ -694,6 +694,11 @@
>>  	status = "okay";
>>  };
>>  
>> +&mfc {
>> +	samsung,mfc-r = <0x43000000 0x800000>;
>> +	samsung,mfc-l = <0x51000000 0x800000>;
>> +};
>> +
>>  &mmc_0 {
>>  	status = "okay";
>>  	num-slots = <1>;
>> diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts
>> index 6ba9aec15485..62ceb89e073f 100644
>> --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts
>> +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts
>> @@ -669,6 +669,11 @@
>>  	status = "okay";
>>  };
>>  
>> +&mfc {
>> +	samsung,mfc-r = <0x43000000 0x800000>;
>> +	samsung,mfc-l = <0x51000000 0x800000>;
>> +};
>> +
>>  &mmc_0 {
>>  	status = "okay";
>>  	num-slots = <1>;
>>
> 
> Any comments about this patch?

What is up with the rush now (a week for ping)? As I understand, this
was broken for very long time on these boards (since adding DT support
in 2012?).

Best regards,
Krzysztof

[toc] | [prev] | [next] | [standalone]

#1395888

FromJavier Martinez Canillas <javier@osg.samsung.com>
Date2016-05-06 16:20 +0200
Message-ID<rvOLM-6M0-13@gated-at.bofh.it>
In reply to#1395877
Hello Krzysztof,

On 05/06/2016 09:58 AM, Krzysztof Kozlowski wrote:
> On 05/06/2016 03:44 PM, Javier Martinez Canillas wrote:
>> Hello Krzysztof,
>>
>> On 04/28/2016 03:21 PM, Javier Martinez Canillas wrote:
>>> The MFC nodes with the memory regions reserved for memory allocations
>>> are missing in the Exynos5420 Peach Pit and Exynos5800 Peach Pi DTS.
>>>
>>> This causes the s5p-mfc driver probe to fail with the following error:
>>>
>>> [    4.140647] s5p_mfc_alloc_memdevs:1072: Failed to declare coherent memory for MFC device
>>> [    4.216163] s5p-mfc: probe of 11000000.codec failed with error -12
>>>
>>> Add the missing nodes so the driver probes and the {en,de}coder video
>>> nodes are registered correctly:
>>>
>>> [    4.096277] s5p-mfc 11000000.codec: decoder registered as /dev/video4
>>> [    4.102282] s5p-mfc 11000000.codec: encoder registered as /dev/video5
>>>
>>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>>>
>>> ---
>>>
>>>  arch/arm/boot/dts/exynos5420-peach-pit.dts | 5 +++++
>>>  arch/arm/boot/dts/exynos5800-peach-pi.dts  | 5 +++++
>>>  2 files changed, 10 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts
>>> index b644858231b6..f9d2e4f1a0e0 100644
>>> --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts
>>> +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
>>> @@ -694,6 +694,11 @@
>>>  	status = "okay";
>>>  };
>>>  
>>> +&mfc {
>>> +	samsung,mfc-r = <0x43000000 0x800000>;
>>> +	samsung,mfc-l = <0x51000000 0x800000>;
>>> +};
>>> +
>>>  &mmc_0 {
>>>  	status = "okay";
>>>  	num-slots = <1>;
>>> diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts
>>> index 6ba9aec15485..62ceb89e073f 100644
>>> --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts
>>> +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts
>>> @@ -669,6 +669,11 @@
>>>  	status = "okay";
>>>  };
>>>  
>>> +&mfc {
>>> +	samsung,mfc-r = <0x43000000 0x800000>;
>>> +	samsung,mfc-l = <0x51000000 0x800000>;
>>> +};
>>> +
>>>  &mmc_0 {
>>>  	status = "okay";
>>>  	num-slots = <1>;
>>>
>>
>> Any comments about this patch?
> 
> What is up with the rush now (a week for ping)? As I understand, this

Sorry about that... I should had waited for more time for the ping indeed.
I just thought the patch was trivial and you usually answer within days.

> was broken for very long time on these boards (since adding DT support
> in 2012?).
> 

Yes, that's correct. And in fact even the s5p-mfc driver is currently
not working in mainline. But I posted some fixes and will post more
patches from other people today to get it working. So I thought that
would be nice to have this in since one of my test machines is a Peach.

> Best regards,
> Krzysztof
>

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

[toc] | [prev] | [next] | [standalone]

#1395891

FromKrzysztof Kozlowski <k.kozlowski@samsung.com>
Date2016-05-06 16:20 +0200
Message-ID<rvOLM-6M0-21@gated-at.bofh.it>
In reply to#1395888
On 05/06/2016 04:12 PM, Javier Martinez Canillas wrote:
> Hello Krzysztof,
> 
> On 05/06/2016 09:58 AM, Krzysztof Kozlowski wrote:
>> On 05/06/2016 03:44 PM, Javier Martinez Canillas wrote:
>>> Hello Krzysztof,
>>>
>>> On 04/28/2016 03:21 PM, Javier Martinez Canillas wrote:
>>>> The MFC nodes with the memory regions reserved for memory allocations
>>>> are missing in the Exynos5420 Peach Pit and Exynos5800 Peach Pi DTS.
>>>>
>>>> This causes the s5p-mfc driver probe to fail with the following error:
>>>>
>>>> [    4.140647] s5p_mfc_alloc_memdevs:1072: Failed to declare coherent memory for MFC device
>>>> [    4.216163] s5p-mfc: probe of 11000000.codec failed with error -12
>>>>
>>>> Add the missing nodes so the driver probes and the {en,de}coder video
>>>> nodes are registered correctly:
>>>>
>>>> [    4.096277] s5p-mfc 11000000.codec: decoder registered as /dev/video4
>>>> [    4.102282] s5p-mfc 11000000.codec: encoder registered as /dev/video5
>>>>
>>>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>>>>
>>>> ---
>>>>
>>>>  arch/arm/boot/dts/exynos5420-peach-pit.dts | 5 +++++
>>>>  arch/arm/boot/dts/exynos5800-peach-pi.dts  | 5 +++++
>>>>  2 files changed, 10 insertions(+)
>>>>
>>>> diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts
>>>> index b644858231b6..f9d2e4f1a0e0 100644
>>>> --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts
>>>> +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
>>>> @@ -694,6 +694,11 @@
>>>>  	status = "okay";
>>>>  };
>>>>  
>>>> +&mfc {
>>>> +	samsung,mfc-r = <0x43000000 0x800000>;
>>>> +	samsung,mfc-l = <0x51000000 0x800000>;
>>>> +};
>>>> +
>>>>  &mmc_0 {
>>>>  	status = "okay";
>>>>  	num-slots = <1>;
>>>> diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts
>>>> index 6ba9aec15485..62ceb89e073f 100644
>>>> --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts
>>>> +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts
>>>> @@ -669,6 +669,11 @@
>>>>  	status = "okay";
>>>>  };
>>>>  
>>>> +&mfc {
>>>> +	samsung,mfc-r = <0x43000000 0x800000>;
>>>> +	samsung,mfc-l = <0x51000000 0x800000>;
>>>> +};
>>>> +
>>>>  &mmc_0 {
>>>>  	status = "okay";
>>>>  	num-slots = <1>;
>>>>
>>>
>>> Any comments about this patch?
>>
>> What is up with the rush now (a week for ping)? As I understand, this
> 
> Sorry about that... I should had waited for more time for the ping indeed.
> I just thought the patch was trivial and you usually answer within days.
> 
>> was broken for very long time on these boards (since adding DT support
>> in 2012?).
>>
> 
> Yes, that's correct. And in fact even the s5p-mfc driver is currently
> not working in mainline. But I posted some fixes and will post more
> patches from other people today to get it working. So I thought that
> would be nice to have this in since one of my test machines is a Peach.

Okay, no problem. I have few more not-so-critical fixes. Queued for
earliest possible release.

Best regards,
Krzysztof

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web