Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1389399 > unrolled thread

[PATCH 1/3] lightnvm: do not free unused metadata on rrpc

Started by"Javier González" <jg@lightnvm.io>
First post2016-04-27 19:30 +0200
Last post2016-04-27 21:00 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH 1/3] lightnvm: do not free unused metadata on rrpc "Javier González" <jg@lightnvm.io> - 2016-04-27 19:30 +0200
    Re: [PATCH 1/3] lightnvm: do not free unused metadata on rrpc Matias Bjørling <m@bjorling.me> - 2016-04-27 21:00 +0200

#1389399 — [PATCH 1/3] lightnvm: do not free unused metadata on rrpc

From"Javier González" <jg@lightnvm.io>
Date2016-04-27 19:30 +0200
Subject[PATCH 1/3] lightnvm: do not free unused metadata on rrpc
Message-ID<rsBrI-4Yl-3@gated-at.bofh.it>
rrpc does not save any metadata on a given request. Thus, do not attempt
to free the metadata dma region.

Signed-off-by: Javier González <javier@cnexlabs.com>
---
 drivers/lightnvm/rrpc.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/lightnvm/rrpc.c b/drivers/lightnvm/rrpc.c
index c7fef71..ffcfee6 100644
--- a/drivers/lightnvm/rrpc.c
+++ b/drivers/lightnvm/rrpc.c
@@ -711,8 +711,6 @@ static void rrpc_end_io(struct nvm_rq *rqd)
 
 	if (npages > 1)
 		nvm_dev_dma_free(rrpc->dev, rqd->ppa_list, rqd->dma_ppa_list);
-	if (rqd->metadata)
-		nvm_dev_dma_free(rrpc->dev, rqd->metadata, rqd->dma_metadata);
 
 	mempool_free(rqd, rrpc->rq_pool);
 }
-- 
2.5.0

[toc] | [next] | [standalone]


#1389491

FromMatias Bjørling <m@bjorling.me>
Date2016-04-27 21:00 +0200
Message-ID<rsCQP-66m-23@gated-at.bofh.it>
In reply to#1389399
On 04/27/2016 07:28 PM, Javier González wrote:
> rrpc does not save any metadata on a given request. Thus, do not attempt
> to free the metadata dma region.
>
> Signed-off-by: Javier González <javier@cnexlabs.com>
> ---
>   drivers/lightnvm/rrpc.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/drivers/lightnvm/rrpc.c b/drivers/lightnvm/rrpc.c
> index c7fef71..ffcfee6 100644
> --- a/drivers/lightnvm/rrpc.c
> +++ b/drivers/lightnvm/rrpc.c
> @@ -711,8 +711,6 @@ static void rrpc_end_io(struct nvm_rq *rqd)
>
>   	if (npages > 1)
>   		nvm_dev_dma_free(rrpc->dev, rqd->ppa_list, rqd->dma_ppa_list);
> -	if (rqd->metadata)
> -		nvm_dev_dma_free(rrpc->dev, rqd->metadata, rqd->dma_metadata);
>
>   	mempool_free(rqd, rrpc->rq_pool);
>   }
>

Thanks. Applied for 4.7.

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web