Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1386978 > unrolled thread

[PATCH] soc: brcmstb: select SOC_BUS

Back to article view | Back to linux.kernel

Contents

  [PATCH] soc: brcmstb: select SOC_BUS Arnd Bergmann <arnd@arndb.de> - 2016-04-26 01:00 +0200
    Re: [PATCH] soc: brcmstb: select SOC_BUS Florian Fainelli <f.fainelli@gmail.com> - 2016-04-26 01:10 +0200

#1386978 — [PATCH] soc: brcmstb: select SOC_BUS

The newly added code for the SoC bus fails to link if the
bus is not built:

drivers/soc/built-in.o: In function `brcmstb_soc_device_init':
:(.init.text+0x110): undefined reference to `soc_device_register'

This adds a 'select' statement to avoid the error.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/soc/brcmstb/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/soc/brcmstb/Kconfig b/drivers/soc/brcmstb/Kconfig
index 39cab3b..7fec3b4 100644
--- a/drivers/soc/brcmstb/Kconfig
+++ b/drivers/soc/brcmstb/Kconfig
@@ -1,6 +1,7 @@
 menuconfig SOC_BRCMSTB
 	bool "Broadcom STB SoC drivers"
 	depends on ARM
+	select SOC_BUS
 	help
 	  Enables drivers for the Broadcom Set-Top Box (STB) series of chips.
 	  This option alone enables only some support code, while the drivers
-- 
2.7.0

[toc] | [next] | [standalone]

#1386980

On 25/04/16 15:55, Arnd Bergmann wrote:
> The newly added code for the SoC bus fails to link if the
> bus is not built:
> 
> drivers/soc/built-in.o: In function `brcmstb_soc_device_init':
> :(.init.text+0x110): undefined reference to `soc_device_register'
> 
> This adds a 'select' statement to avoid the error.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Fixes: cef4bafcea2c ("soc: brcmstb: add SoC driver to brcmstb")

Acked-by: Florian Fainelli <f.fainelli@gmail.com>

Thanks!

> ---
>  drivers/soc/brcmstb/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/soc/brcmstb/Kconfig b/drivers/soc/brcmstb/Kconfig
> index 39cab3b..7fec3b4 100644
> --- a/drivers/soc/brcmstb/Kconfig
> +++ b/drivers/soc/brcmstb/Kconfig
> @@ -1,6 +1,7 @@
>  menuconfig SOC_BRCMSTB
>  	bool "Broadcom STB SoC drivers"
>  	depends on ARM
> +	select SOC_BUS
>  	help
>  	  Enables drivers for the Broadcom Set-Top Box (STB) series of chips.
>  	  This option alone enables only some support code, while the drivers
> 


-- 
Florian

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web