Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1385603 > unrolled thread

[GIT PULL] move ARM LCD display driver to auxdisplay

Back to article view | Back to linux.kernel

Contents

  [GIT PULL] move ARM LCD display driver to auxdisplay Linus Walleij <linus.walleij@linaro.org> - 2016-04-23 11:50 +0200
    Re: [GIT PULL] move ARM LCD display driver to auxdisplay Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-04-25 14:00 +0200
      Re: [GIT PULL] move ARM LCD display driver to auxdisplay Arnd Bergmann <arnd@arndb.de> - 2016-04-26 00:20 +0200
      Re: [GIT PULL] move ARM LCD display driver to auxdisplay Linus Walleij <linus.walleij@linaro.org> - 2016-04-26 12:50 +0200
        Re: [GIT PULL] move ARM LCD display driver to auxdisplay Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-04-28 11:30 +0200

#1385603 — [GIT PULL] move ARM LCD display driver to auxdisplay

Hi ARM SoC guys,

these two patches move the ARM character LCD driver from
misc drivers to the auxdisplay subsystem where it belongs and
updates the defconfig for the RealView accordingly.

Please pull it into some cleanup branch in the ARM SoC
tree.

I tried to get some ACK from the auxdisplay maintainer but no
reaction.

Yours,
Linus Walleij

The following changes since commit bf16200689118d19de1b8d2a3c314fc21f5dc7bb:

  Linux 4.6-rc3 (2016-04-10 17:58:30 -0700)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-integrator.git
tags/move-auxdisplay

for you to fetch changes up to 700ce70081d4f5ac7bc4fbfba209072152f96c89:

  ARM: realview: update defconfig to match new subsystem (2016-04-23
11:38:25 +0200)

----------------------------------------------------------------
This moves the ARM RealView auxilary display out of
the misc drivers and into the new auxdisplay subsystem.

----------------------------------------------------------------
Linus Walleij (2):
      auxdisplay: move the ARM LCD driver into auxdisplay
      ARM: realview: update defconfig to match new subsystem

 arch/arm/configs/realview_defconfig        |  3 ++-
 drivers/auxdisplay/Kconfig                 | 10 ++++++++++
 drivers/auxdisplay/Makefile                |  1 +
 drivers/{misc => auxdisplay}/arm-charlcd.c |  0
 drivers/misc/Kconfig                       | 10 ----------
 drivers/misc/Makefile                      |  1 -
 6 files changed, 13 insertions(+), 12 deletions(-)
 rename drivers/{misc => auxdisplay}/arm-charlcd.c (100%)

[toc] | [next] | [standalone]

#1386310

[Multipart message — attachments visible in raw view] — view raw

Hi,

On Sat, Apr 23, 2016 at 11:43:58AM +0200, Linus Walleij wrote:
> Hi ARM SoC guys,
> 
> these two patches move the ARM character LCD driver from
> misc drivers to the auxdisplay subsystem where it belongs and
> updates the defconfig for the RealView accordingly.
> 
> Please pull it into some cleanup branch in the ARM SoC
> tree.
> 
> I tried to get some ACK from the auxdisplay maintainer but no
> reaction.

Auxdisplay is not a new framework, but rather a very old one.

It got introduced in 2.6.21, and only received a couple of drivers
since.

It seems to be quite redundant with fbdev deferred_io, which itself is
almost deprecated these days.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[toc] | [prev] | [next] | [standalone]

#1386955

On Monday 25 April 2016 13:57:58 Maxime Ripard wrote:
> Hi,
> 
> On Sat, Apr 23, 2016 at 11:43:58AM +0200, Linus Walleij wrote:
> > Hi ARM SoC guys,
> > 
> > these two patches move the ARM character LCD driver from
> > misc drivers to the auxdisplay subsystem where it belongs and
> > updates the defconfig for the RealView accordingly.
> > 
> > Please pull it into some cleanup branch in the ARM SoC
> > tree.
> > 
> > I tried to get some ACK from the auxdisplay maintainer but no
> > reaction.
> 
> Auxdisplay is not a new framework, but rather a very old one.
> 
> It got introduced in 2.6.21, and only received a couple of drivers
> since.
> 
> It seems to be quite redundant with fbdev deferred_io, which itself is
> almost deprecated these days.

I'm holding off on this pull request for now then.

I'd certainly like to see the driver get moved out of drivers/misc,
let me know once there has been an agreement of where it should go.

	Arnd

[toc] | [prev] | [next] | [standalone]

#1387354

On Mon, Apr 25, 2016 at 1:57 PM, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
> On Sat, Apr 23, 2016 at 11:43:58AM +0200, Linus Walleij wrote:
>> Hi ARM SoC guys,
>>
>> these two patches move the ARM character LCD driver from
>> misc drivers to the auxdisplay subsystem where it belongs and
>> updates the defconfig for the RealView accordingly.
>>
>> Please pull it into some cleanup branch in the ARM SoC
>> tree.
>>
>> I tried to get some ACK from the auxdisplay maintainer but no
>> reaction.
>
> Auxdisplay is not a new framework, but rather a very old one.
>
> It got introduced in 2.6.21, and only received a couple of drivers
> since.

Small problem for me, but Robin is submitting a brand new
auxdisplay driver:
http://marc.info/?l=linux-kernel&m=146001950512999&w=2
http://marc.info/?l=linux-kernel&m=146001988013230&w=2

> It seems to be quite redundant with fbdev deferred_io, which itself is
> almost deprecated these days.

That is a valid argument for moving cfag12864b* out to
drivers/video/* I guess, but it has nothing to do with this
driver whatsoever.

This driver has nothing to do with fbdev. Nothing at all.
It so not connected to any framebuffer.

This driver gets moved to auxdisplay to match the existing
LCD driver in drivers/auxdisplay/ks0108.c which is a similar
hardware, driving an LCD that likewise has nothing to do
with fbdev.

Yours,
Linus Walleij

[toc] | [prev] | [next] | [standalone]

#1389931

[Multipart message — attachments visible in raw view] — view raw

On Tue, Apr 26, 2016 at 12:41:29PM +0200, Linus Walleij wrote:
> On Mon, Apr 25, 2016 at 1:57 PM, Maxime Ripard
> <maxime.ripard@free-electrons.com> wrote:
> > On Sat, Apr 23, 2016 at 11:43:58AM +0200, Linus Walleij wrote:
> >> Hi ARM SoC guys,
> >>
> >> these two patches move the ARM character LCD driver from
> >> misc drivers to the auxdisplay subsystem where it belongs and
> >> updates the defconfig for the RealView accordingly.
> >>
> >> Please pull it into some cleanup branch in the ARM SoC
> >> tree.
> >>
> >> I tried to get some ACK from the auxdisplay maintainer but no
> >> reaction.
> >
> > Auxdisplay is not a new framework, but rather a very old one.
> >
> > It got introduced in 2.6.21, and only received a couple of drivers
> > since.
> 
> Small problem for me, but Robin is submitting a brand new
> auxdisplay driver:
> http://marc.info/?l=linux-kernel&m=146001950512999&w=2
> http://marc.info/?l=linux-kernel&m=146001988013230&w=2

My understanding is that Tomi doesn't want any new fbdev drivers, so
I'm not sure this is the right place for those patches.

> > It seems to be quite redundant with fbdev deferred_io, which itself is
> > almost deprecated these days.
> 
> That is a valid argument for moving cfag12864b* out to
> drivers/video/* I guess, but it has nothing to do with this
> driver whatsoever.
> 
> This driver has nothing to do with fbdev. Nothing at all.
> It so not connected to any framebuffer.
> 
> This driver gets moved to auxdisplay to match the existing
> LCD driver in drivers/auxdisplay/ks0108.c which is a similar
> hardware, driving an LCD that likewise has nothing to do
> with fbdev.

My bad, I thought all auxdisplay drivers were fbdev ones, but I was
wrong, obviously. And now, I don't really know what auxdisplay is
about anymore :)

Still, moving it to a "framework" that has been inactive for so long
(and you even mention it in your PR) doesn't seem like the right move.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web