Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1386493 > unrolled thread

[PATCH v2 0/3] Add support for ARM Mali Display Processors

Back to article view | Back to linux.kernel

Contents

  [PATCH v2 0/3] Add support for ARM Mali Display Processors Liviu Dudau <Liviu.Dudau@arm.com> - 2016-04-25 16:20 +0200
    [PATCH v2 1/3] dt/bindings: display: Add DT bindings for Mali Display Processors. Liviu Dudau <Liviu.Dudau@arm.com> - 2016-04-25 16:30 +0200
      Re: [PATCH v2 1/3] dt/bindings: display: Add DT bindings for Mali  Display Processors. Rob Herring <robh@kernel.org> - 2016-04-28 04:50 +0200
    [PATCH v2 3/3] MAINTAINERS: Add entry for Mali-DP driver Liviu Dudau <Liviu.Dudau@arm.com> - 2016-04-25 16:30 +0200
      Re: [PATCH v2 3/3] MAINTAINERS: Add entry for Mali-DP driver Emil Velikov <emil.l.velikov@gmail.com> - 2016-04-25 18:10 +0200
        Re: [PATCH v2 3/3] MAINTAINERS: Add entry for Mali-DP driver Liviu Dudau <Liviu.Dudau@arm.com> - 2016-04-25 19:10 +0200
          Re: [PATCH v2 3/3] MAINTAINERS: Add entry for Mali-DP driver Emil Velikov <emil.l.velikov@gmail.com> - 2016-04-25 20:00 +0200

#1386493 — [PATCH v2 0/3] Add support for ARM Mali Display Processors

Hello,

This is the second revision of the driver for the Mali Display Processors (Mali DP).
Currently, the driver supports the Display Engine found in Mali DP500, DP550
and DP650, with up to 3 planes that can be rotated by the hardware. There are
features that the hardware supports that are not currently implemented in the
driver, but in the current form it is capable of supporting X11 using fbdev
emulation as well as Wayland with pixman rendering.

Changes in v2 vs initial RFC:
 - merged malidp_crtc_mode_set_nofb into malidp_crtc_enable and removed the
   mode_set hooks. This removed the need for a custom destroy hook as well,
   switched to using drm_crtc_cleanup for that.
 - implemented proper async support for atomic page flip.
 - removed un-necessary checks and empty hooks.
 - clarifications in the bindings document for the use of interrupt-names.
 - removed the MALIDP_HW_FEATURE_DS (display split) from this version pending
   further development
 - Renamed module from malidp to mali-dp.
 - Added MAINTAINERS update

Many thanks,
Liviu

Liviu Dudau (3):
  dt/bindings: display: Add DT bindings for Mali Display Processors.
  drm/arm: Add support for Mali Display Processors
  MAINTAINERS: Add entry for Mali-DP driver

 .../devicetree/bindings/display/arm,malidp.txt     |  65 ++
 drivers/gpu/drm/arm/Kconfig                        |  16 +
 drivers/gpu/drm/arm/Makefile                       |   2 +
 drivers/gpu/drm/arm/malidp_crtc.c                  | 259 +++++++
 drivers/gpu/drm/arm/malidp_drv.c                   | 538 ++++++++++++++
 drivers/gpu/drm/arm/malidp_drv.h                   |  54 ++
 drivers/gpu/drm/arm/malidp_hw.c                    | 774 +++++++++++++++++++++
 drivers/gpu/drm/arm/malidp_hw.h                    | 189 +++++
 drivers/gpu/drm/arm/malidp_planes.c                | 337 +++++++++
 drivers/gpu/drm/arm/malidp_regs.h                  | 172 +++++
 MAINTAINERS                                        | 10 +++++++++-
 11 files changed, 2415 insertions(+), 1 deletion(-)
 create mode 100644 Documentation/devicetree/bindings/display/arm,malidp.txt
 create mode 100644 drivers/gpu/drm/arm/malidp_crtc.c
 create mode 100644 drivers/gpu/drm/arm/malidp_drv.c
 create mode 100644 drivers/gpu/drm/arm/malidp_drv.h
 create mode 100644 drivers/gpu/drm/arm/malidp_hw.c
 create mode 100644 drivers/gpu/drm/arm/malidp_hw.h
 create mode 100644 drivers/gpu/drm/arm/malidp_planes.c
 create mode 100644 drivers/gpu/drm/arm/malidp_regs.h

-- 
2.8.0

[toc] | [next] | [standalone]

#1386508 — [PATCH v2 1/3] dt/bindings: display: Add DT bindings for Mali Display Processors.

Add DT bindings documentation for the Mali Display Processor. The bindings
describe the Mali DP500, DP550 and DP650 processors from ARM Ltd.

Cc: Rob Herring <robh+dt@kernel.org>
Cc: Pawel Moll <pawel.moll@arm.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Ian Campbell <ijc+devicetree@hellion.org.uk>
Cc: Kumar Gala <galak@codeaurora.org>

Signed-off-by: Liviu Dudau <Liviu.Dudau@arm.com>
---
 .../devicetree/bindings/display/arm,malidp.txt     | 65 ++++++++++++++++++++++
 1 file changed, 65 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/arm,malidp.txt

diff --git a/Documentation/devicetree/bindings/display/arm,malidp.txt b/Documentation/devicetree/bindings/display/arm,malidp.txt
new file mode 100644
index 0000000..2f78709
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/arm,malidp.txt
@@ -0,0 +1,65 @@
+ARM Mali-DP
+
+The following bindings apply to a family of Display Processors sold as
+licensable IP by ARM Ltd. The bindings describe the Mali DP500, DP550 and
+DP650 processors that offer multiple composition layers, support for
+rotation and scaling output.
+
+Required properties:
+  - compatible: should be one of
+	"arm,mali-dp500"
+	"arm,mali-dp550"
+	"arm,mali-dp650"
+    depending on the particular implementation present in the hardware
+  - reg: Physical base address and size of the block of registers used by
+    the processor.
+  - interrupts: Interrupt list, as defined in ../interrupt-controller/interrupts.txt,
+    interrupt client nodes.
+  - interrupt-names: name of the engine inside the processor that will
+    use the corresponding interrupt. Should be one of "DE" or "SE".
+  - clocks: A list of phandle + clock-specifier pairs, one for each entry
+    in 'clock-names'
+  - clock-names: A list of clock names. It should contain:
+      - "pclk": for the APB interface clock
+      - "aclk": for the AXI interface clock
+      - "mclk": for the main processor clock
+      - "pxlclk": for the pixel clock feeding the output PLL of the processor.
+  - arm,malidp-output-port-lines: Array of u8 values describing the number
+    of output lines per channel (R, G and B).
+
+Required sub-nodes:
+  - port: The Mali DP connection to an encoder input port. The connection
+    is modelled using the OF graph bindings specified in
+    Documentation/devicetree/bindings/graph.txt
+
+Optional properties:
+  - memory-region: phandle to a node describing memory (see
+    Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt)
+    to be used for the framebuffer; if not present, the framebuffer may
+    be located anywhere in memory.
+
+
+Example:
+
+/ {
+	...
+
+	dp0: malidp@6f200000 {
+		compatible = "arm,mali-dp650";
+		reg = <0 0x6f200000 0 0x20000>;
+		memory-region = <&display_reserved>;
+		interrupts = <0 168 IRQ_TYPE_LEVEL_HIGH>,
+			     <0 168 IRQ_TYPE_LEVEL_HIGH>;
+		interrupt-names = "DE", "SE";
+		clocks = <&oscclk2>, <&fpgaosc0>, <&fpgaosc1>, <&fpgaosc1>;
+		clock-names = "pxlclk", "mclk", "aclk", "pclk";
+		arm,malidp-output-port-lines = /bits/ 8 <8 8 8>;
+		port {
+			dp0_output: endpoint {
+				remote-endpoint = <&tda998x_2_input>;
+			};
+		};
+	};
+
+	...
+};
-- 
2.8.0

[toc] | [prev] | [next] | [standalone]

#1389775 — Re: [PATCH v2 1/3] dt/bindings: display: Add DT bindings for Mali Display Processors.

On Mon, Apr 25, 2016 at 03:19:22PM +0100, Liviu Dudau wrote:
> Add DT bindings documentation for the Mali Display Processor. The bindings
> describe the Mali DP500, DP550 and DP650 processors from ARM Ltd.
> 
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Pawel Moll <pawel.moll@arm.com>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Ian Campbell <ijc+devicetree@hellion.org.uk>
> Cc: Kumar Gala <galak@codeaurora.org>
> 
> Signed-off-by: Liviu Dudau <Liviu.Dudau@arm.com>
> ---
>  .../devicetree/bindings/display/arm,malidp.txt     | 65 ++++++++++++++++++++++
>  1 file changed, 65 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/arm,malidp.txt

Acked-by: Rob Herring <robh@kernel.org>

[toc] | [prev] | [next] | [standalone]

#1386510 — [PATCH v2 3/3] MAINTAINERS: Add entry for Mali-DP driver

Add MAINTAINERS entry for ARM Mali-DP driver and update the
HDLCD file matching pattern to cover only HDLCD rather than
the whole drivers/gpu/drm/arm directory.

Signed-off-by: Liviu Dudau <Liviu.Dudau@arm.com>
---
 MAINTAINERS | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 1d5b4be..a5a4346 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -850,9 +850,17 @@ F:	include/uapi/linux/if_arcnet.h
 ARM HDLCD DRM DRIVER
 M:	Liviu Dudau <liviu.dudau@arm.com>
 S:	Supported
-F:	drivers/gpu/drm/arm/
+F:	drivers/gpu/drm/arm/hdlcd_*
 F:	Documentation/devicetree/bindings/display/arm,hdlcd.txt
 
+ARM MALI-DP DRM DRIVER
+M:	Liviu Dudau <liviu.dudau@arm.com>
+M:	Brian Starkey <brian.starkey@arm.com>
+M:	Mali DP Maintainers <malidp@foss.arm.com>
+S:	Supported
+F:	drivers/gpu/drm/arm/
+F:	Documentation/devicetree/bindings/display/arm,malidp.txt
+
 ARM MFM AND FLOPPY DRIVERS
 M:	Ian Molton <spyro@f2s.com>
 S:	Maintained
-- 
2.8.0

[toc] | [prev] | [next] | [standalone]

#1386628 — Re: [PATCH v2 3/3] MAINTAINERS: Add entry for Mali-DP driver

On 25 April 2016 at 15:19, Liviu Dudau <Liviu.Dudau@arm.com> wrote:
> Add MAINTAINERS entry for ARM Mali-DP driver and update the
> HDLCD file matching pattern to cover only HDLCD rather than
> the whole drivers/gpu/drm/arm directory.
>
> Signed-off-by: Liviu Dudau <Liviu.Dudau@arm.com>
> ---
>  MAINTAINERS | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 1d5b4be..a5a4346 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -850,9 +850,17 @@ F: include/uapi/linux/if_arcnet.h
>  ARM HDLCD DRM DRIVER
>  M:     Liviu Dudau <liviu.dudau@arm.com>
>  S:     Supported
> -F:     drivers/gpu/drm/arm/
> +F:     drivers/gpu/drm/arm/hdlcd_*
>  F:     Documentation/devicetree/bindings/display/arm,hdlcd.txt
>
> +ARM MALI-DP DRM DRIVER
> +M:     Liviu Dudau <liviu.dudau@arm.com>
> +M:     Brian Starkey <brian.starkey@arm.com>
> +M:     Mali DP Maintainers <malidp@foss.arm.com>
> +S:     Supported
> +F:     drivers/gpu/drm/arm/
Woohoo. Thanks Liviu !

Note that having both drivers' sources in the same folder will cause
some grief wrt getting the correct maintainer. If you want to avoid
that the easiest way is to move things in subdirectories roughly like:

drivers/gpu/arm/hdlcd/
drivers/gpu/arm/mapidp/

Regards,
Emil

[toc] | [prev] | [next] | [standalone]

#1386681 — Re: [PATCH v2 3/3] MAINTAINERS: Add entry for Mali-DP driver

On Mon, Apr 25, 2016 at 05:00:02PM +0100, Emil Velikov wrote:
> On 25 April 2016 at 15:19, Liviu Dudau <Liviu.Dudau@arm.com> wrote:
> > Add MAINTAINERS entry for ARM Mali-DP driver and update the
> > HDLCD file matching pattern to cover only HDLCD rather than
> > the whole drivers/gpu/drm/arm directory.
> >
> > Signed-off-by: Liviu Dudau <Liviu.Dudau@arm.com>
> > ---
> >  MAINTAINERS | 10 +++++++++-
> >  1 file changed, 9 insertions(+), 1 deletion(-)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 1d5b4be..a5a4346 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -850,9 +850,17 @@ F: include/uapi/linux/if_arcnet.h
> >  ARM HDLCD DRM DRIVER
> >  M:     Liviu Dudau <liviu.dudau@arm.com>
> >  S:     Supported
> > -F:     drivers/gpu/drm/arm/
> > +F:     drivers/gpu/drm/arm/hdlcd_*
> >  F:     Documentation/devicetree/bindings/display/arm,hdlcd.txt
> >
> > +ARM MALI-DP DRM DRIVER
> > +M:     Liviu Dudau <liviu.dudau@arm.com>
> > +M:     Brian Starkey <brian.starkey@arm.com>
> > +M:     Mali DP Maintainers <malidp@foss.arm.com>
> > +S:     Supported
> > +F:     drivers/gpu/drm/arm/
> Woohoo. Thanks Liviu !
> 
> Note that having both drivers' sources in the same folder will cause
> some grief wrt getting the correct maintainer. If you want to avoid
> that the easiest way is to move things in subdirectories roughly like:
> 
> drivers/gpu/arm/hdlcd/
> drivers/gpu/arm/mapidp/

I'm surprised to hear that there might be problems. All HDLCD files start
with hdlcd_ and the rest will go to the Mali-DP DRM maintainers (which includes
me as well).

I understand your suggestion and I thank for it, but I really hate to have
to navigate too many directories (for now). Lets see how things evolve and then
we can move stuff around.

Best regards,
Liviu


> 
> Regards,
> Emil
> 

-- 
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯

[toc] | [prev] | [next] | [standalone]

#1386719 — Re: [PATCH v2 3/3] MAINTAINERS: Add entry for Mali-DP driver

On 25 April 2016 at 18:08, Liviu Dudau <Liviu.Dudau@arm.com> wrote:
> On Mon, Apr 25, 2016 at 05:00:02PM +0100, Emil Velikov wrote:
>> On 25 April 2016 at 15:19, Liviu Dudau <Liviu.Dudau@arm.com> wrote:
>> > Add MAINTAINERS entry for ARM Mali-DP driver and update the
>> > HDLCD file matching pattern to cover only HDLCD rather than
>> > the whole drivers/gpu/drm/arm directory.
>> >
>> > Signed-off-by: Liviu Dudau <Liviu.Dudau@arm.com>
>> > ---
>> >  MAINTAINERS | 10 +++++++++-
>> >  1 file changed, 9 insertions(+), 1 deletion(-)
>> >
>> > diff --git a/MAINTAINERS b/MAINTAINERS
>> > index 1d5b4be..a5a4346 100644
>> > --- a/MAINTAINERS
>> > +++ b/MAINTAINERS
>> > @@ -850,9 +850,17 @@ F: include/uapi/linux/if_arcnet.h
>> >  ARM HDLCD DRM DRIVER
>> >  M:     Liviu Dudau <liviu.dudau@arm.com>
>> >  S:     Supported
>> > -F:     drivers/gpu/drm/arm/
>> > +F:     drivers/gpu/drm/arm/hdlcd_*
>> >  F:     Documentation/devicetree/bindings/display/arm,hdlcd.txt
>> >
>> > +ARM MALI-DP DRM DRIVER
>> > +M:     Liviu Dudau <liviu.dudau@arm.com>
>> > +M:     Brian Starkey <brian.starkey@arm.com>
>> > +M:     Mali DP Maintainers <malidp@foss.arm.com>
>> > +S:     Supported
>> > +F:     drivers/gpu/drm/arm/
>> Woohoo. Thanks Liviu !
>>
>> Note that having both drivers' sources in the same folder will cause
>> some grief wrt getting the correct maintainer. If you want to avoid
>> that the easiest way is to move things in subdirectories roughly like:
>>
>> drivers/gpu/arm/hdlcd/
>> drivers/gpu/arm/mapidp/
>
> I'm surprised to hear that there might be problems. All HDLCD files start
> with hdlcd_ and the rest will go to the Mali-DP DRM maintainers (which includes
> me as well).
>
You're absolutely right. I read things the wrong way - the MaliDP
maintainers will be added for the HDLCD patches. Which obviously isn't
the case.

> I understand your suggestion and I thank for it, but I really hate to have
> to navigate too many directories (for now). Lets see how things evolve and then
> we can move stuff around.
>
IIRC DRM had the same structure (all drivers living in a single a
folder) before 2008, before people got fed up.
Feel free to do as you wish, just pointing out some historical observations ;-)

Regardless of my suggestions/nitpicks, thanks for all the work Liviu !
It's really nice to see more vendors contributing to DRM.

Regards,
Emil

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web