Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1380833 > unrolled thread

[PATCH V3 05/11] staging: mt29f_spinand: set ECC algorithm explicitly

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH V3 05/11] staging: mt29f_spinand: set ECC algorithm explicitly Rafał Miłecki <zajec5@gmail.com> - 2016-04-17 23:00 +0200
    Re: [PATCH V3 05/11] staging: mt29f_spinand: set ECC algorithm  explicitly Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-04-21 22:30 +0200
      Re: [PATCH V3 05/11] staging: mt29f_spinand: set ECC algorithm  explicitly Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-04-22 04:40 +0200

#1380833 — [PATCH V3 05/11] staging: mt29f_spinand: set ECC algorithm explicitly

This is part of process deprecating NAND_ECC_SOFT_BCH (and switching to
enum nand_ecc_algo).

Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
---
 drivers/staging/mt29f_spinand/mt29f_spinand.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/mt29f_spinand/mt29f_spinand.c b/drivers/staging/mt29f_spinand/mt29f_spinand.c
index f503699..e389009 100644
--- a/drivers/staging/mt29f_spinand/mt29f_spinand.c
+++ b/drivers/staging/mt29f_spinand/mt29f_spinand.c
@@ -900,6 +900,7 @@ static int spinand_probe(struct spi_device *spi_nand)
 	chip->ecc.write_page = spinand_write_page_hwecc;
 #else
 	chip->ecc.mode	= NAND_ECC_SOFT;
+	chip->ecc.algo	= NAND_ECC_HAMMING;
 	if (spinand_disable_ecc(spi_nand) < 0)
 		dev_info(&spi_nand->dev, "%s: disable ecc failed!\n",
 			 __func__);
-- 
1.8.4.5

[toc] | [next] | [standalone]

#1384556 — Re: [PATCH V3 05/11] staging: mt29f_spinand: set ECC algorithm explicitly

Hi Greg,

On Sun, 17 Apr 2016 22:53:01 +0200
Rafał Miłecki <zajec5@gmail.com> wrote:

> This is part of process deprecating NAND_ECC_SOFT_BCH (and switching to
> enum nand_ecc_algo).

Do you mind if I take this patch through the NAND tree in order to avoid
dependency problems?

> 
> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
> ---
>  drivers/staging/mt29f_spinand/mt29f_spinand.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/mt29f_spinand/mt29f_spinand.c b/drivers/staging/mt29f_spinand/mt29f_spinand.c
> index f503699..e389009 100644
> --- a/drivers/staging/mt29f_spinand/mt29f_spinand.c
> +++ b/drivers/staging/mt29f_spinand/mt29f_spinand.c
> @@ -900,6 +900,7 @@ static int spinand_probe(struct spi_device *spi_nand)
>  	chip->ecc.write_page = spinand_write_page_hwecc;
>  #else
>  	chip->ecc.mode	= NAND_ECC_SOFT;
> +	chip->ecc.algo	= NAND_ECC_HAMMING;
>  	if (spinand_disable_ecc(spi_nand) < 0)
>  		dev_info(&spi_nand->dev, "%s: disable ecc failed!\n",
>  			 __func__);



-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[toc] | [prev] | [next] | [standalone]

#1384668 — Re: [PATCH V3 05/11] staging: mt29f_spinand: set ECC algorithm explicitly

On Thu, Apr 21, 2016 at 10:20:56PM +0200, Boris Brezillon wrote:
> Hi Greg,
> 
> On Sun, 17 Apr 2016 22:53:01 +0200
> Rafał Miłecki <zajec5@gmail.com> wrote:
> 
> > This is part of process deprecating NAND_ECC_SOFT_BCH (and switching to
> > enum nand_ecc_algo).
> 
> Do you mind if I take this patch through the NAND tree in order to avoid
> dependency problems?

Not at all:
	Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web