Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1383785 > unrolled thread
| Started by | Stefan Agner <stefan@agner.ch> |
|---|---|
| First post | 2016-04-21 01:10 +0200 |
| Last post | 2016-04-22 01:30 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] rtc: snvs: return error in case enable_irq_wake fails Stefan Agner <stefan@agner.ch> - 2016-04-21 01:10 +0200
Re: [PATCH] rtc: snvs: return error in case enable_irq_wake fails Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-04-22 01:30 +0200
| From | Stefan Agner <stefan@agner.ch> |
|---|---|
| Date | 2016-04-21 01:10 +0200 |
| Subject | [PATCH] rtc: snvs: return error in case enable_irq_wake fails |
| Message-ID | <rq9pT-7AD-1@gated-at.bofh.it> |
If enable_irq_wake fails, we should return that error code so that entering suspend fails. Otherwise we will get a WARNING along with the hint of a unbalanced wake disable: Unbalanced IRQ 37 wake disable Signed-off-by: Stefan Agner <stefan@agner.ch> --- drivers/rtc/rtc-snvs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-snvs.c b/drivers/rtc/rtc-snvs.c index 950c5d0..0f11c2a2 100644 --- a/drivers/rtc/rtc-snvs.c +++ b/drivers/rtc/rtc-snvs.c @@ -322,7 +322,7 @@ static int snvs_rtc_suspend(struct device *dev) struct snvs_rtc_data *data = dev_get_drvdata(dev); if (device_may_wakeup(dev)) - enable_irq_wake(data->irq); + return enable_irq_wake(data->irq); return 0; } -- 2.8.0
[toc] | [next] | [standalone]
| From | Alexandre Belloni <alexandre.belloni@free-electrons.com> |
|---|---|
| Date | 2016-04-22 01:30 +0200 |
| Message-ID | <rqwcO-yV-7@gated-at.bofh.it> |
| In reply to | #1383785 |
On 20/04/2016 at 16:09:57 -0700, Stefan Agner wrote : > If enable_irq_wake fails, we should return that error code so that > entering suspend fails. Otherwise we will get a WARNING along with > the hint of a unbalanced wake disable: > Unbalanced IRQ 37 wake disable > > Signed-off-by: Stefan Agner <stefan@agner.ch> > --- > drivers/rtc/rtc-snvs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web