Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1384572 > unrolled thread

[PATCH] wcn36xx: Set SMD timeout to 10 seconds

Started byBjorn Andersson <bjorn.andersson@linaro.org>
First post2016-04-21 23:10 +0200
Last post2016-04-27 15:00 +0200
Articles 3 — 3 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] wcn36xx: Set SMD timeout to 10 seconds Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-04-21 23:10 +0200
    Re: [PATCH] wcn36xx: Set SMD timeout to 10 seconds John Stultz <john.stultz@linaro.org> - 2016-04-21 23:20 +0200
    Re: [PATCH] wcn36xx: Set SMD timeout to 10 seconds Kalle Valo <kvalo@codeaurora.org> - 2016-04-27 15:00 +0200

#1384572 — [PATCH] wcn36xx: Set SMD timeout to 10 seconds

FromBjorn Andersson <bjorn.andersson@linaro.org>
Date2016-04-21 23:10 +0200
Subject[PATCH] wcn36xx: Set SMD timeout to 10 seconds
Message-ID<rqu1k-7pb-13@gated-at.bofh.it>
After booting the wireless subsystem and uploading the NV blob to the
WCNSS_CTRL service the remote continues to do things and will not start
servicing wlan-requests for another 2-5 seconds (measured).

The downstream code does not have any special handling for this case,
but has a timeout of 10 seconds for the communication layer. By
extending the wcn36xx timeout to match this we follows the same flow for
the boot procedure and can successfully configure WiFi as wlan0 is
registered.

Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
 drivers/net/wireless/ath/wcn36xx/smd.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/wcn36xx/smd.h b/drivers/net/wireless/ath/wcn36xx/smd.h
index e6aadd273c46..6310560901f0 100644
--- a/drivers/net/wireless/ath/wcn36xx/smd.h
+++ b/drivers/net/wireless/ath/wcn36xx/smd.h
@@ -24,7 +24,7 @@
 
 #define WCN36XX_HAL_BUF_SIZE				4096
 
-#define HAL_MSG_TIMEOUT 500
+#define HAL_MSG_TIMEOUT 10000
 #define WCN36XX_SMSM_WLAN_TX_ENABLE			0x00000400
 #define WCN36XX_SMSM_WLAN_TX_RINGS_EMPTY		0x00000200
 /* The PNO version info be contained in the rsp msg */
-- 
2.5.0

[toc] | [next] | [standalone]


#1384575

FromJohn Stultz <john.stultz@linaro.org>
Date2016-04-21 23:20 +0200
Message-ID<rqub0-7sG-17@gated-at.bofh.it>
In reply to#1384572
On Thu, Apr 21, 2016 at 2:09 PM, Bjorn Andersson
<bjorn.andersson@linaro.org> wrote:
> After booting the wireless subsystem and uploading the NV blob to the
> WCNSS_CTRL service the remote continues to do things and will not start
> servicing wlan-requests for another 2-5 seconds (measured).
>
> The downstream code does not have any special handling for this case,
> but has a timeout of 10 seconds for the communication layer. By
> extending the wcn36xx timeout to match this we follows the same flow for
> the boot procedure and can successfully configure WiFi as wlan0 is
> registered.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>

I've been using this with my nexus7 tree, and its avoided issues I was
seeing without it.

Tested-by: John Stultz <john.stultz@linaro.org>

thanks
-john

[toc] | [prev] | [next] | [standalone]


#1389011

FromKalle Valo <kvalo@codeaurora.org>
Date2016-04-27 15:00 +0200
Message-ID<rsxer-1nA-19@gated-at.bofh.it>
In reply to#1384572
Bjorn Andersson <bjorn.andersson@linaro.org> writes:

> After booting the wireless subsystem and uploading the NV blob to the
> WCNSS_CTRL service the remote continues to do things and will not start
> servicing wlan-requests for another 2-5 seconds (measured).
>
> The downstream code does not have any special handling for this case,
> but has a timeout of 10 seconds for the communication layer. By
> extending the wcn36xx timeout to match this we follows the same flow for
> the boot procedure and can successfully configure WiFi as wlan0 is
> registered.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>

Applied, thanks.

-- 
Kalle Valo

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web