Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1382721 > unrolled thread
| Started by | Eric Auger <eric.auger@linaro.org> |
|---|---|
| First post | 2016-04-19 19:20 +0200 |
| Last post | 2016-04-22 17:50 +0200 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH v7 1/8] genirq/msi: Add a new MSI_FLAG_IRQ_REMAPPING flag Eric Auger <eric.auger@linaro.org> - 2016-04-19 19:20 +0200
Re: [PATCH v7 1/8] genirq/msi: Add a new MSI_FLAG_IRQ_REMAPPING flag Robin Murphy <robin.murphy@arm.com> - 2016-04-22 13:10 +0200
Re: [PATCH v7 1/8] genirq/msi: Add a new MSI_FLAG_IRQ_REMAPPING flag Eric Auger <eric.auger@linaro.org> - 2016-04-22 14:30 +0200
Re: [PATCH v7 1/8] genirq/msi: Add a new MSI_FLAG_IRQ_REMAPPING flag Thomas Gleixner <tglx@linutronix.de> - 2016-04-22 17:50 +0200
| From | Eric Auger <eric.auger@linaro.org> |
|---|---|
| Date | 2016-04-19 19:20 +0200 |
| Subject | [PATCH v7 1/8] genirq/msi: Add a new MSI_FLAG_IRQ_REMAPPING flag |
| Message-ID | <rpHtE-1RO-1@gated-at.bofh.it> |
Let's introduce a new msi_domain_info flag value, MSI_FLAG_IRQ_REMAPPING
meant to tell the domain supports IRQ REMAPPING, also known as Interrupt
Translation Service. On Intel HW this IRQ remapping capability is
abstracted on IOMMU side while on ARM it is abstracted on MSI controller
side. This flag will be used to know whether the MSI passthrough is
safe.
Signed-off-by: Eric Auger <eric.auger@linaro.org>
---
v4 -> v5:
- seperate flag introduction from first user addition (ITS)
---
include/linux/msi.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/linux/msi.h b/include/linux/msi.h
index 8b425c6..08441b1 100644
--- a/include/linux/msi.h
+++ b/include/linux/msi.h
@@ -270,6 +270,8 @@ enum {
MSI_FLAG_MULTI_PCI_MSI = (1 << 3),
/* Support PCI MSIX interrupts */
MSI_FLAG_PCI_MSIX = (1 << 4),
+ /* Support MSI IRQ remapping service */
+ MSI_FLAG_IRQ_REMAPPING = (1 << 5),
};
int msi_domain_set_affinity(struct irq_data *data, const struct cpumask *mask,
--
1.9.1
[toc] | [next] | [standalone]
| From | Robin Murphy <robin.murphy@arm.com> |
|---|---|
| Date | 2016-04-22 13:10 +0200 |
| Message-ID | <rqH8e-ZP-9@gated-at.bofh.it> |
| In reply to | #1382721 |
Hi Eric,
On 19/04/16 18:13, Eric Auger wrote:
> Let's introduce a new msi_domain_info flag value, MSI_FLAG_IRQ_REMAPPING
> meant to tell the domain supports IRQ REMAPPING, also known as Interrupt
> Translation Service. On Intel HW this IRQ remapping capability is
> abstracted on IOMMU side while on ARM it is abstracted on MSI controller
> side. This flag will be used to know whether the MSI passthrough is
> safe.
Perhaps a nitpick, but given the earlier confusion about what the IOMMU
flag actually meant this prompts me to wonder if it's worth adjusting
the general terminology before we propagate it further. What I think we
actually care about is that one thing or the other "provides MSI
isolation" rather than "supports MSI remapping", since the latter is all
to easy to misinterpret the way we did in the SMMU drivers.
Robin.
> Signed-off-by: Eric Auger <eric.auger@linaro.org>
>
> ---
>
> v4 -> v5:
> - seperate flag introduction from first user addition (ITS)
> ---
> include/linux/msi.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/linux/msi.h b/include/linux/msi.h
> index 8b425c6..08441b1 100644
> --- a/include/linux/msi.h
> +++ b/include/linux/msi.h
> @@ -270,6 +270,8 @@ enum {
> MSI_FLAG_MULTI_PCI_MSI = (1 << 3),
> /* Support PCI MSIX interrupts */
> MSI_FLAG_PCI_MSIX = (1 << 4),
> + /* Support MSI IRQ remapping service */
> + MSI_FLAG_IRQ_REMAPPING = (1 << 5),
> };
>
> int msi_domain_set_affinity(struct irq_data *data, const struct cpumask *mask,
>
[toc] | [prev] | [next] | [standalone]
| From | Eric Auger <eric.auger@linaro.org> |
|---|---|
| Date | 2016-04-22 14:30 +0200 |
| Message-ID | <rqInE-1Q8-3@gated-at.bofh.it> |
| In reply to | #1384978 |
Robin,
On 04/22/2016 01:02 PM, Robin Murphy wrote:
> Hi Eric,
>
> On 19/04/16 18:13, Eric Auger wrote:
>> Let's introduce a new msi_domain_info flag value, MSI_FLAG_IRQ_REMAPPING
>> meant to tell the domain supports IRQ REMAPPING, also known as Interrupt
>> Translation Service. On Intel HW this IRQ remapping capability is
>> abstracted on IOMMU side while on ARM it is abstracted on MSI controller
>> side. This flag will be used to know whether the MSI passthrough is
>> safe.
>
> Perhaps a nitpick, but given the earlier confusion about what the IOMMU
> flag actually meant this prompts me to wonder if it's worth adjusting
> the general terminology before we propagate it further. What I think we
> actually care about is that one thing or the other "provides MSI
> isolation" rather than "supports MSI remapping", since the latter is all
> to easy to misinterpret the way we did in the SMMU drivers.
The only concern I have is https://lkml.org/lkml/2016/4/18/283 attempts
to define a PCI bus flag dubbed PCI_BUS_FLAGS_MSI_REMAP combining the
iommu & msi layer info. In that sense x86 people may not be keen of
having different terminaologies. Anyway I will follow the consensus, if any.
Best Regards
Eric
>
> Robin.
>
>> Signed-off-by: Eric Auger <eric.auger@linaro.org>
>>
>> ---
>>
>> v4 -> v5:
>> - seperate flag introduction from first user addition (ITS)
>> ---
>> include/linux/msi.h | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/include/linux/msi.h b/include/linux/msi.h
>> index 8b425c6..08441b1 100644
>> --- a/include/linux/msi.h
>> +++ b/include/linux/msi.h
>> @@ -270,6 +270,8 @@ enum {
>> MSI_FLAG_MULTI_PCI_MSI = (1 << 3),
>> /* Support PCI MSIX interrupts */
>> MSI_FLAG_PCI_MSIX = (1 << 4),
>> + /* Support MSI IRQ remapping service */
>> + MSI_FLAG_IRQ_REMAPPING = (1 << 5),
>> };
>>
>> int msi_domain_set_affinity(struct irq_data *data, const struct
>> cpumask *mask,
>>
>
[toc] | [prev] | [next] | [standalone]
| From | Thomas Gleixner <tglx@linutronix.de> |
|---|---|
| Date | 2016-04-22 17:50 +0200 |
| Subject | Re: [PATCH v7 1/8] genirq/msi: Add a new MSI_FLAG_IRQ_REMAPPING flag |
| Message-ID | <rqLvd-49a-41@gated-at.bofh.it> |
| In reply to | #1385118 |
On Fri, 22 Apr 2016, Eric Auger wrote: > Robin, > On 04/22/2016 01:02 PM, Robin Murphy wrote: > > Hi Eric, > > > > On 19/04/16 18:13, Eric Auger wrote: > >> Let's introduce a new msi_domain_info flag value, MSI_FLAG_IRQ_REMAPPING > >> meant to tell the domain supports IRQ REMAPPING, also known as Interrupt > >> Translation Service. On Intel HW this IRQ remapping capability is > >> abstracted on IOMMU side while on ARM it is abstracted on MSI controller > >> side. This flag will be used to know whether the MSI passthrough is > >> safe. > > > > Perhaps a nitpick, but given the earlier confusion about what the IOMMU > > flag actually meant this prompts me to wonder if it's worth adjusting > > the general terminology before we propagate it further. What I think we > > actually care about is that one thing or the other "provides MSI > > isolation" rather than "supports MSI remapping", since the latter is all > > to easy to misinterpret the way we did in the SMMU drivers. > > The only concern I have is https://lkml.org/lkml/2016/4/18/283 attempts > to define a PCI bus flag dubbed PCI_BUS_FLAGS_MSI_REMAP combining the > iommu & msi layer info. In that sense x86 people may not be keen of > having different terminaologies. Anyway I will follow the consensus, if any. Yes, please keep that consistent. It makes 'grep' much more conveniant. Thanks, tglx
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web