Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1383580 > unrolled thread

[PATCH 1/1] pinctrl: core: Fix build error due to devm_pinctrl_dev_match()

Started byLaxman Dewangan <ldewangan@nvidia.com>
First post2016-04-20 19:30 +0200
Last post2016-04-21 00:10 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH 1/1] pinctrl: core: Fix build error due to devm_pinctrl_dev_match() Laxman Dewangan <ldewangan@nvidia.com> - 2016-04-20 19:30 +0200
    Re: [PATCH 1/1] pinctrl: core: Fix build error due to devm_pinctrl_dev_match() Linus Walleij <linus.walleij@linaro.org> - 2016-04-21 00:10 +0200

#1383580 — [PATCH 1/1] pinctrl: core: Fix build error due to devm_pinctrl_dev_match()

FromLaxman Dewangan <ldewangan@nvidia.com>
Date2016-04-20 19:30 +0200
Subject[PATCH 1/1] pinctrl: core: Fix build error due to devm_pinctrl_dev_match()
Message-ID<rq46S-33d-21@gated-at.bofh.it>
The closing bracket missing from final patch which causes the
build break. Correcting the function.

Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>

---
This may be happend by mistake when applyign the pathces for git hub from
test branch to devm_pinctrl branch.
This is happening on devel branch of pinctrl subsystem.
---
 drivers/pinctrl/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c
index 21df52e..98d2a1b 100644
--- a/drivers/pinctrl/core.c
+++ b/drivers/pinctrl/core.c
@@ -1883,7 +1883,7 @@ static int devm_pinctrl_dev_match(struct device *dev, void *res, void *data)
 {
 	struct pctldev **r = res;
 
-	if (WARN_ON(!r || !*r)
+	if (WARN_ON(!r || !*r))
 		return 0;
 
 	return *r == data;
-- 
2.1.4

[toc] | [next] | [standalone]


#1383767

FromLinus Walleij <linus.walleij@linaro.org>
Date2016-04-21 00:10 +0200
Message-ID<rq8tQ-6P7-1@gated-at.bofh.it>
In reply to#1383580
On Wed, Apr 20, 2016 at 7:17 PM, Laxman Dewangan <ldewangan@nvidia.com> wrote:

> The closing bracket missing from final patch which causes the
> build break. Correcting the function.
>
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>

Squashed this into the patch and pushed to build again.

Yours,
Linus Walleij

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web