Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1380876 > unrolled thread
| Started by | Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> |
|---|---|
| First post | 2016-04-18 02:40 +0200 |
| Last post | 2016-04-19 09:50 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v3 10/16] zsmalloc: factor page chain functionality out Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2016-04-18 02:40 +0200
Re: [PATCH v3 10/16] zsmalloc: factor page chain functionality out Minchan Kim <minchan@kernel.org> - 2016-04-19 09:50 +0200
| From | Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> |
|---|---|
| Date | 2016-04-18 02:40 +0200 |
| Subject | Re: [PATCH v3 10/16] zsmalloc: factor page chain functionality out |
| Message-ID | <rp5om-4yK-19@gated-at.bofh.it> |
Hello, On (03/30/16 16:12), Minchan Kim wrote: > @@ -1421,7 +1434,6 @@ static unsigned long obj_malloc(struct size_class *class, > unsigned long m_offset; > void *vaddr; > > - handle |= OBJ_ALLOCATED_TAG; a nitpick, why did you replace this ALLOCATED_TAG assignment with 2 'handle | OBJ_ALLOCATED_TAG'? -ss > obj = get_freeobj(first_page); > objidx_to_page_and_offset(class, first_page, obj, > &m_page, &m_offset); > @@ -1431,10 +1443,10 @@ static unsigned long obj_malloc(struct size_class *class, > set_freeobj(first_page, link->next >> OBJ_ALLOCATED_TAG); > if (!class->huge) > /* record handle in the header of allocated chunk */ > - link->handle = handle; > + link->handle = handle | OBJ_ALLOCATED_TAG; > else > /* record handle in first_page->private */ > - set_page_private(first_page, handle); > + set_page_private(first_page, handle | OBJ_ALLOCATED_TAG); > kunmap_atomic(vaddr); > mod_zspage_inuse(first_page, 1); > zs_stat_inc(class, OBJ_USED, 1);
[toc] | [next] | [standalone]
| From | Minchan Kim <minchan@kernel.org> |
|---|---|
| Date | 2016-04-19 09:50 +0200 |
| Message-ID | <rpyA3-3dt-37@gated-at.bofh.it> |
| In reply to | #1380876 |
On Mon, Apr 18, 2016 at 09:33:05AM +0900, Sergey Senozhatsky wrote: > Hello, > > On (03/30/16 16:12), Minchan Kim wrote: > > @@ -1421,7 +1434,6 @@ static unsigned long obj_malloc(struct size_class *class, > > unsigned long m_offset; > > void *vaddr; > > > > - handle |= OBJ_ALLOCATED_TAG; > > a nitpick, why did you replace this ALLOCATED_TAG assignment > with 2 'handle | OBJ_ALLOCATED_TAG'? I thought this handle variable in here is pure handle but OBJ_ALLOCATED_TAG should live in head(i.e., link->handle), not pure handle, itself. > > -ss > > > obj = get_freeobj(first_page); > > objidx_to_page_and_offset(class, first_page, obj, > > &m_page, &m_offset); > > @@ -1431,10 +1443,10 @@ static unsigned long obj_malloc(struct size_class *class, > > set_freeobj(first_page, link->next >> OBJ_ALLOCATED_TAG); > > if (!class->huge) > > /* record handle in the header of allocated chunk */ > > - link->handle = handle; > > + link->handle = handle | OBJ_ALLOCATED_TAG; > > else > > /* record handle in first_page->private */ > > - set_page_private(first_page, handle); > > + set_page_private(first_page, handle | OBJ_ALLOCATED_TAG); > > kunmap_atomic(vaddr); > > mod_zspage_inuse(first_page, 1); > > zs_stat_inc(class, OBJ_USED, 1);
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web