Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1380294 > unrolled thread

Re: [PATCH] Add EDAC peripheral init functions & Ethernet EDAC.

Started byBorislav Petkov <bp@alien8.de>
First post2016-04-15 23:50 +0200
Last post2016-04-18 22:10 +0200
Articles 3 — 1 participant

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH] Add EDAC peripheral init functions & Ethernet EDAC. Borislav Petkov <bp@alien8.de> - 2016-04-15 23:50 +0200
    Re: [PATCH] Add EDAC peripheral init functions & Ethernet EDAC. Borislav Petkov <bp@alien8.de> - 2016-04-18 22:10 +0200
    Re: [PATCH] Add EDAC peripheral init functions & Ethernet EDAC. Borislav Petkov <bp@alien8.de> - 2016-04-18 22:10 +0200

#1380294 — Re: [PATCH] Add EDAC peripheral init functions & Ethernet EDAC.

FromBorislav Petkov <bp@alien8.de>
Date2016-04-15 23:50 +0200
SubjectRe: [PATCH] Add EDAC peripheral init functions & Ethernet EDAC.
Message-ID<rojMK-1ee-5@gated-at.bofh.it>
On Fri, Apr 15, 2016 at 10:27:54AM -0500, Thor Thayer wrote:
> I'll update this patch to only count errors.

... and also think about what that counting is going to bring. If it is
only going to be there to show how many network errors happened and we
can't do anything about it except stare at that number, then adding all
that code is probably waste of time an electrons...

I'm just sayin'.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply. Srsly.

[toc] | [next] | [standalone]


#1382024

FromBorislav Petkov <bp@alien8.de>
Date2016-04-18 22:10 +0200
Message-ID<rpnEB-317-9@gated-at.bofh.it>
In reply to#1380294
On Mon, Apr 18, 2016 at 10:02:27PM +0200, Borislav Petkov wrote:
> >  the number of uncorrectable errors is useful from a system point of
> > view.

I forgot: so altr_edac_a10_ecc_irq() panics on uncorrectable errors. Do we want
to do that even for UEs coming from the network...?

Seems a bit overboard to me...

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply. Srsly.

[toc] | [prev] | [next] | [standalone]


#1382025

FromBorislav Petkov <bp@alien8.de>
Date2016-04-18 22:10 +0200
Message-ID<rpnEB-317-13@gated-at.bofh.it>
In reply to#1380294
On Mon, Apr 18, 2016 at 09:27:16AM -0500, Thor Thayer wrote:
> We're still getting the single bit correction

By that you mean, you get that by enabling ECC on the FIFO block?

> which makes the entire system more stable and the ability to see both
> single bit errors corrected and the number of uncorrectable errors is
> useful from a system point of view.

If so, that makes sense, yes.

Thanks.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply. Srsly.

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web