Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1381616 > unrolled thread

Re: [PATCH v3] ASoC: mediatek: Add second I2S on mt8173-rt5650 machine driver

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v3] ASoC: mediatek: Add second I2S on mt8173-rt5650  machine driver PC Liao <pc.liao@mediatek.com> - 2016-04-18 13:40 +0200
    Re: [PATCH v3] ASoC: mediatek: Add second I2S on mt8173-rt5650  machine driver Mark Brown <broonie@kernel.org> - 2016-04-18 14:10 +0200
      Re: [PATCH v3] ASoC: mediatek: Add second I2S on mt8173-rt5650  machine driver PC Liao <pc.liao@mediatek.com> - 2016-04-18 15:10 +0200

#1381616 — Re: [PATCH v3] ASoC: mediatek: Add second I2S on mt8173-rt5650 machine driver

Hi Mark,

On Thu, 2016-04-07 at 15:35 +0800, PC Liao wrote:
> This patch adds second I2S connection to rt5650 codec for capture path on
> mt8173-rt5650 machine driver.
> 
> Signed-off-by: PC Liao <pc.liao@mediatek.com>
> ---
> Changes since v2:
> Use sound-dai to determine the capture path.
> ---
>  .../devicetree/bindings/sound/mt8173-rt5650.txt    |    6 +++
>  sound/soc/mediatek/mt8173-rt5650.c                 |   42 ++++++++++++++++++--
>  2 files changed, 44 insertions(+), 4 deletions(-)
> 

Could you please give some comments or suggestions?
Thanks!

[toc] | [next] | [standalone]

#1381644

[Multipart message — attachments visible in raw view] — view raw

On Mon, Apr 18, 2016 at 07:36:20PM +0800, PC Liao wrote:

> Could you please give some comments or suggestions?

I don't have these patches.  If you're getting review comments from
other people please address them, it's quite possible I saw them and
agreed with them.

Please don't send content free pings and please allow a reasonable time
for review.  People get busy, go on holiday, attend conferences and so 
on so unless there is some reason for urgency (like critical bug fixes)
please allow at least a couple of weeks for review.  Sending content
free pings just adds to the mail volume (if they are seen at all) and if 
something has gone wrong you'll have to resend the patches anyway.

[toc] | [prev] | [next] | [standalone]

#1381675

Hi Mark,

On Mon, 2016-04-18 at 20:03 +0800, Mark Brown wrote:
> On Mon, Apr 18, 2016 at 07:36:20PM +0800, PC Liao wrote:
> 
> > Could you please give some comments or suggestions?
> 
> I don't have these patches.  If you're getting review comments from
> other people please address them, it's quite possible I saw them and
> agreed with them.
> 
> Please don't send content free pings and please allow a reasonable time
> for review.  People get busy, go on holiday, attend conferences and so 
> on so unless there is some reason for urgency (like critical bug fixes)
> please allow at least a couple of weeks for review.  Sending content
> free pings just adds to the mail volume (if they are seen at all) and if 
> something has gone wrong you'll have to resend the patches anyway.

I am so sorry about that..........
I have sent v4.
Thanks for your review and help.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web