Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1381457 > unrolled thread
| Started by | Viresh Kumar <viresh.kumar@linaro.org> |
|---|---|
| First post | 2016-04-18 12:20 +0200 |
| Last post | 2016-04-19 12:00 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v2 2/2] cpufreq: powernv: Ramp-down global pstate slower than local-pstate Viresh Kumar <viresh.kumar@linaro.org> - 2016-04-18 12:20 +0200
Re: [PATCH v2 2/2] cpufreq: powernv: Ramp-down global pstate slower than local-pstate Akshay Adiga <akshay.adiga@linux.vnet.ibm.com> - 2016-04-19 12:00 +0200
| From | Viresh Kumar <viresh.kumar@linaro.org> |
|---|---|
| Date | 2016-04-18 12:20 +0200 |
| Subject | Re: [PATCH v2 2/2] cpufreq: powernv: Ramp-down global pstate slower than local-pstate |
| Message-ID | <rperD-3OG-5@gated-at.bofh.it> |
On 15-04-16, 11:58, Akshay Adiga wrote:
> static int powernv_cpufreq_reboot_notifier(struct notifier_block *nb,
> - unsigned long action, void *unused)
> + unsigned long action, void *unused)
Unrelated change.. better don't add such changes..
> {
> int cpu;
> struct cpufreq_policy cpu_policy;
> @@ -603,15 +843,18 @@ static struct notifier_block powernv_cpufreq_opal_nb = {
> static void powernv_cpufreq_stop_cpu(struct cpufreq_policy *policy)
> {
> struct powernv_smp_call_data freq_data;
> -
> + struct global_pstate_info *gpstates = policy->driver_data;
You removed a blank line here and I feel the code looks better with
that.
> freq_data.pstate_id = powernv_pstate_info.min;
> + freq_data.gpstate_id = powernv_pstate_info.min;
> smp_call_function_single(policy->cpu, set_pstate, &freq_data, 1);
> + del_timer_sync(&gpstates->timer);
> }
>
> static struct cpufreq_driver powernv_cpufreq_driver = {
> .name = "powernv-cpufreq",
> .flags = CPUFREQ_CONST_LOOPS,
> .init = powernv_cpufreq_cpu_init,
> + .exit = powernv_cpufreq_cpu_exit,
> .verify = cpufreq_generic_frequency_table_verify,
> .target_index = powernv_cpufreq_target_index,
> .get = powernv_cpufreq_get,
None of the above comments are mandatory for you to fix..
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
[toc] | [next] | [standalone]
| From | Akshay Adiga <akshay.adiga@linux.vnet.ibm.com> |
|---|---|
| Date | 2016-04-19 12:00 +0200 |
| Message-ID | <rpABQ-4Lu-11@gated-at.bofh.it> |
| In reply to | #1381457 |
Hi Viresh,
On 04/18/2016 03:48 PM, Viresh Kumar wrote:
> On 15-04-16, 11:58, Akshay Adiga wrote:
>> static int powernv_cpufreq_reboot_notifier(struct notifier_block *nb,
>> - unsigned long action, void *unused)
>> + unsigned long action, void *unused)
> Unrelated change.. better don't add such changes..
Posting out v3 with out this unrelated change.
>> {
>> int cpu;
>> struct cpufreq_policy cpu_policy;
>> @@ -603,15 +843,18 @@ static struct notifier_block powernv_cpufreq_opal_nb = {
>> static void powernv_cpufreq_stop_cpu(struct cpufreq_policy *policy)
>> {
>> struct powernv_smp_call_data freq_data;
>> -
>> + struct global_pstate_info *gpstates = policy->driver_data;
> You removed a blank line here and I feel the code looks better with
> that.
>
>> freq_data.pstate_id = powernv_pstate_info.min;
>> + freq_data.gpstate_id = powernv_pstate_info.min;
>> smp_call_function_single(policy->cpu, set_pstate, &freq_data, 1);
>> + del_timer_sync(&gpstates->timer);
>> }
>>
>> static struct cpufreq_driver powernv_cpufreq_driver = {
>> .name = "powernv-cpufreq",
>> .flags = CPUFREQ_CONST_LOOPS,
>> .init = powernv_cpufreq_cpu_init,
>> + .exit = powernv_cpufreq_cpu_exit,
>> .verify = cpufreq_generic_frequency_table_verify,
>> .target_index = powernv_cpufreq_target_index,
>> .get = powernv_cpufreq_get,
> None of the above comments are mandatory for you to fix..
>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
>
Thanks for Ack :)
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web