Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1381456 > unrolled thread
| Started by | Martin Kepplinger <martink@posteo.de> |
|---|---|
| First post | 2016-04-18 12:20 +0200 |
| Last post | 2016-04-20 00:50 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] rtc-pcf2123: use sign_extend32() for sign extension Martin Kepplinger <martink@posteo.de> - 2016-04-18 12:20 +0200
Re: [PATCH] rtc-pcf2123: use sign_extend32() for sign extension Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-04-20 00:50 +0200
| From | Martin Kepplinger <martink@posteo.de> |
|---|---|
| Date | 2016-04-18 12:20 +0200 |
| Subject | [PATCH] rtc-pcf2123: use sign_extend32() for sign extension |
| Message-ID | <rperD-3OG-3@gated-at.bofh.it> |
Signed-off-by: Martin Kepplinger <martink@posteo.de> --- drivers/rtc/rtc-pcf2123.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-pcf2123.c b/drivers/rtc/rtc-pcf2123.c index f22e060..b4478cc 100644 --- a/drivers/rtc/rtc-pcf2123.c +++ b/drivers/rtc/rtc-pcf2123.c @@ -96,7 +96,7 @@ #define CD_TMR_TE BIT(3) /* Countdown timer enable */ /* PCF2123_REG_OFFSET BITS */ -#define OFFSET_SIGN_BIT BIT(6) /* 2's complement sign bit */ +#define OFFSET_SIGN_BIT 6 /* 2's complement sign bit */ #define OFFSET_COARSE BIT(7) /* Coarse mode offset */ #define OFFSET_STEP (2170) /* Offset step in parts per billion */ @@ -217,7 +217,7 @@ static int pcf2123_read_offset(struct device *dev, long *offset) if (reg & OFFSET_COARSE) reg <<= 1; /* multiply by 2 and sign extend */ else - reg |= (reg & OFFSET_SIGN_BIT) << 1; /* sign extend only */ + reg = sign_extend32(reg, OFFSET_SIGN_BIT); *offset = ((long)reg) * OFFSET_STEP; -- 2.1.4
[toc] | [next] | [standalone]
| From | Alexandre Belloni <alexandre.belloni@free-electrons.com> |
|---|---|
| Date | 2016-04-20 00:50 +0200 |
| Message-ID | <rpMD0-65k-15@gated-at.bofh.it> |
| In reply to | #1381456 |
Please always include a commit message else, I'm fine with the patch. On 18/04/2016 at 12:17:44 +0200, Martin Kepplinger wrote : > Signed-off-by: Martin Kepplinger <martink@posteo.de> > --- > drivers/rtc/rtc-pcf2123.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/rtc/rtc-pcf2123.c b/drivers/rtc/rtc-pcf2123.c > index f22e060..b4478cc 100644 > --- a/drivers/rtc/rtc-pcf2123.c > +++ b/drivers/rtc/rtc-pcf2123.c > @@ -96,7 +96,7 @@ > #define CD_TMR_TE BIT(3) /* Countdown timer enable */ > > /* PCF2123_REG_OFFSET BITS */ > -#define OFFSET_SIGN_BIT BIT(6) /* 2's complement sign bit */ > +#define OFFSET_SIGN_BIT 6 /* 2's complement sign bit */ > #define OFFSET_COARSE BIT(7) /* Coarse mode offset */ > #define OFFSET_STEP (2170) /* Offset step in parts per billion */ > > @@ -217,7 +217,7 @@ static int pcf2123_read_offset(struct device *dev, long *offset) > if (reg & OFFSET_COARSE) > reg <<= 1; /* multiply by 2 and sign extend */ > else > - reg |= (reg & OFFSET_SIGN_BIT) << 1; /* sign extend only */ > + reg = sign_extend32(reg, OFFSET_SIGN_BIT); > > *offset = ((long)reg) * OFFSET_STEP; > > -- > 2.1.4 > -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web