Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1383076 > unrolled thread
| Started by | Andreas Werner <andreas.werner@men.de> |
|---|---|
| First post | 2016-04-20 08:40 +0200 |
| Last post | 2016-04-20 11:00 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] mcb: Fixed bar number assignment for the gdd Andreas Werner <andreas.werner@men.de> - 2016-04-20 08:40 +0200
Re: [PATCH] mcb: Fixed bar number assignment for the gdd Johannes Thumshirn <jthmshirn@suse.de> - 2016-04-20 11:00 +0200
| From | Andreas Werner <andreas.werner@men.de> |
|---|---|
| Date | 2016-04-20 08:40 +0200 |
| Subject | [PATCH] mcb: Fixed bar number assignment for the gdd |
| Message-ID | <rpTXQ-3o7-7@gated-at.bofh.it> |
The bar number is found in reg2 within the gdd. Therefore we need to change the assigment from reg1 to reg2 which is the correct location. Signed-off-by: Andreas Werner <andreas.werner@men.de> --- drivers/mcb/mcb-parse.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mcb/mcb-parse.c b/drivers/mcb/mcb-parse.c index 0049269..b0155b0 100644 --- a/drivers/mcb/mcb-parse.c +++ b/drivers/mcb/mcb-parse.c @@ -57,7 +57,7 @@ static int chameleon_parse_gdd(struct mcb_bus *bus, mdev->id = GDD_DEV(reg1); mdev->rev = GDD_REV(reg1); mdev->var = GDD_VAR(reg1); - mdev->bar = GDD_BAR(reg1); + mdev->bar = GDD_BAR(reg2); mdev->group = GDD_GRP(reg2); mdev->inst = GDD_INS(reg2); -- 2.6.2
[toc] | [next] | [standalone]
| From | Johannes Thumshirn <jthmshirn@suse.de> |
|---|---|
| Date | 2016-04-20 11:00 +0200 |
| Message-ID | <rpW9k-51U-25@gated-at.bofh.it> |
| In reply to | #1383076 |
On Wed, Apr 20, 2016 at 08:35:47AM +0200, Andreas Werner wrote: > The bar number is found in reg2 within the gdd. Therefore > we need to change the assigment from reg1 to reg2 which > is the correct location. > > Signed-off-by: Andreas Werner <andreas.werner@men.de> > --- > drivers/mcb/mcb-parse.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mcb/mcb-parse.c b/drivers/mcb/mcb-parse.c > index 0049269..b0155b0 100644 > --- a/drivers/mcb/mcb-parse.c > +++ b/drivers/mcb/mcb-parse.c > @@ -57,7 +57,7 @@ static int chameleon_parse_gdd(struct mcb_bus *bus, > mdev->id = GDD_DEV(reg1); > mdev->rev = GDD_REV(reg1); > mdev->var = GDD_VAR(reg1); > - mdev->bar = GDD_BAR(reg1); > + mdev->bar = GDD_BAR(reg2); > mdev->group = GDD_GRP(reg2); > mdev->inst = GDD_INS(reg2); > > -- > 2.6.2 > Applied, thanks. -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web