Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1383025 > unrolled thread

linux-next: manual merge of the usb-gadget tree with the usb-gadget-fixes tree

Back to article view | Back to linux.kernel

Contents

  linux-next: manual merge of the usb-gadget tree with the  usb-gadget-fixes tree Stephen Rothwell <sfr@canb.auug.org.au> - 2016-04-20 05:30 +0200

#1383025 — linux-next: manual merge of the usb-gadget tree with the usb-gadget-fixes tree

Hi Felipe,

Today's linux-next merge of the usb-gadget tree got a conflict in:

  drivers/usb/dwc3/debugfs.c

between commit:

  e6bdf8195b4a ("usb: dwc3: fix memory leak of dwc->regset")

from the usb-gadget-fixes tree and commit:

  4e9f311833a9 ("usb: dwc3: make dwc3_debugfs_init return value be void")

from the usb-gadget tree.

I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging.  You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.

-- 
Cheers,
Stephen Rothwell

diff --cc drivers/usb/dwc3/debugfs.c
index cebf9e38b60a,6c14f653dc9b..000000000000
--- a/drivers/usb/dwc3/debugfs.c
+++ b/drivers/usb/dwc3/debugfs.c
@@@ -661,29 -956,16 +956,14 @@@ void dwc3_debugfs_init(struct dwc3 *dwc
  			IS_ENABLED(CONFIG_USB_DWC3_GADGET)) {
  		file = debugfs_create_file("testmode", S_IRUGO | S_IWUSR, root,
  				dwc, &dwc3_testmode_fops);
- 		if (!file) {
- 			ret = -ENOMEM;
- 			goto err2;
- 		}
- 
- 		file = debugfs_create_file("link_state", S_IRUGO | S_IWUSR, root,
- 				dwc, &dwc3_link_state_fops);
- 		if (!file) {
- 			ret = -ENOMEM;
- 			goto err2;
- 		}
- 	}
 -		if (!file)
 -			dev_dbg(dwc->dev, "Can't create debugfs testmode\n");
  
- 	return 0;
+ 		file = debugfs_create_file("link_state", S_IRUGO | S_IWUSR,
+ 				root, dwc, &dwc3_link_state_fops);
+ 		if (!file)
+ 			dev_dbg(dwc->dev, "Can't create debugfs link_state\n");
  
- err2:
- 	kfree(dwc->regset);
- 
- err1:
- 	debugfs_remove_recursive(root);
- 
- err0:
- 	return ret;
+ 		dwc3_debugfs_create_endpoint_dirs(dwc, root);
+ 	}
  }
  
  void dwc3_debugfs_exit(struct dwc3 *dwc)

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web