Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1382809 > unrolled thread

Re: [PATCH v2 05/13] ARM: dts: db600c: add pmic regulator supplies

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v2 05/13] ARM: dts: db600c: add pmic regulator supplies Stephen Boyd <sboyd@codeaurora.org> - 2016-04-19 21:20 +0200
    Re: [PATCH v2 05/13] ARM: dts: db600c: add pmic regulator supplies Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2016-04-22 11:20 +0200

#1382809 — Re: [PATCH v2 05/13] ARM: dts: db600c: add pmic regulator supplies

On 04/12/2016 02:33 AM, Srinivas Kandagatla wrote:
> This patch adds pmic regulator supplies connected on the board.
> Rest of the invidual regulators would be added as and when required by
> the devices.
>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
>  arch/arm/boot/dts/qcom-apq8064-arrow-db600c.dts | 62 +++++++++++++++++++++++++
>  1 file changed, 62 insertions(+)
>
> diff --git a/arch/arm/boot/dts/qcom-apq8064-arrow-db600c.dts b/arch/arm/boot/dts/qcom-apq8064-arrow-db600c.dts
> index 57d4500..6695b00 100644
> --- a/arch/arm/boot/dts/qcom-apq8064-arrow-db600c.dts
> +++ b/arch/arm/boot/dts/qcom-apq8064-arrow-db600c.dts
> @@ -9,7 +9,69 @@
>  		serial1 = &gsbi1_serial;
>  	};
>  
> +	regulators {
> +		compatible = "simple-bus";
> +		vph: regulator-fixed@1 {
> +			compatible = "regulator-fixed";
> +			regulator-min-microvolt = <4500000>;
> +			regulator-max-microvolt = <4500000>;
> +			regulator-name = "VPH";
> +			regulator-type = "voltage";
> +			regulator-boot-on;
> +		};
> +	};

Just curious why we added the vph supply? Is that for some framework
requirement? We haven't done this on other boards, although we probably
should if there's a good reason for it.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

[toc] | [next] | [standalone]

#1384817

On 19/04/16 20:10, Stephen Boyd wrote:
> On 04/12/2016 02:33 AM, Srinivas Kandagatla wrote:
>> This patch adds pmic regulator supplies connected on the board.
>> Rest of the invidual regulators would be added as and when required by
>> the devices.
>>
>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>> Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>
>> ---
>>   arch/arm/boot/dts/qcom-apq8064-arrow-db600c.dts | 62 +++++++++++++++++++++++++
>>   1 file changed, 62 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/qcom-apq8064-arrow-db600c.dts b/arch/arm/boot/dts/qcom-apq8064-arrow-db600c.dts
>> index 57d4500..6695b00 100644
>> --- a/arch/arm/boot/dts/qcom-apq8064-arrow-db600c.dts
>> +++ b/arch/arm/boot/dts/qcom-apq8064-arrow-db600c.dts
>> @@ -9,7 +9,69 @@
>>   		serial1 = &gsbi1_serial;
>>   	};
>>
>> +	regulators {
>> +		compatible = "simple-bus";
>> +		vph: regulator-fixed@1 {
>> +			compatible = "regulator-fixed";
>> +			regulator-min-microvolt = <4500000>;
>> +			regulator-max-microvolt = <4500000>;
>> +			regulator-name = "VPH";
>> +			regulator-type = "voltage";
>> +			regulator-boot-on;
>> +		};
>> +	};
>
> Just curious why we added the vph supply? Is that for some framework
> requirement? We haven't done this on other boards, although we probably
> should if there's a good reason for it.

This is an on board 12V TO 4.5V @5.5A DC/DC convertor for PMIC VPH 
power. Yep we should do something similar on the other boards too. 
Without this probably you would notice some error messages from 
rpm_regulators about missing supply nodes.


thanks,
srini



>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web