Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1382773 > unrolled thread
| Started by | Grygorii Strashko <grygorii.strashko@ti.com> |
|---|---|
| First post | 2016-04-19 20:20 +0200 |
| Last post | 2016-04-21 20:40 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] drivers: net: cpsw: fix wrong regs access in cpsw_ndo_open Grygorii Strashko <grygorii.strashko@ti.com> - 2016-04-19 20:20 +0200
Re: [PATCH] drivers: net: cpsw: fix wrong regs access in cpsw_ndo_open David Miller <davem@davemloft.net> - 2016-04-21 20:40 +0200
| From | Grygorii Strashko <grygorii.strashko@ti.com> |
|---|---|
| Date | 2016-04-19 20:20 +0200 |
| Subject | [PATCH] drivers: net: cpsw: fix wrong regs access in cpsw_ndo_open |
| Message-ID | <rpIpI-2Fq-5@gated-at.bofh.it> |
The cpsw_ndo_open() could try to access CPSW registers before calling pm_runtime_get_sync(). This will trigger L3 error: WARNING: CPU: 0 PID: 21 at drivers/bus/omap_l3_noc.c:147 l3_interrupt_handler+0x220/0x34c() 44000000.ocp:L3 Custom Error: MASTER M2 (64-bit) TARGET L4_FAST (Idle): Data Access in Supervisor mode during Functional access and CPSW will stop functioning. Hence, fix it by moving pm_runtime_get_sync() before the first access to CPSW registers in cpsw_ndo_open(). Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com> --- drivers/net/ethernet/ti/cpsw.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c index 54bcc38..0fa75a8 100644 --- a/drivers/net/ethernet/ti/cpsw.c +++ b/drivers/net/ethernet/ti/cpsw.c @@ -1244,12 +1244,12 @@ static int cpsw_ndo_open(struct net_device *ndev) int i, ret; u32 reg; + pm_runtime_get_sync(&priv->pdev->dev); + if (!cpsw_common_res_usage_state(priv)) cpsw_intr_disable(priv); netif_carrier_off(ndev); - pm_runtime_get_sync(&priv->pdev->dev); - reg = priv->version; dev_info(priv->dev, "initializing cpsw version %d.%d (%d)\n", -- 2.8.1
[toc] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2016-04-21 20:40 +0200 |
| Subject | Re: [PATCH] drivers: net: cpsw: fix wrong regs access in cpsw_ndo_open |
| Message-ID | <rqrG9-5dC-5@gated-at.bofh.it> |
| In reply to | #1382773 |
From: Grygorii Strashko <grygorii.strashko@ti.com> Date: Tue, 19 Apr 2016 21:09:49 +0300 > The cpsw_ndo_open() could try to access CPSW registers before > calling pm_runtime_get_sync(). This will trigger L3 error: > > WARNING: CPU: 0 PID: 21 at drivers/bus/omap_l3_noc.c:147 l3_interrupt_handler+0x220/0x34c() > 44000000.ocp:L3 Custom Error: MASTER M2 (64-bit) TARGET L4_FAST (Idle): Data Access in Supervisor mode during Functional access > > and CPSW will stop functioning. > > Hence, fix it by moving pm_runtime_get_sync() before the first access > to CPSW registers in cpsw_ndo_open(). > > Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com> Applied, thanks.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web