Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1380295 > unrolled thread

Re: [PATCH] Documentation: clk: update file names containing referenced structures

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] Documentation: clk: update file names containing  referenced structures Jonathan Corbet <corbet@lwn.net> - 2016-04-15 23:50 +0200
    Re: [PATCH] Documentation: clk: update file names containing  referenced structures Andi Shyti <andi.shyti@samsung.com> - 2016-04-18 03:20 +0200

#1380295 — Re: [PATCH] Documentation: clk: update file names containing referenced structures

On Thu, 07 Apr 2016 11:48:53 +0900
Andi Shyti <andi.shyti@samsung.com> wrote:

> Commit 'b09d6d991' removes include/linux/clk-private.h and
> re-arranges the clock related structures contained in it in
> different files. The documentation has not been updated
> accordingly, thus it wasn't anymore consistent.
> 
> Place the structures referenced by Documentation/clk.txt in the
> correct files and update their contents to the latest status.
[...]
>  Below is the common struct clk definition from
> -include/linux/clk-private.h, modified for brevity:
> -
> -	struct clk {
> -		const char		*name;
> -		const struct clk_ops	*ops;
> -		struct clk_hw		*hw;
> -		char			**parent_names;
> -		struct clk		**parents;
> -		struct clk		*parent;
> -		struct hlist_head	children;
> -		struct hlist_node	child_node;
> +include/linux/clk.c, modified for brevity:
> +

Um...include/linux/clk.c?  We have 19 files named clk.c, but none of them
(unsurprisingly) are under include/ .  

The patch also seems to have a bunch of gratuitous white-space changes?

jon

[toc] | [next] | [standalone]

#1380882

> > Commit 'b09d6d991' removes include/linux/clk-private.h and
> > re-arranges the clock related structures contained in it in
> > different files. The documentation has not been updated
> > accordingly, thus it wasn't anymore consistent.
> > 
> > Place the structures referenced by Documentation/clk.txt in the
> > correct files and update their contents to the latest status.
> [...]
> >  Below is the common struct clk definition from
> > -include/linux/clk-private.h, modified for brevity:
> > -
> > -	struct clk {
> > -		const char		*name;
> > -		const struct clk_ops	*ops;
> > -		struct clk_hw		*hw;
> > -		char			**parent_names;
> > -		struct clk		**parents;
> > -		struct clk		*parent;
> > -		struct hlist_head	children;
> > -		struct hlist_node	child_node;
> > +include/linux/clk.c, modified for brevity:
> > +
> 
> Um...include/linux/clk.c?  We have 19 files named clk.c, but none of them
> (unsurprisingly) are under include/ .  
> 
> The patch also seems to have a bunch of gratuitous white-space changes?

yes, sorry, I put too little brain when I formatted it and I was 
too fast when I sent it... I will put a little more brain next
time :)

Thanks,
Andi

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web