Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1380371 > unrolled thread
| Started by | Vivien Didelot <vivien.didelot@savoirfairelinux.com> |
|---|---|
| First post | 2016-04-16 01:30 +0200 |
| Last post | 2016-04-16 01:40 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH net-next v2 1/7] net: dsa: mv88e6xxx: drop double ds assignment Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-04-16 01:30 +0200
Re: [PATCH net-next v2 1/7] net: dsa: mv88e6xxx: drop double ds assignment Andrew Lunn <andrew@lunn.ch> - 2016-04-16 01:40 +0200
| From | Vivien Didelot <vivien.didelot@savoirfairelinux.com> |
|---|---|
| Date | 2016-04-16 01:30 +0200 |
| Subject | [PATCH net-next v2 1/7] net: dsa: mv88e6xxx: drop double ds assignment |
| Message-ID | <rollw-2sf-9@gated-at.bofh.it> |
Every driver assigns ps->ds even though it gets assigned in the shared mv88e6xxx_setup_common function. Kill redundancy. Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com> --- drivers/net/dsa/mv88e6123.c | 2 -- drivers/net/dsa/mv88e6131.c | 2 -- drivers/net/dsa/mv88e6171.c | 2 -- drivers/net/dsa/mv88e6352.c | 2 -- 4 files changed, 8 deletions(-) diff --git a/drivers/net/dsa/mv88e6123.c b/drivers/net/dsa/mv88e6123.c index c34283d..88a812d 100644 --- a/drivers/net/dsa/mv88e6123.c +++ b/drivers/net/dsa/mv88e6123.c @@ -76,8 +76,6 @@ static int mv88e6123_setup(struct dsa_switch *ds) struct mv88e6xxx_priv_state *ps = ds_to_priv(ds); int ret; - ps->ds = ds; - ret = mv88e6xxx_setup_common(ds); if (ret < 0) return ret; diff --git a/drivers/net/dsa/mv88e6131.c b/drivers/net/dsa/mv88e6131.c index f5d75fc..6b2bcb0 100644 --- a/drivers/net/dsa/mv88e6131.c +++ b/drivers/net/dsa/mv88e6131.c @@ -94,8 +94,6 @@ static int mv88e6131_setup(struct dsa_switch *ds) struct mv88e6xxx_priv_state *ps = ds_to_priv(ds); int ret; - ps->ds = ds; - ret = mv88e6xxx_setup_common(ds); if (ret < 0) return ret; diff --git a/drivers/net/dsa/mv88e6171.c b/drivers/net/dsa/mv88e6171.c index f562250..40222b0 100644 --- a/drivers/net/dsa/mv88e6171.c +++ b/drivers/net/dsa/mv88e6171.c @@ -72,8 +72,6 @@ static int mv88e6171_setup(struct dsa_switch *ds) struct mv88e6xxx_priv_state *ps = ds_to_priv(ds); int ret; - ps->ds = ds; - ret = mv88e6xxx_setup_common(ds); if (ret < 0) return ret; diff --git a/drivers/net/dsa/mv88e6352.c b/drivers/net/dsa/mv88e6352.c index e54ee27..dbd920e 100644 --- a/drivers/net/dsa/mv88e6352.c +++ b/drivers/net/dsa/mv88e6352.c @@ -84,8 +84,6 @@ static int mv88e6352_setup(struct dsa_switch *ds) struct mv88e6xxx_priv_state *ps = ds_to_priv(ds); int ret; - ps->ds = ds; - ret = mv88e6xxx_setup_common(ds); if (ret < 0) return ret; -- 2.8.0
[toc] | [next] | [standalone]
| From | Andrew Lunn <andrew@lunn.ch> |
|---|---|
| Date | 2016-04-16 01:40 +0200 |
| Subject | Re: [PATCH net-next v2 1/7] net: dsa: mv88e6xxx: drop double ds assignment |
| Message-ID | <rolvb-2z2-3@gated-at.bofh.it> |
| In reply to | #1380371 |
On Fri, Apr 15, 2016 at 07:21:22PM -0400, Vivien Didelot wrote: > Every driver assigns ps->ds even though it gets assigned in the shared > mv88e6xxx_setup_common function. Kill redundancy. > > Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Thanks Andrew > --- > drivers/net/dsa/mv88e6123.c | 2 -- > drivers/net/dsa/mv88e6131.c | 2 -- > drivers/net/dsa/mv88e6171.c | 2 -- > drivers/net/dsa/mv88e6352.c | 2 -- > 4 files changed, 8 deletions(-) > > diff --git a/drivers/net/dsa/mv88e6123.c b/drivers/net/dsa/mv88e6123.c > index c34283d..88a812d 100644 > --- a/drivers/net/dsa/mv88e6123.c > +++ b/drivers/net/dsa/mv88e6123.c > @@ -76,8 +76,6 @@ static int mv88e6123_setup(struct dsa_switch *ds) > struct mv88e6xxx_priv_state *ps = ds_to_priv(ds); > int ret; > > - ps->ds = ds; > - > ret = mv88e6xxx_setup_common(ds); > if (ret < 0) > return ret; > diff --git a/drivers/net/dsa/mv88e6131.c b/drivers/net/dsa/mv88e6131.c > index f5d75fc..6b2bcb0 100644 > --- a/drivers/net/dsa/mv88e6131.c > +++ b/drivers/net/dsa/mv88e6131.c > @@ -94,8 +94,6 @@ static int mv88e6131_setup(struct dsa_switch *ds) > struct mv88e6xxx_priv_state *ps = ds_to_priv(ds); > int ret; > > - ps->ds = ds; > - > ret = mv88e6xxx_setup_common(ds); > if (ret < 0) > return ret; > diff --git a/drivers/net/dsa/mv88e6171.c b/drivers/net/dsa/mv88e6171.c > index f562250..40222b0 100644 > --- a/drivers/net/dsa/mv88e6171.c > +++ b/drivers/net/dsa/mv88e6171.c > @@ -72,8 +72,6 @@ static int mv88e6171_setup(struct dsa_switch *ds) > struct mv88e6xxx_priv_state *ps = ds_to_priv(ds); > int ret; > > - ps->ds = ds; > - > ret = mv88e6xxx_setup_common(ds); > if (ret < 0) > return ret; > diff --git a/drivers/net/dsa/mv88e6352.c b/drivers/net/dsa/mv88e6352.c > index e54ee27..dbd920e 100644 > --- a/drivers/net/dsa/mv88e6352.c > +++ b/drivers/net/dsa/mv88e6352.c > @@ -84,8 +84,6 @@ static int mv88e6352_setup(struct dsa_switch *ds) > struct mv88e6xxx_priv_state *ps = ds_to_priv(ds); > int ret; > > - ps->ds = ds; > - > ret = mv88e6xxx_setup_common(ds); > if (ret < 0) > return ret; > -- > 2.8.0 >
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web