Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1380286 > unrolled thread

Re: [PATCH] pci: xgene: Add ECAM fixups

Started byDuc Dang <dhdang@apm.com>
First post2016-04-15 23:40 +0200
Last post2016-04-16 09:50 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH] pci: xgene: Add ECAM fixups Duc Dang <dhdang@apm.com> - 2016-04-15 23:40 +0200
    Re: [PATCH] pci: xgene: Add ECAM fixups Arnd Bergmann <arnd@arndb.de> - 2016-04-16 09:50 +0200

#1380286 — Re: [PATCH] pci: xgene: Add ECAM fixups

FromDuc Dang <dhdang@apm.com>
Date2016-04-15 23:40 +0200
SubjectRe: [PATCH] pci: xgene: Add ECAM fixups
Message-ID<rojD3-1aP-5@gated-at.bofh.it>
On Wed, Feb 10, 2016 at 6:28 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Tuesday 09 February 2016 17:49:44 Duc Dang wrote:
>> X-Gene PCIe controller does not fully support ECAM.
>> This patch adds required ECAM fixup to allow X-Gene
>> PCIe controller to be functional in ACPI boot mode.
>>
>> This patch is based on the original work of
>> Mark Salter <msalter@redhat.com> and depends on
>> Tomasz's PCIe ACPI series:
>> https://lkml.org/lkml/2016/2/4/646
>>
>> Signed-off-by: Duc Dang <dhdang@apm.com>
>> ---
>
> This really has nothing to do with the PCI host device driver, please
> keep it in a separate file in drivers/acpi/.

Hi Arnd,

With Tomasz latest PCIe ACPI series
(https://lkml.org/lkml/2016/4/15/594), do you think it still better to
keep the ACPI ECAM fixup code in a separate file in drivers/acpi
directory?

Regards,
Duc Dang.

>
>         Arnd

[toc] | [next] | [standalone]


#1380499

FromArnd Bergmann <arnd@arndb.de>
Date2016-04-16 09:50 +0200
Message-ID<rot9o-8pE-3@gated-at.bofh.it>
In reply to#1380286
On Friday 15 April 2016 14:30:56 Duc Dang wrote:
> On Wed, Feb 10, 2016 at 6:28 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> > On Tuesday 09 February 2016 17:49:44 Duc Dang wrote:
> >> X-Gene PCIe controller does not fully support ECAM.
> >> This patch adds required ECAM fixup to allow X-Gene
> >> PCIe controller to be functional in ACPI boot mode.
> >>
> >> This patch is based on the original work of
> >> Mark Salter <msalter@redhat.com> and depends on
> >> Tomasz's PCIe ACPI series:
> >> https://lkml.org/lkml/2016/2/4/646
> >>
> >> Signed-off-by: Duc Dang <dhdang@apm.com>
> >> ---
> >
> > This really has nothing to do with the PCI host device driver, please
> > keep it in a separate file in drivers/acpi/.
> 
> Hi Arnd,
> 
> With Tomasz latest PCIe ACPI series
> (https://lkml.org/lkml/2016/4/15/594), do you think it still better to
> keep the ACPI ECAM fixup code in a separate file in drivers/acpi
> directory?

Yes, I made the same comment for the cavium PCI workaround in that
series.

	Arnd

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web