Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1379433 > unrolled thread
| Started by | Dan Williams <dan.j.williams@intel.com> |
|---|---|
| First post | 2016-04-15 04:50 +0200 |
| Last post | 2016-04-15 19:10 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] libnvdimm, btt: add btt startup debug Dan Williams <dan.j.williams@intel.com> - 2016-04-15 04:50 +0200
Re: [PATCH] libnvdimm, btt: add btt startup debug Johannes Thumshirn <jthumshirn@suse.de> - 2016-04-15 09:20 +0200
Re: [PATCH] libnvdimm, btt: add btt startup debug "Verma, Vishal L" <vishal.l.verma@intel.com> - 2016-04-15 19:10 +0200
| From | Dan Williams <dan.j.williams@intel.com> |
|---|---|
| Date | 2016-04-15 04:50 +0200 |
| Subject | [PATCH] libnvdimm, btt: add btt startup debug |
| Message-ID | <ro1Zv-41K-11@gated-at.bofh.it> |
Report the reason for btt probe failures when debug is enabled.
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
---
drivers/nvdimm/btt.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/nvdimm/btt.c b/drivers/nvdimm/btt.c
index cc9fafed9362..68a7c3c1eed9 100644
--- a/drivers/nvdimm/btt.c
+++ b/drivers/nvdimm/btt.c
@@ -1383,11 +1383,15 @@ int nvdimm_namespace_attach_btt(struct nd_namespace_common *ndns)
struct btt *btt;
size_t rawsize;
- if (!nd_btt->uuid || !nd_btt->ndns || !nd_btt->lbasize)
+ if (!nd_btt->uuid || !nd_btt->ndns || !nd_btt->lbasize) {
+ dev_dbg(&nd_btt->dev, "incomplete btt configuration\n");
return -ENODEV;
+ }
rawsize = nvdimm_namespace_capacity(ndns) - SZ_4K;
if (rawsize < ARENA_MIN_SIZE) {
+ dev_dbg(&nd_btt->dev, "%s must be at least %ld bytes\n",
+ dev_name(&ndns->dev), ARENA_MIN_SIZE + SZ_4K);
return -ENXIO;
}
nd_region = to_nd_region(nd_btt->dev.parent);
[toc] | [next] | [standalone]
| From | Johannes Thumshirn <jthumshirn@suse.de> |
|---|---|
| Date | 2016-04-15 09:20 +0200 |
| Message-ID | <ro6cO-7AZ-15@gated-at.bofh.it> |
| In reply to | #1379433 |
On Donnerstag, 14. April 2016 19:40:42 CEST Dan Williams wrote: > Report the reason for btt probe failures when debug is enabled. > > Signed-off-by: Dan Williams <dan.j.williams@intel.com> Looks good to me, Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de> -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
[toc] | [prev] | [next] | [standalone]
| From | "Verma, Vishal L" <vishal.l.verma@intel.com> |
|---|---|
| Date | 2016-04-15 19:10 +0200 |
| Message-ID | <rofpM-6tr-23@gated-at.bofh.it> |
| In reply to | #1379433 |
On Thu, 2016-04-14 at 19:40 -0700, Dan Williams wrote:
> Report the reason for btt probe failures when debug is enabled.
>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> ---
> drivers/nvdimm/btt.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
Reveiwed-by: Vishal Verma <Vishal.l.verma@intel.com>
>
> diff --git a/drivers/nvdimm/btt.c b/drivers/nvdimm/btt.c
> index cc9fafed9362..68a7c3c1eed9 100644
> --- a/drivers/nvdimm/btt.c
> +++ b/drivers/nvdimm/btt.c
> @@ -1383,11 +1383,15 @@ int nvdimm_namespace_attach_btt(struct
> nd_namespace_common *ndns)
> struct btt *btt;
> size_t rawsize;
>
> - if (!nd_btt->uuid || !nd_btt->ndns || !nd_btt->lbasize)
> + if (!nd_btt->uuid || !nd_btt->ndns || !nd_btt->lbasize) {
> + dev_dbg(&nd_btt->dev, "incomplete btt
> configuration\n");
> return -ENODEV;
> + }
>
> rawsize = nvdimm_namespace_capacity(ndns) - SZ_4K;
> if (rawsize < ARENA_MIN_SIZE) {
> + dev_dbg(&nd_btt->dev, "%s must be at least %ld
> bytes\n",
> + dev_name(&ndns->dev), ARENA_MIN_SIZE
> + SZ_4K);
> return -ENXIO;
> }
> nd_region = to_nd_region(nd_btt->dev.parent);
>
> _______________________________________________
> Linux-nvdimm mailing list
> Linux-nvdimm@lists.01.org
> https://lists.01.org/mailman/listinfo/linux-nvdimm
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web