Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1380591 > unrolled thread

Re: [PATCH 2/2] iio: adc: set INPUT_PROP_DIRECT

Started byJonathan Cameron <jic23@kernel.org>
First post2016-04-16 21:30 +0200
Last post2016-04-17 11:50 +0200
Articles 3 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH 2/2] iio: adc: set INPUT_PROP_DIRECT Jonathan Cameron <jic23@kernel.org> - 2016-04-16 21:30 +0200
    Re: [PATCH 2/2] iio: adc: set INPUT_PROP_DIRECT Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-04-17 11:40 +0200
      Re: [PATCH 2/2] iio: adc: set INPUT_PROP_DIRECT Jonathan Cameron <jic23@kernel.org> - 2016-04-17 11:50 +0200

#1380591 — Re: [PATCH 2/2] iio: adc: set INPUT_PROP_DIRECT

FromJonathan Cameron <jic23@kernel.org>
Date2016-04-16 21:30 +0200
SubjectRe: [PATCH 2/2] iio: adc: set INPUT_PROP_DIRECT
Message-ID<roE4O-bD-3@gated-at.bofh.it>
On 10/04/16 20:22, Ksenija Stanojevic wrote:
> Set INPUT_PROP_DIRECT to indicate that it is a touchscreen on the
> device to help userspace classify it.
> 
> Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
Sounds correct to me.  Dmitry?
> ---
>  drivers/iio/adc/mxs-lradc.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/iio/adc/mxs-lradc.c b/drivers/iio/adc/mxs-lradc.c
> index 07287af..e4c4c5c 100644
> --- a/drivers/iio/adc/mxs-lradc.c
> +++ b/drivers/iio/adc/mxs-lradc.c
> @@ -1127,6 +1127,7 @@ static int mxs_lradc_ts_register(struct mxs_lradc *lradc)
>  	__set_bit(EV_ABS, input->evbit);
>  	__set_bit(EV_KEY, input->evbit);
>  	__set_bit(BTN_TOUCH, input->keybit);
> +	__set_bit(INPUT_PROP_DIRECT, input->propbit);
>  	input_set_abs_params(input, ABS_X, 0, LRADC_SINGLE_SAMPLE_MASK, 0, 0);
>  	input_set_abs_params(input, ABS_Y, 0, LRADC_SINGLE_SAMPLE_MASK, 0, 0);
>  	input_set_abs_params(input, ABS_PRESSURE, 0, LRADC_SINGLE_SAMPLE_MASK,
> 

[toc] | [next] | [standalone]


#1380721

FromDmitry Torokhov <dmitry.torokhov@gmail.com>
Date2016-04-17 11:40 +0200
Message-ID<roRln-21m-1@gated-at.bofh.it>
In reply to#1380591
On Sat, Apr 16, 2016 at 08:26:48PM +0100, Jonathan Cameron wrote:
> On 10/04/16 20:22, Ksenija Stanojevic wrote:
> > Set INPUT_PROP_DIRECT to indicate that it is a touchscreen on the
> > device to help userspace classify it.
> > 
> > Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
> Sounds correct to me.  Dmitry?

Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

> > ---
> >  drivers/iio/adc/mxs-lradc.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/iio/adc/mxs-lradc.c b/drivers/iio/adc/mxs-lradc.c
> > index 07287af..e4c4c5c 100644
> > --- a/drivers/iio/adc/mxs-lradc.c
> > +++ b/drivers/iio/adc/mxs-lradc.c
> > @@ -1127,6 +1127,7 @@ static int mxs_lradc_ts_register(struct mxs_lradc *lradc)
> >  	__set_bit(EV_ABS, input->evbit);
> >  	__set_bit(EV_KEY, input->evbit);
> >  	__set_bit(BTN_TOUCH, input->keybit);
> > +	__set_bit(INPUT_PROP_DIRECT, input->propbit);
> >  	input_set_abs_params(input, ABS_X, 0, LRADC_SINGLE_SAMPLE_MASK, 0, 0);
> >  	input_set_abs_params(input, ABS_Y, 0, LRADC_SINGLE_SAMPLE_MASK, 0, 0);
> >  	input_set_abs_params(input, ABS_PRESSURE, 0, LRADC_SINGLE_SAMPLE_MASK,
> > 
> 

-- 
Dmitry

[toc] | [prev] | [next] | [standalone]


#1380724

FromJonathan Cameron <jic23@kernel.org>
Date2016-04-17 11:50 +0200
Message-ID<roRv4-24R-5@gated-at.bofh.it>
In reply to#1380721
On 17/04/16 10:33, Dmitry Torokhov wrote:
> On Sat, Apr 16, 2016 at 08:26:48PM +0100, Jonathan Cameron wrote:
>> On 10/04/16 20:22, Ksenija Stanojevic wrote:
>>> Set INPUT_PROP_DIRECT to indicate that it is a touchscreen on the
>>> device to help userspace classify it.
>>>
>>> Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
>> Sounds correct to me.  Dmitry?
> 
> Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Applied to the togreg branch of iio.git - initially pushed out
as testing for the autobuilders to mess with it.

Thanks,

Jonathan
> 
>>> ---
>>>  drivers/iio/adc/mxs-lradc.c | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/iio/adc/mxs-lradc.c b/drivers/iio/adc/mxs-lradc.c
>>> index 07287af..e4c4c5c 100644
>>> --- a/drivers/iio/adc/mxs-lradc.c
>>> +++ b/drivers/iio/adc/mxs-lradc.c
>>> @@ -1127,6 +1127,7 @@ static int mxs_lradc_ts_register(struct mxs_lradc *lradc)
>>>  	__set_bit(EV_ABS, input->evbit);
>>>  	__set_bit(EV_KEY, input->evbit);
>>>  	__set_bit(BTN_TOUCH, input->keybit);
>>> +	__set_bit(INPUT_PROP_DIRECT, input->propbit);
>>>  	input_set_abs_params(input, ABS_X, 0, LRADC_SINGLE_SAMPLE_MASK, 0, 0);
>>>  	input_set_abs_params(input, ABS_Y, 0, LRADC_SINGLE_SAMPLE_MASK, 0, 0);
>>>  	input_set_abs_params(input, ABS_PRESSURE, 0, LRADC_SINGLE_SAMPLE_MASK,
>>>
>>
> 

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web