Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1380613 > unrolled thread

[PATCH] pinctrl: imx: select regmap subsystem

Back to article view | Back to linux.kernel

Contents

  [PATCH] pinctrl: imx: select regmap subsystem Arnd Bergmann <arnd@arndb.de> - 2016-04-16 22:30 +0200
    Re: [PATCH] pinctrl: imx: select regmap subsystem Shawn Guo <shawnguo@kernel.org> - 2016-04-18 03:50 +0200

#1380613 — [PATCH] pinctrl: imx: select regmap subsystem

Building the imx pinctrl driver without regmap fails with multiple
build errors like:

drivers/pinctrl/freescale/pinctrl-imx.c: In function 'imx_pinctrl_probe':
drivers/pinctrl/freescale/pinctrl-imx.c:723:9: error: variable 'config' has initializer but incomplete type
  struct regmap_config config = { .name = "gpr" };

This adds a 'select REGMAP' statement, to ensure we can define a 'struct
regmap_config'. This matches what all other regmap users do. The driver
actually uses syscon on top of regmap, but syscon is already enabled
on i.MX for other reasons, and selecting REGMAP but not SYSCON is
sufficient for build testing on other platforms.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 8626ada871f1 ("pinctrl: imx: attach iomuxc device to gpr syscon")
---
 drivers/pinctrl/freescale/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pinctrl/freescale/Kconfig b/drivers/pinctrl/freescale/Kconfig
index debe1219d76d..fc8cbf611723 100644
--- a/drivers/pinctrl/freescale/Kconfig
+++ b/drivers/pinctrl/freescale/Kconfig
@@ -2,6 +2,7 @@ config PINCTRL_IMX
 	bool
 	select PINMUX
 	select PINCONF
+	select REGMAP
 
 config PINCTRL_IMX1_CORE
 	bool
-- 
2.7.0

[toc] | [next] | [standalone]

#1380889

On Sat, Apr 16, 2016 at 10:26:06PM +0200, Arnd Bergmann wrote:
> Building the imx pinctrl driver without regmap fails with multiple
> build errors like:
> 
> drivers/pinctrl/freescale/pinctrl-imx.c: In function 'imx_pinctrl_probe':
> drivers/pinctrl/freescale/pinctrl-imx.c:723:9: error: variable 'config' has initializer but incomplete type
>   struct regmap_config config = { .name = "gpr" };
> 
> This adds a 'select REGMAP' statement, to ensure we can define a 'struct
> regmap_config'. This matches what all other regmap users do. The driver
> actually uses syscon on top of regmap, but syscon is already enabled
> on i.MX for other reasons, and selecting REGMAP but not SYSCON is
> sufficient for build testing on other platforms.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 8626ada871f1 ("pinctrl: imx: attach iomuxc device to gpr syscon")

LinusW already applied a similar patch [1] from Alexander a few days
ago.

Shawn

[1] http://thread.gmane.org/gmane.linux.kernel.gpio/16054

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web