Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1375859 > unrolled thread
| Started by | William Breathitt Gray <vilhelm.gray@gmail.com> |
|---|---|
| First post | 2016-04-11 15:30 +0200 |
| Last post | 2016-04-13 17:20 +0200 |
| Articles | 6 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH 0/4] Decouple X86_32 dependency from the ISA Kconfig option William Breathitt Gray <vilhelm.gray@gmail.com> - 2016-04-11 15:30 +0200
Re: [PATCH 0/4] Decouple X86_32 dependency from the ISA Kconfig option Ingo Molnar <mingo@kernel.org> - 2016-04-13 09:30 +0200
Re: [PATCH 0/4] Decouple X86_32 dependency from the ISA Kconfig option William Breathitt Gray <vilhelm.gray@gmail.com> - 2016-04-13 14:20 +0200
Re: [PATCH 0/4] Decouple X86_32 dependency from the ISA Kconfig option Ingo Molnar <mingo@kernel.org> - 2016-04-13 16:40 +0200
Re: [PATCH 0/4] Decouple X86_32 dependency from the ISA Kconfig option William Breathitt Gray <vilhelm.gray@gmail.com> - 2016-04-13 16:50 +0200
Re: [PATCH 0/4] Decouple X86_32 dependency from the ISA Kconfig option Greg KH <gregkh@linuxfoundation.org> - 2016-04-13 17:20 +0200
| From | William Breathitt Gray <vilhelm.gray@gmail.com> |
|---|---|
| Date | 2016-04-11 15:30 +0200 |
| Subject | [PATCH 0/4] Decouple X86_32 dependency from the ISA Kconfig option |
| Message-ID | <rmK4G-6zt-15@gated-at.bofh.it> |
This patchset is based on top of commit 3a3a5fece6f2 ("fs: kernfs: Replace
CURRENT_TIME by current_fs_time()") of the driver-core-testing branch of
the driver-core repository.
The introduction of the ISA_BUS option in commit b3c1be1b789c
("base: isa: Remove X86_32 dependency") blocks the compilation of ISA
drivers on non-x86 platforms. The ISA_BUS configuration option should not
be necessary if the X86_32 dependency can be decoupled from the ISA
configuration option. This patchset both removes the ISA_BUS configuration
option entirely and decouples the X86_32 dependency from the ISA
configuration option.
The PNPBIOS driver requires preprocessor defines (located in
include/asm/segment.h) only declared if the architecture is set to X86_32.
If the architecture is set to X86_64, the PNPBIOS driver will not build
properly. The X86 dependecy for the PNPBIOS configuration option is changed
to an explicit X86_32 dependency in order to prevent an attempt to build
for an unsupported architecture.
Changes to the ISA SSCAPE and SCSI ULTRASTOR drivers are also included. The
relevant patches simply fix format string identifier mismatches exposed
during an attempted X86_64 compilation after the decoupling of the X86_32
dependency from the ISA configuration option. These patches fix compilation
warnings rather than errors, but the solutions were so trivial that I
decided to include them in this patchset. If it would be inappropriate to
include them in this patchset, let me know and I will rebase to remove the
relevant patches.
William Breathitt Gray (4):
pnp: pnpbios: Add explicit X86_32 dependency to PNPBIOS
sound: isa: sscape: Use correct format identifier for size_t
scsi: ultrastor: Use correct format identifier for kernel pointer
isa: Remove the ISA_BUS Kconfig option
arch/x86/Kconfig | 10 ++--------
drivers/base/Makefile | 2 +-
drivers/pnp/pnpbios/Kconfig | 2 +-
drivers/scsi/ultrastor.c | 8 ++++----
include/linux/isa.h | 2 +-
sound/isa/sscape.c | 2 +-
6 files changed, 10 insertions(+), 16 deletions(-)
--
2.7.3
[toc] | [next] | [standalone]
| From | Ingo Molnar <mingo@kernel.org> |
|---|---|
| Date | 2016-04-13 09:30 +0200 |
| Subject | Re: [PATCH 0/4] Decouple X86_32 dependency from the ISA Kconfig option |
| Message-ID | <rnnpo-5TB-19@gated-at.bofh.it> |
| In reply to | #1375859 |
* William Breathitt Gray <vilhelm.gray@gmail.com> wrote:
> This patchset is based on top of commit 3a3a5fece6f2 ("fs: kernfs: Replace
> CURRENT_TIME by current_fs_time()") of the driver-core-testing branch of
> the driver-core repository.
>
> The introduction of the ISA_BUS option in commit b3c1be1b789c
> ("base: isa: Remove X86_32 dependency") blocks the compilation of ISA
> drivers on non-x86 platforms. The ISA_BUS configuration option should not
> be necessary if the X86_32 dependency can be decoupled from the ISA
> configuration option. This patchset both removes the ISA_BUS configuration
> option entirely and decouples the X86_32 dependency from the ISA
> configuration option.
>
> The PNPBIOS driver requires preprocessor defines (located in
> include/asm/segment.h) only declared if the architecture is set to X86_32.
> If the architecture is set to X86_64, the PNPBIOS driver will not build
> properly. The X86 dependecy for the PNPBIOS configuration option is changed
> to an explicit X86_32 dependency in order to prevent an attempt to build
> for an unsupported architecture.
>
> Changes to the ISA SSCAPE and SCSI ULTRASTOR drivers are also included. The
> relevant patches simply fix format string identifier mismatches exposed
> during an attempted X86_64 compilation after the decoupling of the X86_32
> dependency from the ISA configuration option. These patches fix compilation
> warnings rather than errors, but the solutions were so trivial that I
> decided to include them in this patchset. If it would be inappropriate to
> include them in this patchset, let me know and I will rebase to remove the
> relevant patches.
>
> William Breathitt Gray (4):
> pnp: pnpbios: Add explicit X86_32 dependency to PNPBIOS
> sound: isa: sscape: Use correct format identifier for size_t
> scsi: ultrastor: Use correct format identifier for kernel pointer
> isa: Remove the ISA_BUS Kconfig option
>
> arch/x86/Kconfig | 10 ++--------
> drivers/base/Makefile | 2 +-
> drivers/pnp/pnpbios/Kconfig | 2 +-
> drivers/scsi/ultrastor.c | 8 ++++----
> include/linux/isa.h | 2 +-
> sound/isa/sscape.c | 2 +-
> 6 files changed, 10 insertions(+), 16 deletions(-)
What's the practical motivation of this? What exact hardware is this for?
Thanks,
Ingo
[toc] | [prev] | [next] | [standalone]
| From | William Breathitt Gray <vilhelm.gray@gmail.com> |
|---|---|
| Date | 2016-04-13 14:20 +0200 |
| Subject | Re: [PATCH 0/4] Decouple X86_32 dependency from the ISA Kconfig option |
| Message-ID | <rnrW2-15F-9@gated-at.bofh.it> |
| In reply to | #1377588 |
On Wed, Apr 13, 2016 at 09:26:02AM +0200, Ingo Molnar wrote: >What's the practical motivation of this? What exact hardware is this for? > >Thanks, > > Ingo The PC/104 bus is equivalent to the ISA bus regarding software communication. Many small form factor systems have a PC/104 bus where PC/104 cards may be stacked. Nowadays, these systems are commonly running 64-bit processors such as the Intel Atom. I would like to utilize the ISA bus driver to support these PC/104 devices (see http://lkml.org/lkml/2016/4/7/418), but the ISA configuration option has an arbitrary X86_32 dependency. Decoupling the X86_32 dependency from the ISA configuration option will allow these PC/104 drivers to build for 64-bit architectures. The existing kernel drivers which I intend to utilize the ISA bus driver in a X86_64 architecture for PC/104 support are the ACCES 104-DIO-48E GPIO driver, the ACCES 104-IDI-48 GPIO driver, the ACCES 104-IDIO-16 GPIO driver, and the Apex Embedded Systems STX104 DAC driver. I have several more PC/104 devices for which I wish to write drivers, but I would like to resolve this ISA bus driver situation before submitting new code. William Breathitt Gray
[toc] | [prev] | [next] | [standalone]
| From | Ingo Molnar <mingo@kernel.org> |
|---|---|
| Date | 2016-04-13 16:40 +0200 |
| Subject | Re: [PATCH 0/4] Decouple X86_32 dependency from the ISA Kconfig option |
| Message-ID | <rnu7w-2D7-17@gated-at.bofh.it> |
| In reply to | #1377881 |
* William Breathitt Gray <vilhelm.gray@gmail.com> wrote: > On Wed, Apr 13, 2016 at 09:26:02AM +0200, Ingo Molnar wrote: > >What's the practical motivation of this? What exact hardware is this for? > > > >Thanks, > > > > Ingo > > The PC/104 bus is equivalent to the ISA bus regarding software > communication. Many small form factor systems have a PC/104 bus where > PC/104 cards may be stacked. Nowadays, these systems are commonly > running 64-bit processors such as the Intel Atom. > > I would like to utilize the ISA bus driver to support these PC/104 > devices (see http://lkml.org/lkml/2016/4/7/418), but the ISA > configuration option has an arbitrary X86_32 dependency. Decoupling the > X86_32 dependency from the ISA configuration option will allow these > PC/104 drivers to build for 64-bit architectures. > > The existing kernel drivers which I intend to utilize the ISA bus driver > in a X86_64 architecture for PC/104 support are the ACCES 104-DIO-48E > GPIO driver, the ACCES 104-IDI-48 GPIO driver, the ACCES 104-IDIO-16 > GPIO driver, and the Apex Embedded Systems STX104 DAC driver. I have > several more PC/104 devices for which I wish to write drivers, but I > would like to resolve this ISA bus driver situation before submitting > new code. Ah, ok, so it's for enabling real hardware, not just a cleanup, right? You might want to put that info into the boilerplate mail or so. I'm perfectly fine with all the patches that touch x86 code: Acked-by: Ingo Molnar <mingo@kernel.org> I suppose you'd like to have these in the driver tree, all in one place? Thanks, Ingo
[toc] | [prev] | [next] | [standalone]
| From | William Breathitt Gray <vilhelm.gray@gmail.com> |
|---|---|
| Date | 2016-04-13 16:50 +0200 |
| Subject | Re: [PATCH 0/4] Decouple X86_32 dependency from the ISA Kconfig option |
| Message-ID | <rnuhc-2Hz-33@gated-at.bofh.it> |
| In reply to | #1377994 |
On Wed, Apr 13, 2016 at 04:38:38PM +0200, Ingo Molnar wrote: >Ah, ok, so it's for enabling real hardware, not just a cleanup, right? You might >want to put that info into the boilerplate mail or so. > >I'm perfectly fine with all the patches that touch x86 code: > > Acked-by: Ingo Molnar <mingo@kernel.org> > >I suppose you'd like to have these in the driver tree, all in one place? > >Thanks, > > Ingo Ah yes, in retrospect I should have made it clear that this was for supporting hardware rather than simply code cleanup. That was an oversight on my part not to have made it more explicit. Introducing everything to the driver tree would be most convenient, thus allowing me to quickly release my subsequent patches which will be rebased on top of these. William Breathitt Gray
[toc] | [prev] | [next] | [standalone]
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2016-04-13 17:20 +0200 |
| Subject | Re: [PATCH 0/4] Decouple X86_32 dependency from the ISA Kconfig option |
| Message-ID | <rnuKd-3cP-3@gated-at.bofh.it> |
| In reply to | #1378011 |
On Wed, Apr 13, 2016 at 10:48:42AM -0400, William Breathitt Gray wrote: > On Wed, Apr 13, 2016 at 04:38:38PM +0200, Ingo Molnar wrote: > >Ah, ok, so it's for enabling real hardware, not just a cleanup, right? You might > >want to put that info into the boilerplate mail or so. > > > >I'm perfectly fine with all the patches that touch x86 code: > > > > Acked-by: Ingo Molnar <mingo@kernel.org> > > > >I suppose you'd like to have these in the driver tree, all in one place? > > > >Thanks, > > > > Ingo > > Ah yes, in retrospect I should have made it clear that this was for > supporting hardware rather than simply code cleanup. That was an > oversight on my part not to have made it more explicit. > > Introducing everything to the driver tree would be most convenient, thus > allowing me to quickly release my subsequent patches which will be > rebased on top of these. Ok, I can take these. thanks, greg k-h
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web