Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1377133 > unrolled thread

Re: [PATCH] arm64/sunxi: 4.6-rc1: Add dependency on generic irq chip

Started byOlof Johansson <olof@lixom.net>
First post2016-04-12 21:40 +0200
Last post2016-04-13 15:30 +0200
Articles 4 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] arm64/sunxi: 4.6-rc1: Add dependency on generic irq chip Olof Johansson <olof@lixom.net> - 2016-04-12 21:40 +0200
    Re: [PATCH] arm64/sunxi: 4.6-rc1: Add dependency on generic irq chip Suzuki K Poulose <Suzuki.Poulose@arm.com> - 2016-04-13 11:10 +0200
      Re: [PATCH] arm64/sunxi: 4.6-rc1: Add dependency on generic irq chip Rob Herring <robh@kernel.org> - 2016-04-13 15:20 +0200
        Re: [PATCH] arm64/sunxi: 4.6-rc1: Add dependency on generic irq chip Suzuki K Poulose <Suzuki.Poulose@arm.com> - 2016-04-13 15:30 +0200

#1377133 — Re: [PATCH] arm64/sunxi: 4.6-rc1: Add dependency on generic irq chip

FromOlof Johansson <olof@lixom.net>
Date2016-04-12 21:40 +0200
SubjectRe: [PATCH] arm64/sunxi: 4.6-rc1: Add dependency on generic irq chip
Message-ID<rnckj-4di-31@gated-at.bofh.it>
On Tue, Mar 29, 2016 at 11:03:06AM +0100, Suzuki K Poulose wrote:
> Commit ce3dd55b99b1 ("arm64: Introduce Allwinner SoC config option"),
> added support for ARCH_SUNXI on arm64, but failed to select
> GENERIC_IRQ_CHIP, which is required for drivers/irqchip/irq-sunxi-nmi.c
> and causes build failures like :
> 
>   UPD     include/generated/compile.h
>   CC      init/version.o
>   LD      init/built-in.o
> drivers/built-in.o: In function `sunxi_sc_nmi_set_type':
> drivers/irqchip/irq-sunxi-nmi.c:114: undefined reference to `irq_setup_alt_chip'
> drivers/built-in.o: In function `irq_domain_add_linear':
> include/linux/irqdomain.h:253: undefined reference to `irq_generic_chip_ops'
> include/linux/irqdomain.h:253: undefined reference to `irq_generic_chip_ops'
> drivers/built-in.o: In function `sunxi_sc_nmi_irq_init':
> drivers/irqchip/irq-sunxi-nmi.c:146: undefined reference to `irq_alloc_domain_generic_chips'
> drivers/irqchip/irq-sunxi-nmi.c:161: undefined reference to `irq_get_domain_generic_chip'
> drivers/irqchip/irq-sunxi-nmi.c:170: undefined reference to `irq_gc_mask_clr_bit'
> drivers/irqchip/irq-sunxi-nmi.c:171: undefined reference to `irq_gc_mask_set_bit'
> drivers/irqchip/irq-sunxi-nmi.c:172: undefined reference to `irq_gc_ack_set_bit'
> drivers/irqchip/irq-sunxi-nmi.c:170: undefined reference to `irq_gc_mask_clr_bit'
> 
> Fixes: commit ce3dd55b99b1 ("arm64: Introduce Allwinner SoC config option")
> Cc: Andre Przywara <andre.przywara@arm.com>
> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>

It'd be nice to have a silent Kconfig entry that selects from ARCH_SUNXI that
sets this dependency, instead of having it from the architecture code. This
pushes down the dependency to the right level.

Can you respin with it like that instead?


-Olof

[toc] | [next] | [standalone]

#1377672

FromSuzuki K Poulose <Suzuki.Poulose@arm.com>
Date2016-04-13 11:10 +0200
Message-ID<rnoYa-7qk-15@gated-at.bofh.it>
In reply to#1377133
On 12/04/16 20:11, Olof Johansson wrote:
> On Tue, Mar 29, 2016 at 11:03:06AM +0100, Suzuki K Poulose wrote:
>> Commit ce3dd55b99b1 ("arm64: Introduce Allwinner SoC config option"),
>> added support for ARCH_SUNXI on arm64, but failed to select
>> GENERIC_IRQ_CHIP, which is required for drivers/irqchip/irq-sunxi-nmi.c
>> and causes build failures like :
>>
>>    UPD     include/generated/compile.h
>>    CC      init/version.o
>>    LD      init/built-in.o
>> drivers/built-in.o: In function `sunxi_sc_nmi_set_type':
>> drivers/irqchip/irq-sunxi-nmi.c:114: undefined reference to `irq_setup_alt_chip'
>> drivers/built-in.o: In function `irq_domain_add_linear':
>> include/linux/irqdomain.h:253: undefined reference to `irq_generic_chip_ops'
>> include/linux/irqdomain.h:253: undefined reference to `irq_generic_chip_ops'
>> drivers/built-in.o: In function `sunxi_sc_nmi_irq_init':
>> drivers/irqchip/irq-sunxi-nmi.c:146: undefined reference to `irq_alloc_domain_generic_chips'
>> drivers/irqchip/irq-sunxi-nmi.c:161: undefined reference to `irq_get_domain_generic_chip'
>> drivers/irqchip/irq-sunxi-nmi.c:170: undefined reference to `irq_gc_mask_clr_bit'
>> drivers/irqchip/irq-sunxi-nmi.c:171: undefined reference to `irq_gc_mask_set_bit'
>> drivers/irqchip/irq-sunxi-nmi.c:172: undefined reference to `irq_gc_ack_set_bit'
>> drivers/irqchip/irq-sunxi-nmi.c:170: undefined reference to `irq_gc_mask_clr_bit'
>>
>> Fixes: commit ce3dd55b99b1 ("arm64: Introduce Allwinner SoC config option")
>> Cc: Andre Przywara <andre.przywara@arm.com>
>> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
>
> It'd be nice to have a silent Kconfig entry that selects from ARCH_SUNXI that
> sets this dependency, instead of having it from the architecture code. This
> pushes down the dependency to the right level.

Do you mean something like :
config ARCH_SUNXI
  	...
	select SUNXI_PLATFORM

And have

config SUNXI_PLATFORM
	select SUNXI_DEPENDENCY_1
	select SUNXI_DEPENDENCY_2

where SUNXI_PLATFORM drives the dependencies for both ARM and ARM64 ?

If so, where would you like SUNXI_PLATFORM to reside ? drivers/platform ?
Also, AFAIK, the arm64 port doesn't have the full support for the required
bits for SUNXI yet, which could be handled in the common place with ( && !ARM64).

Andre, please feel free to correct my assessment above.


Thanks
Suzuki

[toc] | [prev] | [next] | [standalone]

#1377919

FromRob Herring <robh@kernel.org>
Date2016-04-13 15:20 +0200
Message-ID<rnsS5-1JU-1@gated-at.bofh.it>
In reply to#1377672
On Wed, Apr 13, 2016 at 4:05 AM, Suzuki K Poulose
<Suzuki.Poulose@arm.com> wrote:
> On 12/04/16 20:11, Olof Johansson wrote:
>>
>> On Tue, Mar 29, 2016 at 11:03:06AM +0100, Suzuki K Poulose wrote:
>>>
>>> Commit ce3dd55b99b1 ("arm64: Introduce Allwinner SoC config option"),
>>> added support for ARCH_SUNXI on arm64, but failed to select
>>> GENERIC_IRQ_CHIP, which is required for drivers/irqchip/irq-sunxi-nmi.c
>>> and causes build failures like :
>>>
>>>    UPD     include/generated/compile.h
>>>    CC      init/version.o
>>>    LD      init/built-in.o
>>> drivers/built-in.o: In function `sunxi_sc_nmi_set_type':
>>> drivers/irqchip/irq-sunxi-nmi.c:114: undefined reference to
>>> `irq_setup_alt_chip'
>>> drivers/built-in.o: In function `irq_domain_add_linear':
>>> include/linux/irqdomain.h:253: undefined reference to
>>> `irq_generic_chip_ops'
>>> include/linux/irqdomain.h:253: undefined reference to
>>> `irq_generic_chip_ops'
>>> drivers/built-in.o: In function `sunxi_sc_nmi_irq_init':
>>> drivers/irqchip/irq-sunxi-nmi.c:146: undefined reference to
>>> `irq_alloc_domain_generic_chips'
>>> drivers/irqchip/irq-sunxi-nmi.c:161: undefined reference to
>>> `irq_get_domain_generic_chip'
>>> drivers/irqchip/irq-sunxi-nmi.c:170: undefined reference to
>>> `irq_gc_mask_clr_bit'
>>> drivers/irqchip/irq-sunxi-nmi.c:171: undefined reference to
>>> `irq_gc_mask_set_bit'
>>> drivers/irqchip/irq-sunxi-nmi.c:172: undefined reference to
>>> `irq_gc_ack_set_bit'
>>> drivers/irqchip/irq-sunxi-nmi.c:170: undefined reference to
>>> `irq_gc_mask_clr_bit'
>>>
>>> Fixes: commit ce3dd55b99b1 ("arm64: Introduce Allwinner SoC config
>>> option")
>>> Cc: Andre Przywara <andre.przywara@arm.com>
>>> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
>>
>>
>> It'd be nice to have a silent Kconfig entry that selects from ARCH_SUNXI
>> that
>> sets this dependency, instead of having it from the architecture code.
>> This
>> pushes down the dependency to the right level.
>
>
> Do you mean something like :
> config ARCH_SUNXI
>         ...
>         select SUNXI_PLATFORM
>
> And have
>
> config SUNXI_PLATFORM
>         select SUNXI_DEPENDENCY_1
>         select SUNXI_DEPENDENCY_2
>
> where SUNXI_PLATFORM drives the dependencies for both ARM and ARM64 ?

No, I believe what Olof is saying is make the kconfig symbol for the
irqchip (irq-sunxi-nmi) select it. If there is not a kconfig symbol
already for it because you just use ARCH_SUNXI directly, then add it.

Rob

[toc] | [prev] | [next] | [standalone]

#1377938

FromSuzuki K Poulose <Suzuki.Poulose@arm.com>
Date2016-04-13 15:30 +0200
Message-ID<rnt1O-1O6-43@gated-at.bofh.it>
In reply to#1377919
On 13/04/16 14:17, Rob Herring wrote:
> On Wed, Apr 13, 2016 at 4:05 AM, Suzuki K Poulose
> <Suzuki.Poulose@arm.com> wrote:
>> On 12/04/16 20:11, Olof Johansson wrote:
>>>
>>> On Tue, Mar 29, 2016 at 11:03:06AM +0100, Suzuki K Poulose wrote:

>> Do you mean something like :
>> config ARCH_SUNXI
>>          ...
>>          select SUNXI_PLATFORM
>>
>> And have
>>
>> config SUNXI_PLATFORM
>>          select SUNXI_DEPENDENCY_1
>>          select SUNXI_DEPENDENCY_2
>>
>> where SUNXI_PLATFORM drives the dependencies for both ARM and ARM64 ?
>
> No, I believe what Olof is saying is make the kconfig symbol for the
> irqchip (irq-sunxi-nmi) select it. If there is not a kconfig symbol
> already for it because you just use ARCH_SUNXI directly, then add it.

Ok, makes sense. Thanks, will respin it.

Suzuki

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web