Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1377877 > unrolled thread
| Started by | Alexander Potapenko <glider@google.com> |
|---|---|
| First post | 2016-04-13 14:10 +0200 |
| Last post | 2016-04-15 18:30 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH v2] lib/stackdepot.c: allow the stack trace hash to be zero Alexander Potapenko <glider@google.com> - 2016-04-13 14:10 +0200
Re: [PATCH v2] lib/stackdepot.c: allow the stack trace hash to be zero Andrey Ryabinin <ryabinin.a.a@gmail.com> - 2016-04-15 18:30 +0200
| From | Alexander Potapenko <glider@google.com> |
|---|---|
| Date | 2016-04-13 14:10 +0200 |
| Subject | [PATCH v2] lib/stackdepot.c: allow the stack trace hash to be zero |
| Message-ID | <rnrMo-116-63@gated-at.bofh.it> |
Do not bail out from depot_save_stack() if the stack trace has zero hash. Initially depot_save_stack() silently dropped stack traces with zero hashes, however there's actually no point in reserving this zero value. Reported-by: Joonsoo Kim <iamjoonsoo.kim@lge.com> Signed-off-by: Alexander Potapenko <glider@google.com> --- lib/stackdepot.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/lib/stackdepot.c b/lib/stackdepot.c index 654c9d8..9e0b031 100644 --- a/lib/stackdepot.c +++ b/lib/stackdepot.c @@ -210,10 +210,6 @@ depot_stack_handle_t depot_save_stack(struct stack_trace *trace, goto fast_exit; hash = hash_stack(trace->entries, trace->nr_entries); - /* Bad luck, we won't store this stack. */ - if (hash == 0) - goto exit; - bucket = &stack_table[hash & STACK_HASH_MASK]; /* -- 2.8.0.rc3.226.g39d4020
[toc] | [next] | [standalone]
| From | Andrey Ryabinin <ryabinin.a.a@gmail.com> |
|---|---|
| Date | 2016-04-15 18:30 +0200 |
| Subject | Re: [PATCH v2] lib/stackdepot.c: allow the stack trace hash to be zero |
| Message-ID | <roeN5-5WB-39@gated-at.bofh.it> |
| In reply to | #1377877 |
On 04/13/2016 03:07 PM, Alexander Potapenko wrote: > Do not bail out from depot_save_stack() if the stack trace has zero hash. > Initially depot_save_stack() silently dropped stack traces with zero > hashes, however there's actually no point in reserving this zero value. > > Reported-by: Joonsoo Kim <iamjoonsoo.kim@lge.com> > Signed-off-by: Alexander Potapenko <glider@google.com> Acked-by: Andrey Ryabinin <aryabinin@virtuozzo.com> > --- > lib/stackdepot.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/lib/stackdepot.c b/lib/stackdepot.c > index 654c9d8..9e0b031 100644 > --- a/lib/stackdepot.c > +++ b/lib/stackdepot.c > @@ -210,10 +210,6 @@ depot_stack_handle_t depot_save_stack(struct stack_trace *trace, > goto fast_exit; > > hash = hash_stack(trace->entries, trace->nr_entries); > - /* Bad luck, we won't store this stack. */ > - if (hash == 0) > - goto exit; > - > bucket = &stack_table[hash & STACK_HASH_MASK]; > > /* >
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web