Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1377436 > unrolled thread

[PATCH] Staging: Fixed coding style warning

Started byPanos Vlachos <panosvlchs@gmail.com>
First post2016-04-13 02:20 +0200
Last post2016-04-13 02:40 +0200
Articles 3 — 3 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] Staging: Fixed coding style warning Panos Vlachos <panosvlchs@gmail.com> - 2016-04-13 02:20 +0200
    Re: [PATCH] Staging: Fixed coding style warning Joe Perches <joe@perches.com> - 2016-04-13 02:30 +0200
    Re: [PATCH] Staging: Fixed coding style warning Greg KH <greg@kroah.com> - 2016-04-13 02:40 +0200

#1377436 — [PATCH] Staging: Fixed coding style warning

FromPanos Vlachos <panosvlchs@gmail.com>
Date2016-04-13 02:20 +0200
Subject[PATCH] Staging: Fixed coding style warning
Message-ID<rngHg-8eN-9@gated-at.bofh.it>
Fixed coding style warning

Signed-off-by: Panos Vlachos <panosvlchs@gmail.com>
---
 drivers/staging/lustre/lnet/lnet/nidstrings.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/lustre/lnet/lnet/nidstrings.c b/drivers/staging/lustre/lnet/lnet/nidstrings.c
index ebf468f..f532e44 100644
--- a/drivers/staging/lustre/lnet/lnet/nidstrings.c
+++ b/drivers/staging/lustre/lnet/lnet/nidstrings.c
@@ -197,7 +197,7 @@ add_nidrange(const struct cfs_lstr *src,
 	struct netstrfns *nf;
 	struct nidrange *nr;
 	int endlen;
-	unsigned netnum;
+	int netnum;
 
 	if (src->ls_len >= LNET_NIDSTR_SIZE)
 		return NULL;
-- 
1.9.1

[toc] | [next] | [standalone]


#1377444

FromJoe Perches <joe@perches.com>
Date2016-04-13 02:30 +0200
Message-ID<rngQW-8jN-3@gated-at.bofh.it>
In reply to#1377436
On Wed, 2016-04-13 at 03:10 +0300, Panos Vlachos wrote:
> Fixed coding style warning
[]
> diff --git a/drivers/staging/lustre/lnet/lnet/nidstrings.c b/drivers/staging/lustre/lnet/lnet/nidstrings.c
[]
> @@ -197,7 +197,7 @@ add_nidrange(const struct cfs_lstr *src,
>  	struct netstrfns *nf;
>  	struct nidrange *nr;
>  	int endlen;
> -	unsigned netnum;
> +	int netnum;

Why change the type from unsigned to signed?

[toc] | [prev] | [next] | [standalone]


#1377448

FromGreg KH <greg@kroah.com>
Date2016-04-13 02:40 +0200
Message-ID<rnh0C-8oX-15@gated-at.bofh.it>
In reply to#1377436
On Wed, Apr 13, 2016 at 03:10:45AM +0300, Panos Vlachos wrote:
> Fixed coding style warning

What warning?

And always put the driver name in the subject so we know where to merge
this to.

And finally, use get_maintainer.pl to determine who to send this to.

thanks,

greg k-h

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web