Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1374419 > unrolled thread

[PATCH] drivers/net/ethernet/jme.c: Deinline jme_reset_mac_processor, save 2816 bytes

Back to article view | Back to linux.kernel

Contents

  [PATCH] drivers/net/ethernet/jme.c: Deinline jme_reset_mac_processor, save 2816 bytes Denys Vlasenko <dvlasenk@redhat.com> - 2016-04-08 20:50 +0200
    Re: [PATCH] drivers/net/ethernet/jme.c: Deinline  jme_reset_mac_processor, save 2816 bytes David Miller <davem@davemloft.net> - 2016-04-14 05:00 +0200

#1374419 — [PATCH] drivers/net/ethernet/jme.c: Deinline jme_reset_mac_processor, save 2816 bytes

This function compiles to 895 bytes of machine code.

Clearly, this isn't a time-critical function.
For one, it has a number of udelay(1) calls.

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
CC: David S. Miller <davem@davemloft.net>
CC: linux-kernel@vger.kernel.org
CC: netdev@vger.kernel.org
---
 drivers/net/ethernet/jme.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/jme.c b/drivers/net/ethernet/jme.c
index 3ddf657..711cb19 100644
--- a/drivers/net/ethernet/jme.c
+++ b/drivers/net/ethernet/jme.c
@@ -222,7 +222,7 @@ jme_clear_ghc_reset(struct jme_adapter *jme)
 	jwrite32f(jme, JME_GHC, jme->reg_ghc);
 }
 
-static inline void
+static void
 jme_reset_mac_processor(struct jme_adapter *jme)
 {
 	static const u32 mask[WAKEUP_FRAME_MASK_DWNR] = {0, 0, 0, 0};
-- 
2.1.0

[toc] | [next] | [standalone]

#1378423 — Re: [PATCH] drivers/net/ethernet/jme.c: Deinline jme_reset_mac_processor, save 2816 bytes

From: Denys Vlasenko <dvlasenk@redhat.com>
Date: Fri,  8 Apr 2016 20:39:47 +0200

> This function compiles to 895 bytes of machine code.
> 
> Clearly, this isn't a time-critical function.
> For one, it has a number of udelay(1) calls.
> 
> Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>

No x.c file should be using inline anyways, applied to net-next,
thanks a lot!

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web