Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1376568 > unrolled thread
| Started by | lipengcheng <lipengcheng8@huawei.com> |
|---|---|
| First post | 2016-04-12 11:00 +0200 |
| Last post | 2016-04-12 18:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] coresight: etm4x: modify q_support type lipengcheng <lipengcheng8@huawei.com> - 2016-04-12 11:00 +0200
Re: [PATCH] coresight: etm4x: modify q_support type Mathieu Poirier <mathieu.poirier@linaro.org> - 2016-04-12 18:10 +0200
| From | lipengcheng <lipengcheng8@huawei.com> |
|---|---|
| Date | 2016-04-12 11:00 +0200 |
| Subject | [PATCH] coresight: etm4x: modify q_support type |
| Message-ID | <rn2kW-4eA-5@gated-at.bofh.it> |
Because this operation exceed the range of boolean, so we should
modify q_support to unit32 bit.
drvdata->q_support = BMVAL(etmidr0, 15, 16)
Signed-off-by: Li Pengcheng <lipengcheng8@huawei.com>
Signed-off-by: Li Zhong <lizhong11@hisilicon.com>
---
drivers/hwtracing/coresight/coresight-etm4x.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwtracing/coresight/coresight-etm4x.h b/drivers/hwtracing/coresight/coresight-etm4x.h
index c341002..305b29a 100644
--- a/drivers/hwtracing/coresight/coresight-etm4x.h
+++ b/drivers/hwtracing/coresight/coresight-etm4x.h
@@ -330,7 +330,7 @@ struct etmv4_drvdata {
u32 ccctlr;
bool trcbb;
u32 bb_ctrl;
- bool q_support;
+ u32 q_support;
u32 vinst_ctrl;
u32 viiectlr;
u32 vissctlr;
--
1.8.3.2
[toc] | [next] | [standalone]
| From | Mathieu Poirier <mathieu.poirier@linaro.org> |
|---|---|
| Date | 2016-04-12 18:10 +0200 |
| Message-ID | <rn933-1H3-3@gated-at.bofh.it> |
| In reply to | #1376568 |
On 12 April 2016 at 02:58, lipengcheng <lipengcheng8@huawei.com> wrote:
> Because this operation exceed the range of boolean, so we should
> modify q_support to unit32 bit.
> drvdata->q_support = BMVAL(etmidr0, 15, 16)
>
> Signed-off-by: Li Pengcheng <lipengcheng8@huawei.com>
> Signed-off-by: Li Zhong <lizhong11@hisilicon.com>
> ---
> drivers/hwtracing/coresight/coresight-etm4x.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-etm4x.h b/drivers/hwtracing/coresight/coresight-etm4x.h
> index c341002..305b29a 100644
> --- a/drivers/hwtracing/coresight/coresight-etm4x.h
> +++ b/drivers/hwtracing/coresight/coresight-etm4x.h
> @@ -330,7 +330,7 @@ struct etmv4_drvdata {
> u32 ccctlr;
> bool trcbb;
> u32 bb_ctrl;
> - bool q_support;
> + u32 q_support;
Unfortunately this patch doesn't apply on my side. Please rebase on
my next tree [1], branch "next".
Thanks,
Mathieu
[1]. https://git.linaro.org/kernel/coresight.git
> u32 vinst_ctrl;
> u32 viiectlr;
> u32 vissctlr;
> --
> 1.8.3.2
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web