Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1376422 > unrolled thread
| Started by | Shawn Guo <shawnguo@kernel.org> |
|---|---|
| First post | 2016-04-12 05:00 +0200 |
| Last post | 2016-04-13 04:50 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 2/2] dts/ls1043a: add the DTS node for QSPI support Shawn Guo <shawnguo@kernel.org> - 2016-04-12 05:00 +0200
RE: [PATCH 2/2] dts/ls1043a: add the DTS node for QSPI support Yao Yuan <yao.yuan@nxp.com> - 2016-04-13 04:50 +0200
| From | Shawn Guo <shawnguo@kernel.org> |
|---|---|
| Date | 2016-04-12 05:00 +0200 |
| Subject | Re: [PATCH 2/2] dts/ls1043a: add the DTS node for QSPI support |
| Message-ID | <rmWIy-8cp-5@gated-at.bofh.it> |
On Thu, Mar 31, 2016 at 02:45:01PM +0800, Yuan Yao wrote:
> From: Yuan Yao <yao.yuan@nxp.com>
>
> Signed-off-by: Yuan Yao <yao.yuan@nxp.com>
Please style of 'arm64: dts: ls1043a: ' for subject prefix.
> ---
> arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts | 16 ++++++++++++++++
> arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 14 ++++++++++++++
> 2 files changed, 30 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
> index 97e9906..c8303a3 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
> @@ -100,6 +100,22 @@
> };
> };
>
> +&qspi {
Please sort such labeled node alphabetically in label name. That said,
it should go after &lpuart0.
> + num-cs = <2>;
I do not see this property in bindings doc.
> + bus-num = <0>;
> + status = "okay";
Please let 'status' line be the last of property list.
> + fsl,ddr-sampling-point = <4>;
I do not see this one in bindings definition either.
> +
> + qflash0: s25fl128s@0 {
> + compatible = "spansion,m25p80";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + spi-max-frequency = <20000000>;
> + ddr-quad-read;
Ditto
> + reg = <0>;
> + };
> +};
> +
> &i2c0 {
> status = "okay";
> pca9547@77 {
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> index be72bf5..49b1aeb 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> @@ -208,6 +208,20 @@
> status = "disabled";
> };
>
> + qspi: quadspi@1550000 {
Please sort the node in <soc>.dtsi in order of unit-address. That said,
the node should be added between ifc@1530000 and esdhc@1560000.
Shawn
> + compatible = "fsl,ls1043a-qspi", "fsl,ls1021a-qspi";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0x0 0x1550000 0x0 0x10000>,
> + <0x0 0x40000000 0x0 0x4000000>;
> + reg-names = "QuadSPI", "QuadSPI-memory";
> + interrupts = <0 99 0x4>;
> + clock-names = "qspi_en", "qspi";
> + clocks = <&clockgen 4 0>, <&clockgen 4 0>;
> + big-endian;
> + status = "disabled";
> + };
> +
> i2c0: i2c@2180000 {
> compatible = "fsl,vf610-i2c";
> #address-cells = <1>;
> --
> 2.1.0.27.g96db324
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
[toc] | [next] | [standalone]
| From | Yao Yuan <yao.yuan@nxp.com> |
|---|---|
| Date | 2016-04-13 04:50 +0200 |
| Message-ID | <rnj2p-1EB-1@gated-at.bofh.it> |
| In reply to | #1376422 |
On Thu, Apr 12, 2016 at 10:50:01AM +0800, Shawn Guo wrote:
> On Thu, Mar 31, 2016 at 02:45:01PM +0800, Yuan Yao wrote:
> > From: Yuan Yao <yao.yuan@nxp.com>
> >
> > Signed-off-by: Yuan Yao <yao.yuan@nxp.com>
>
> Please style of 'arm64: dts: ls1043a: ' for subject prefix.
>
> > ---
> > arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts | 16 ++++++++++++++++
> > arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 14 ++++++++++++++
> > 2 files changed, 30 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
> > b/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
> > index 97e9906..c8303a3 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
> > @@ -100,6 +100,22 @@
> > };
> > };
> >
> > +&qspi {
>
> Please sort such labeled node alphabetically in label name. That said, it should
> go after &lpuart0.
Ok, Thanks.
> > + num-cs = <2>;
>
> I do not see this property in bindings doc.
We can find this property in ./Documentation/devicetree/bindings/spi/spi-bus.txt
>
> > + bus-num = <0>;
> > + status = "okay";
>
> Please let 'status' line be the last of property list.
Ok, Thanks.
> > + fsl,ddr-sampling-point = <4>;
>
> I do not see this one in bindings definition either.
It's used for DDR mode; The DDR mode will send to upstream late.
So I will remove this, once the DDR mode patch is merged, I will send patch to add the property.
>
> > +
> > + qflash0: s25fl128s@0 {
> > + compatible = "spansion,m25p80";
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > + spi-max-frequency = <20000000>;
> > + ddr-quad-read;
>
> Ditto
Ditto, Thanks.
>
> > + reg = <0>;
> > + };
> > +};
> > +
> > &i2c0 {
> > status = "okay";
> > pca9547@77 {
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> > b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> > index be72bf5..49b1aeb 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> > @@ -208,6 +208,20 @@
> > status = "disabled";
> > };
> >
> > + qspi: quadspi@1550000 {
>
> Please sort the node in <soc>.dtsi in order of unit-address. That said, the node
> should be added between ifc@1530000 and esdhc@1560000.
Thanks. I will update it and resend it soon.
> Shawn
>
> > + compatible = "fsl,ls1043a-qspi", "fsl,ls1021a-qspi";
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + reg = <0x0 0x1550000 0x0 0x10000>,
> > + <0x0 0x40000000 0x0 0x4000000>;
> > + reg-names = "QuadSPI", "QuadSPI-memory";
> > + interrupts = <0 99 0x4>;
> > + clock-names = "qspi_en", "qspi";
> > + clocks = <&clockgen 4 0>, <&clockgen 4 0>;
> > + big-endian;
> > + status = "disabled";
> > + };
> > +
> > i2c0: i2c@2180000 {
> > compatible = "fsl,vf610-i2c";
> > #address-cells = <1>;
> > --
> > 2.1.0.27.g96db324
> >
> >
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> >
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web