Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1375874 > unrolled thread
| Started by | Jiri Slaby <jslaby@suse.cz> |
|---|---|
| First post | 2016-04-11 15:40 +0200 |
| Last post | 2016-04-11 15:40 +0200 |
| Articles | 1 — 1 participant |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 3.12 74/98] bcache: fix cache_set_flush() NULL pointer dereference on OOM Jiri Slaby <jslaby@suse.cz> - 2016-04-11 15:40 +0200
| From | Jiri Slaby <jslaby@suse.cz> |
|---|---|
| Date | 2016-04-11 15:40 +0200 |
| Subject | [PATCH 3.12 74/98] bcache: fix cache_set_flush() NULL pointer dereference on OOM |
| Message-ID | <rmKem-6GA-35@gated-at.bofh.it> |
From: Eric Wheeler <git@linux.ewheeler.net> 3.12-stable review patch. If anyone has any objections, please let me know. =============== commit f8b11260a445169989d01df75d35af0f56178f95 upstream. When bch_cache_set_alloc() fails to kzalloc the cache_set, the asyncronous closure handling tries to dereference a cache_set that hadn't yet been allocated inside of cache_set_flush() which is called by __cache_set_unregister() during cleanup. This appears to happen only during an OOM condition on bcache_register. Signed-off-by: Eric Wheeler <bcache@linux.ewheeler.net> Signed-off-by: Jiri Slaby <jslaby@suse.cz> --- drivers/md/bcache/super.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c index 70d396ee69e2..2a697b3d58c5 100644 --- a/drivers/md/bcache/super.c +++ b/drivers/md/bcache/super.c @@ -1343,6 +1343,9 @@ static void cache_set_flush(struct closure *cl) struct btree *b; unsigned i; + if (!c) + closure_return(cl); + bch_cache_accounting_destroy(&c->accounting); kobject_put(&c->internal); -- 2.8.1
Back to top | Article view | linux.kernel
csiph-web