Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1371632 > unrolled thread
| Started by | John Keeping <john@metanate.com> |
|---|---|
| First post | 2016-04-05 16:00 +0200 |
| Last post | 2016-04-11 05:00 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 1/2] drm/rockchip: remove redundant statement John Keeping <john@metanate.com> - 2016-04-05 16:00 +0200
Re: [PATCH 1/2] drm/rockchip: remove redundant statement Mark yao <mark.yao@rock-chips.com> - 2016-04-11 05:00 +0200
| From | John Keeping <john@metanate.com> |
|---|---|
| Date | 2016-04-05 16:00 +0200 |
| Subject | [PATCH 1/2] drm/rockchip: remove redundant statement |
| Message-ID | <rkzGr-4wA-21@gated-at.bofh.it> |
The call to arm_iommu_detach_device() on the previous line sets dev->archdata.mapping to NULL so this call is always a no-op. Signed-off-by: John Keeping <john@metanate.com> --- drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c index f556a8f..7695c79 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c +++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c @@ -244,7 +244,6 @@ static int rockchip_drm_unload(struct drm_device *drm_dev) drm_kms_helper_poll_fini(drm_dev); component_unbind_all(dev, drm_dev); arm_iommu_detach_device(dev); - arm_iommu_release_mapping(dev->archdata.mapping); drm_mode_config_cleanup(drm_dev); drm_dev->dev_private = NULL; -- 2.8.0.rc4.238.g874082a
[toc] | [next] | [standalone]
| From | Mark yao <mark.yao@rock-chips.com> |
|---|---|
| Date | 2016-04-11 05:00 +0200 |
| Message-ID | <rmAf0-75P-15@gated-at.bofh.it> |
| In reply to | #1371632 |
On 2016年04月05日 21:50, John Keeping wrote: > The call to arm_iommu_detach_device() on the previous line sets > dev->archdata.mapping to NULL so this call is always a no-op. > > Signed-off-by: John Keeping <john@metanate.com> > --- > drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c > index f556a8f..7695c79 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c > @@ -244,7 +244,6 @@ static int rockchip_drm_unload(struct drm_device *drm_dev) > drm_kms_helper_poll_fini(drm_dev); > component_unbind_all(dev, drm_dev); > arm_iommu_detach_device(dev); > - arm_iommu_release_mapping(dev->archdata.mapping); > drm_mode_config_cleanup(drm_dev); > drm_dev->dev_private = NULL; > Applied to my drm-fixes Thanks.:-) -- Ｍark Yao
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web