Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1374676 > unrolled thread
| Started by | Rui Salvaterra <rsalvaterra@gmail.com> |
|---|---|
| First post | 2016-04-09 23:10 +0200 |
| Last post | 2016-04-10 03:50 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH v2 0/2] lib: lz4: fix for big endian and cleanup Rui Salvaterra <rsalvaterra@gmail.com> - 2016-04-09 23:10 +0200
[PATCH v2 2/2] lib: lz4: cleanup unaligned access efficiency detection Rui Salvaterra <rsalvaterra@gmail.com> - 2016-04-09 23:10 +0200
Re: [PATCH v2 2/2] lib: lz4: cleanup unaligned access efficiency detection Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2016-04-10 03:50 +0200
| From | Rui Salvaterra <rsalvaterra@gmail.com> |
|---|---|
| Date | 2016-04-09 23:10 +0200 |
| Subject | [PATCH v2 0/2] lib: lz4: fix for big endian and cleanup |
| Message-ID | <rm8iK-2K1-5@gated-at.bofh.it> |
v2: - Addressed GregKH's review and comments. Hi, The first patch fixes zram with lz4 compression on ppc64 (and big endian architectures with efficient unaligned access), the second is just a cleanup. Thanks, Rui Rui Salvaterra (2): lib: lz4: fixed zram with lz4 on big endian machines lib: lz4: cleanup unaligned access efficiency detection lib/lz4/lz4defs.h | 25 +++++++++++++------------ 1 file changed, 13 insertions(+), 12 deletions(-) -- 2.7.4
[toc] | [next] | [standalone]
| From | Rui Salvaterra <rsalvaterra@gmail.com> |
|---|---|
| Date | 2016-04-09 23:10 +0200 |
| Subject | [PATCH v2 2/2] lib: lz4: cleanup unaligned access efficiency detection |
| Message-ID | <rm8iK-2K1-3@gated-at.bofh.it> |
| In reply to | #1374676 |
These identifiers are bogus. The interested architectures should define
HAVE_EFFICIENT_UNALIGNED_ACCESS whenever relevant to do so. If this
isn't true for some arch, it should be fixed in the arch definition.
Signed-off-by: Rui Salvaterra <rsalvaterra@gmail.com>
---
lib/lz4/lz4defs.h | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/lib/lz4/lz4defs.h b/lib/lz4/lz4defs.h
index 0710a62..c79d7ea 100644
--- a/lib/lz4/lz4defs.h
+++ b/lib/lz4/lz4defs.h
@@ -24,9 +24,7 @@
typedef struct _U16_S { u16 v; } U16_S;
typedef struct _U32_S { u32 v; } U32_S;
typedef struct _U64_S { u64 v; } U64_S;
-#if defined(CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS) \
- || defined(CONFIG_ARM) && __LINUX_ARM_ARCH__ >= 6 \
- && defined(ARM_EFFICIENT_UNALIGNED_ACCESS)
+#if defined(CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS)
#define A16(x) (((U16_S *)(x))->v)
#define A32(x) (((U32_S *)(x))->v)
--
2.7.4
[toc] | [prev] | [next] | [standalone]
| From | Sergey Senozhatsky <sergey.senozhatsky@gmail.com> |
|---|---|
| Date | 2016-04-10 03:50 +0200 |
| Subject | Re: [PATCH v2 2/2] lib: lz4: cleanup unaligned access efficiency detection |
| Message-ID | <rmcFI-5Ud-1@gated-at.bofh.it> |
| In reply to | #1374677 |
On (04/09/16 22:05), Rui Salvaterra wrote:
> These identifiers are bogus. The interested architectures should define
> HAVE_EFFICIENT_UNALIGNED_ACCESS whenever relevant to do so. If this
> isn't true for some arch, it should be fixed in the arch definition.
yes, besides ARM_EFFICIENT_UNALIGNED_ACCESS exists only in lib/lz4/lz4defs.h
> Signed-off-by: Rui Salvaterra <rsalvaterra@gmail.com>
Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
-ss
> ---
> lib/lz4/lz4defs.h | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/lib/lz4/lz4defs.h b/lib/lz4/lz4defs.h
> index 0710a62..c79d7ea 100644
> --- a/lib/lz4/lz4defs.h
> +++ b/lib/lz4/lz4defs.h
> @@ -24,9 +24,7 @@
> typedef struct _U16_S { u16 v; } U16_S;
> typedef struct _U32_S { u32 v; } U32_S;
> typedef struct _U64_S { u64 v; } U64_S;
> -#if defined(CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS) \
> - || defined(CONFIG_ARM) && __LINUX_ARM_ARCH__ >= 6 \
> - && defined(ARM_EFFICIENT_UNALIGNED_ACCESS)
> +#if defined(CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS)
>
> #define A16(x) (((U16_S *)(x))->v)
> #define A32(x) (((U32_S *)(x))->v)
> --
> 2.7.4
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web