Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1372990 > unrolled thread
| Started by | Dan Williams <dan.j.williams@intel.com> |
|---|---|
| First post | 2016-04-07 03:00 +0200 |
| Last post | 2016-04-07 10:30 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] libnvdimm: fix smart data retrieval Dan Williams <dan.j.williams@intel.com> - 2016-04-07 03:00 +0200
Re: [PATCH] libnvdimm: fix smart data retrieval Johannes Thumshirn <jthumshirn@suse.de> - 2016-04-07 10:30 +0200
| From | Dan Williams <dan.j.williams@intel.com> |
|---|---|
| Date | 2016-04-07 03:00 +0200 |
| Subject | [PATCH] libnvdimm: fix smart data retrieval |
| Message-ID | <rl6sF-3TK-1@gated-at.bofh.it> |
It appears that smart data retrieval has been broken the since the
initial implementation. Fix the payload size to be 128-bytes per the
specification.
Cc: <stable@vger.kernel.org>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
---
drivers/nvdimm/bus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvdimm/bus.c b/drivers/nvdimm/bus.c
index fc82743aefb6..19f822d7f652 100644
--- a/drivers/nvdimm/bus.c
+++ b/drivers/nvdimm/bus.c
@@ -407,7 +407,7 @@ static const struct nd_cmd_desc __nd_cmd_dimm_descs[] = {
[ND_CMD_IMPLEMENTED] = { },
[ND_CMD_SMART] = {
.out_num = 2,
- .out_sizes = { 4, 8, },
+ .out_sizes = { 4, 128, },
},
[ND_CMD_SMART_THRESHOLD] = {
.out_num = 2,
[toc] | [next] | [standalone]
| From | Johannes Thumshirn <jthumshirn@suse.de> |
|---|---|
| Date | 2016-04-07 10:30 +0200 |
| Message-ID | <rldub-10J-19@gated-at.bofh.it> |
| In reply to | #1372990 |
On Mittwoch, 6. April 2016 17:53:44 CEST Dan Williams wrote: > It appears that smart data retrieval has been broken the since the > initial implementation. Fix the payload size to be 128-bytes per the > specification. > > Cc: <stable@vger.kernel.org> > Signed-off-by: Dan Williams <dan.j.williams@intel.com> > --- Good catch, Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de> -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web