Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1371685 > unrolled thread

[PATCH] staging/lustre/obdclass: fix build warning

Started bySudip Mukherjee <sudipm.mukherjee@gmail.com>
First post2016-04-05 16:50 +0200
Last post2016-04-06 21:00 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] staging/lustre/obdclass: fix build warning Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-04-05 16:50 +0200
    Re: [lustre-devel] [PATCH] staging/lustre/obdclass: fix build  warning James Simmons <jsimmons@infradead.org> - 2016-04-06 21:00 +0200

#1371685 — [PATCH] staging/lustre/obdclass: fix build warning

FromSudip Mukherjee <sudipm.mukherjee@gmail.com>
Date2016-04-05 16:50 +0200
Subject[PATCH] staging/lustre/obdclass: fix build warning
Message-ID<rkAsO-5ez-15@gated-at.bofh.it>
While building with W=1 we were getting the warning:

drivers/staging/lustre/lustre/obdclass/cl_object.c:1056:16:
	warning: old-style function definition
 struct lu_env *cl_env_percpu_get()
                ^

Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
---
 drivers/staging/lustre/lustre/obdclass/cl_object.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/lustre/lustre/obdclass/cl_object.c b/drivers/staging/lustre/lustre/obdclass/cl_object.c
index 395b92c..d84ec00 100644
--- a/drivers/staging/lustre/lustre/obdclass/cl_object.c
+++ b/drivers/staging/lustre/lustre/obdclass/cl_object.c
@@ -1053,7 +1053,7 @@ void cl_env_percpu_put(struct lu_env *env)
 }
 EXPORT_SYMBOL(cl_env_percpu_put);
 
-struct lu_env *cl_env_percpu_get()
+struct lu_env *cl_env_percpu_get(void)
 {
 	struct cl_env *cle;
 
-- 
1.9.1

[toc] | [next] | [standalone]


#1372738 — Re: [lustre-devel] [PATCH] staging/lustre/obdclass: fix build warning

FromJames Simmons <jsimmons@infradead.org>
Date2016-04-06 21:00 +0200
SubjectRe: [lustre-devel] [PATCH] staging/lustre/obdclass: fix build warning
Message-ID<rl0Qj-8hK-43@gated-at.bofh.it>
In reply to#1371685
> While building with W=1 we were getting the warning:
> 
> drivers/staging/lustre/lustre/obdclass/cl_object.c:1056:16:
> 	warning: old-style function definition
>  struct lu_env *cl_env_percpu_get()
>                 ^
> 
> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>

Acked-by: James Simmons <jsimmons@infradead.org>

> ---
>  drivers/staging/lustre/lustre/obdclass/cl_object.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/lustre/lustre/obdclass/cl_object.c b/drivers/staging/lustre/lustre/obdclass/cl_object.c
> index 395b92c..d84ec00 100644
> --- a/drivers/staging/lustre/lustre/obdclass/cl_object.c
> +++ b/drivers/staging/lustre/lustre/obdclass/cl_object.c
> @@ -1053,7 +1053,7 @@ void cl_env_percpu_put(struct lu_env *env)
>  }
>  EXPORT_SYMBOL(cl_env_percpu_put);
>  
> -struct lu_env *cl_env_percpu_get()
> +struct lu_env *cl_env_percpu_get(void)
>  {
>  	struct cl_env *cle;
>  
> -- 
> 1.9.1
> 
> _______________________________________________
> lustre-devel mailing list
> lustre-devel@lists.lustre.org
> http://lists.lustre.org/listinfo.cgi/lustre-devel-lustre.org
> 

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web